Ports evaluation changes to v1 plans #1573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v1 #1573 +/- ##
=====================================
Coverage ? 77.23%
Complexity ? 2514
=====================================
Files ? 253
Lines ? 18563
Branches ? 3523
=====================================
Hits ? 14337
Misses ? 3192
Partials ? 1034
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
johnedquinn
reviewed
Sep 3, 2024
partiql-plan/src/main/kotlin/org/partiql/plan/v1/operator/rel/RelExcludeStep.kt
Outdated
Show resolved
Hide resolved
| @@ -13,7 +12,7 @@ public interface RelScan : Rel { | |||
|
|
|||
| override fun getChildren(): Collection<Rel> = emptyList() | |||
|
|
|||
| override fun isOrdered(): Boolean = getInput().getType().kind == PType.Kind.ARRAY | |||
| override fun isOrdered(): Boolean = false | |||
There was a problem hiding this comment.
We don't have typing of the nodes, so this would throw an exception.
alancai98
reviewed
Sep 4, 2024
partiql-plan/src/main/kotlin/org/partiql/plan/v1/operator/rex/RexCallDynamic.kt
Show resolved
Hide resolved
partiql-plan/src/main/kotlin/org/partiql/plan/v1/operator/rex/RexNullIf.kt
Outdated
Show resolved
Hide resolved
partiql-plan/src/main/kotlin/org/partiql/plan/v1/operator/rel/RelJoin.kt
Outdated
Show resolved
Hide resolved
partiql-plan/src/main/kotlin/org/partiql/plan/v1/operator/rel/RelExcludeStep.kt
Show resolved
Hide resolved
partiql-plan/src/main/kotlin/org/partiql/plan/v1/operator/rel/RelExcludeStep.kt
Outdated
Show resolved
Hide resolved
partiql-plan/src/main/kotlin/org/partiql/plan/v1/operator/rel/RelExcludeStep.kt
Outdated
Show resolved
Hide resolved
92a4994 to
c82156c
Compare
CROSS-ENGINE Conformance Report ❌
Testing DetailsResult Details
Now Failing Tests ❌The complete list can be found in GitHub CI summary, either from Step Summary or in the Artifact. CROSS-COMMIT-EVAL Conformance Report ✅
Testing DetailsResult Details
CROSS-COMMIT-LEGACY Conformance Report ✅
Testing DetailsResult Details
|
alancai98
reviewed
Sep 5, 2024
Comment on lines
436
to
443
| <<<<<<< HEAD | ||
| ======= | ||
| * TODO REMOVE ME | ||
| */ | ||
| public fun rexNullIf(value: Rex, nullifier: Rex): RexNullIf = RexNullIfImpl(value, nullifier) | ||
|
|
||
| /** | ||
| >>>>>>> c2cc48d5 (Ports evaluation changes to v1 plans) |
There was a problem hiding this comment.
some remaining merge conflict?
partiql-plan/src/main/kotlin/org/partiql/plan/v1/operator/rex/RexCallDynamic.kt
Show resolved
Hide resolved
alancai98
approved these changes
Sep 5, 2024
partiql-plan/src/main/kotlin/org/partiql/plan/v1/operator/rex/RexCallDynamic.kt
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant Issues
#1548
Description
This PR applies the modifications to the v1.plan package which we needed to switch the intermediate representation used for execution.
It adds,
There are cleanup TODOs for several things we needed to pass existing tests with minimal changes, these include
Other Information
and Code Style Guidelines? YES
License Information
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.