Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates engine to be based upon the V1 plan interfaces #1548

Closed
wants to merge 12 commits into from

Conversation

rchowell
Copy link
Contributor

Relevant Issues

#1535

Description

This is a follow-up to #1535 which initialized the V1 plan builders.

This PR...

  • Consolidates/simplifies where the implementations live.
  • Uses deferred builders with custom factories

Other Information

License Information

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

github-actions bot commented Aug 14, 2024

CROSS-ENGINE Conformance Report ❌

BASE (LEGACY-96726D8) TARGET (EVAL-96726D8) +/-
% Passing 90.45% 81.97% -8.48% ⭕
Passing 5333 4833 -500 ⭕
Failing 563 1063 500 ⭕
Ignored 0 0 0 ✅
Total Tests 5896 5896 0 ✅

Testing Details

  • Base Commit: 96726d8
  • Base Engine: LEGACY
  • Target Commit: 96726d8
  • Target Engine: EVAL

Result Details

  • ❌ REGRESSION DETECTED. See Now Failing Tests. ❌
  • Passing in both: 4393
  • Failing in both: 123
  • PASSING in BASE but now FAILING in TARGET: 940
  • FAILING in BASE but now PASSING in TARGET: 440

Now Failing Tests ❌

The complete list can be found in GitHub CI summary, either from Step Summary or in the Artifact.

Now Passing Tests

440 test(s) were previously failing in BASE (LEGACY-96726D8) but now pass in TARGET (EVAL-96726D8). Before merging, confirm they are intended to pass.

The complete list can be found in GitHub CI summary, either from Step Summary or in the Artifact.

CROSS-COMMIT-LEGACY Conformance Report ✅

BASE (LEGACY-A54F6AD) TARGET (LEGACY-96726D8) +/-
% Passing 89.65% 90.45% 0.80% ✅
Passing 5286 5333 47 ✅
Failing 610 563 -47 ✅
Ignored 0 0 0 ✅
Total Tests 5896 5896 0 ✅

Testing Details

  • Base Commit: a54f6ad
  • Base Engine: LEGACY
  • Target Commit: 96726d8
  • Target Engine: LEGACY

Result Details

  • Passing in both: 5286
  • Failing in both: 563
  • PASSING in BASE but now FAILING in TARGET: 0
  • FAILING in BASE but now PASSING in TARGET: 47

Now Passing Tests

47 test(s) were previously failing in BASE (LEGACY-A54F6AD) but now pass in TARGET (LEGACY-96726D8). Before merging, confirm they are intended to pass.

The complete list can be found in GitHub CI summary, either from Step Summary or in the Artifact.

CROSS-COMMIT-EVAL Conformance Report ❌

BASE (EVAL-A54F6AD) TARGET (EVAL-96726D8) +/-
% Passing 94.22% 81.97% -12.25% ⭕
Passing 5555 4833 -722 ⭕
Failing 74 1063 989 ⭕
Ignored 267 0 -267 ✅
Total Tests 5896 5896 0 ✅

Testing Details

  • Base Commit: a54f6ad
  • Base Engine: EVAL
  • Target Commit: 96726d8
  • Target Engine: EVAL

Result Details

  • ❌ REGRESSION DETECTED. See Now Failing Tests. ❌
  • Passing in both: 4647
  • Failing in both: 74
  • PASSING in BASE but now FAILING in TARGET: 908
  • FAILING in BASE but now PASSING in TARGET: 0

Now Failing Tests ❌

The complete list can be found in GitHub CI summary, either from Step Summary or in the Artifact.

@rchowell rchowell changed the title Updates V1 plan builders to use a factory and consolidates impls Updates engine to be based upon the V1 plan interfaces Aug 21, 2024
@rchowell rchowell marked this pull request as draft August 21, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant