-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compiling .ino files #11
Conversation
a4f6695
to
d13a5ff
Compare
@laupow thanks for the changes. Overall as I scanned through, the PR looks good to me. Does it make sense for me to test this locally and if yes, could you please point me to any testing instructions that I can try to use? |
@keeramis Yeah, it's likely a good idea to test a To test these changes locally, you can checkout this branch and then run the steps over here: https://github.com/particle-iot/compile-action/blob/main/DEVELOPMENT.md For the I added a copy of Tinker and this PR adds some checks to make sure Tinker (in an ino file) compiles |
b672de6
to
44776c2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as expected. 👍
INPUT_DEVICE-OS-VERSION=default
gives the default/most relevant device-os version for that platform (ex:electron
points to2.3.1
,tracker
points to4.0.2
,p2
points to5.3.1
)INPUT_DEVICE-OS-VERSION=latest_lts
gives it's LTS version is available (ex:electron
points to2.3.1
,tracker
points to4.0.2
,p2
gives an error)INPUT_DEVICE-OS-VERSION=latest
gives the latest (ex:electron
points to3.3.1
,tracker
points to5.3.1
)
Story details: https://app.shortcut.com/particle/story/117875
I embedded code from https://github.com/particle-iot/buildpack-wiring-preprocessor to mirror the cloud compiler's preprocessing step.
Do we have any other places that use this code @suda? I'm ok embedding the cparser code this way.
depends on #10