-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use /v1/build_targets API #10
Conversation
It is the better data source
The resolveVersion function lives in util, but there was a module named versioning. It was purely auto-version functions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I am looking through the implementation, should it have made more sense if the default_versions
shows the absolute latest device-os versions among all release lines as opposed to LTS only (which is what's returned now).
Primary benefit is all platforms should have a working compile target (was not true with latest-lts as default)
@keeramis I integrated the default versions to the PR. It's a nice improvement 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (either way)! :) Whichever works for the application. 🎉
Story details: https://app.shortcut.com/particle/story/117794
This is a better API to consume to find out latest Device OS versions and platforms.