Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use /v1/build_targets API #10

Merged
merged 6 commits into from
May 2, 2023
Merged

Conversation

laupow
Copy link
Collaborator

@laupow laupow commented May 1, 2023

Story details: https://app.shortcut.com/particle/story/117794

This is a better API to consume to find out latest Device OS versions and platforms.

laupow added 3 commits May 1, 2023 12:52
It is the better data source
The resolveVersion function lives in util, but there was a module named versioning. It was purely auto-version functions.
@laupow laupow requested a review from keeramis May 1, 2023 18:03
Copy link

@keeramis keeramis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I am looking through the implementation, should it have made more sense if the default_versions shows the absolute latest device-os versions among all release lines as opposed to LTS only (which is what's returned now).

Primary benefit is all platforms should have a working compile target (was not true with latest-lts as default)
@laupow laupow requested a review from keeramis May 1, 2023 18:51
@laupow laupow mentioned this pull request May 1, 2023
@laupow
Copy link
Collaborator Author

laupow commented May 2, 2023

@keeramis I integrated the default versions to the PR. It's a nice improvement 🎉

Copy link

@keeramis keeramis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (either way)! :) Whichever works for the application. 🎉

@laupow laupow merged commit 0d5a2bc into main May 2, 2023
@laupow laupow deleted the feature/sc-117794/use-build-targets-api branch May 2, 2023 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants