Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly free swarm boundary MPI requests #1084

Merged
merged 5 commits into from
May 21, 2024
Merged

Properly free swarm boundary MPI requests #1084

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d0efcd1
MPI_Request_free instead of just setting var to null
brryan May 21, 2024
e207e63
CHANGELOG
brryan May 21, 2024
1ab8033
pointer
brryan May 21, 2024
4d133ed
I cant compile in my head :(
brryan May 21, 2024
9094e3f
Merge branch 'develop' into brryan/fix_swarm_mpi_reqs
brryan May 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@
## Current develop

### Added (new features/APIs/variables/...)
- [[PR1020]](https://github.com/parthenon-hpc-lab/parthenon/pull/1020) Add bi- and trilinear interpolation routines
- [[PR 1084]](https://github.com/parthenon-hpc-lab/parthenon/pull/1084) Properly free swarm boundary MPI requests
- [[PR 1020]](https://github.com/parthenon-hpc-lab/parthenon/pull/1020) Add bi- and trilinear interpolation routines
- [[PR 1026]](https://github.com/parthenon-hpc-lab/parthenon/pull/1026) Particle BCs without relocatable device code
- [[PR 1037]](https://github.com/parthenon-hpc-lab/parthenon/pull/1037) Add SwarmPacks
- [[PR 1068]](https://github.com/parthenon-hpc-lab/parthenon/pull/1068) Add ability to dump sparse pack contents as a string
Expand Down
4 changes: 3 additions & 1 deletion src/interface/swarm_comms.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -644,7 +644,9 @@ void Swarm::ResetCommunication() {
#ifdef MPI_PARALLEL
for (int n = 0; n < pmb->neighbors.size(); n++) {
NeighborBlock &nb = pmb->neighbors[n];
vbswarm->bd_var_.req_send[nb.bufid] = MPI_REQUEST_NULL;
if (vbswarm->bd_var_.req_send[nb.bufid] != MPI_REQUEST_NULL) {
MPI_Request_Free(&(vbswarm->bd_var_.req_send[nb.bufid]));
}
}
#endif

Expand Down
Loading