Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly free swarm boundary MPI requests #1084

Merged
merged 5 commits into from
May 21, 2024
Merged

Conversation

brryan
Copy link
Collaborator

@brryan brryan commented May 21, 2024

PR Summary

@pdmullen identified a bug in a downstream application using Parthenon particles where after a number of timesteps, MPI would fail internally. It turns out that Parthenon was not properly freeing MPI requests for swarms, but just setting its own variable to null. This is an easy fix, and solved the downstream issue.

PR Checklist

  • Code passes cpplint
  • New features are documented.
  • Adds a test for any bugs fixed. Adds tests for new features.
  • Code is formatted
  • Changes are summarized in CHANGELOG.md
  • Change is breaking (API, behavior, ...)
    • Change is additionally added to CHANGELOG.md in the breaking section
    • PR is marked as breaking
    • Short summary API changes at the top of the PR (plus optionally with an automated update/fix script)
  • CI has been triggered on Darwin for performance regression tests.
  • Docs build
  • (@lanl.gov employees) Update copyright on changed files

@brryan brryan added the bug Something isn't working label May 21, 2024
Copy link
Collaborator

@lroberts36 lroberts36 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brryan
Copy link
Collaborator Author

brryan commented May 21, 2024

A simple but important fix; setting to auto-merge

@brryan brryan enabled auto-merge (squash) May 21, 2024 17:28
@pdmullen pdmullen disabled auto-merge May 21, 2024 20:46
@pdmullen pdmullen enabled auto-merge May 21, 2024 20:47
@pdmullen pdmullen merged commit f9bb863 into develop May 21, 2024
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants