Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix failing tests on 4.x LTS branch #7661

Merged
merged 7 commits into from
Oct 30, 2021
Merged

test: fix failing tests on 4.x LTS branch #7661

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
93fd9e7
fix: repaired CI (#7659) and added spec reporter
FransGH Oct 28, 2021
5709449
added updated package.json + lock
FransGH Oct 28, 2021
d6053b9
reduce timeout
mtrezza Oct 30, 2021
ef055eb
remove unnecessary code
mtrezza Oct 30, 2021
3c3f42d
remove dependency range
mtrezza Oct 30, 2021
30451e2
remove empty line
mtrezza Oct 30, 2021
703dbd4
refactor spec reporter according to alpha
mtrezza Oct 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@
"form-data": "3.0.0",
"husky": "4.2.5",
"jasmine": "3.5.0",
"jasmine-spec-reporter": "^7.0.0",
mtrezza marked this conversation as resolved.
Show resolved Hide resolved
"jsdoc": "3.6.7",
"jsdoc-babel": "0.5.0",
"lint-staged": "10.2.3",
Expand Down
6 changes: 4 additions & 2 deletions spec/ParseLiveQuery.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -949,7 +949,7 @@ describe('ParseLiveQuery', function () {
const response = (obj, prev) => {
expect(obj.get('sessionToken')).toBeUndefined();
expect(obj.sessionToken).toBeUndefined();
expect(prev?.sessionToken).toBeUndefined();
expect(prev && prev.sessionToken).toBeUndefined();
if (prev && prev.get) {
expect(prev.get('sessionToken')).toBeUndefined();
}
Expand All @@ -967,8 +967,10 @@ describe('ParseLiveQuery', function () {
await user.save();
user.set('yolo', 'bar');
await user.save();
user.set('foo', 'bar');
await user.save();
await user.destroy();
await new Promise(resolve => process.nextTick(resolve));
await new Promise(resolve => setTimeout(resolve, 500));
for (const key of events) {
expect(calls[key]).toHaveBeenCalled();
}
Expand Down
10 changes: 8 additions & 2 deletions spec/ParseUser.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3948,7 +3948,7 @@ describe('Parse.User testing', () => {
const response = (obj, prev) => {
expect(obj.get('authData')).toBeUndefined();
expect(obj.authData).toBeUndefined();
expect(prev?.authData).toBeUndefined();
expect(prev && prev.authData).toBeUndefined();
if (prev && prev.get) {
expect(prev.get('authData')).toBeUndefined();
}
Expand All @@ -3967,11 +3967,17 @@ describe('Parse.User testing', () => {
await user.save();
user.set('yolo', 'bar');
await user.save();
user.unset('foo');
await user.save();
await user.destroy();
await new Promise(resolve => process.nextTick(resolve));
await new Promise(resolve => setTimeout(resolve, 500));
for (const key of events) {
expect(calls[key]).toHaveBeenCalled();
}
subscription.unsubscribe();
const client = await Parse.CoreManager.getLiveQueryController().getDefaultLiveQueryClient();
client.close();
await new Promise(resolve => setTimeout(resolve, 500));
});

describe('issue #4897', () => {
Expand Down
12 changes: 12 additions & 0 deletions spec/helper.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,18 @@
// Sets up a Parse API server for testing.
jasmine.DEFAULT_TIMEOUT_INTERVAL = process.env.PARSE_SERVER_TEST_TIMEOUT || 5000;

const SpecReporter = require('jasmine-spec-reporter').SpecReporter;

jasmine.getEnv().clearReporters(); // remove default reporter logs
jasmine.getEnv().addReporter(
new SpecReporter({
// add jasmine-spec-reporter
spec: {
displayPending: true,
},
})
);

global.on_db = (db, callback, elseCallback) => {
if (process.env.PARSE_SERVER_TEST_DB == db) {
return callback();
Expand Down