-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: fix failing tests on 4.x LTS branch #7661
test: fix failing tests on 4.x LTS branch #7661
Conversation
Thanks for opening this pull request!
|
Codecov Report
@@ Coverage Diff @@
## release-4.x.x #7661 +/- ##
================================================
Coverage ? 93.84%
================================================
Files ? 169
Lines ? 12442
Branches ? 0
================================================
Hits ? 11676
Misses ? 766
Partials ? 0 Continue to review full report at Codecov.
|
We may also have to port some of the changes in this fix to |
Wouldn't it make make more sense for alpha to upgrade to jasmine-spec-reporter 7.0.0? |
Thanks for picking this up @FransGH!! |
Sure, if you want to open another PR, please go ahead. We'll merge this PR together with the one for |
Is there an open issue/pr for 4.x release automation? What are the remaining todo's to get that done? |
@FransGH There is no open GitHub issue for this, but you also don't have to worry about it. I am taking care of this in the background, since it's a more complex undertaking. To summarize, 4.x is a LTS branch. We can merge this PR if we make sure that it contains only changes that are also in the |
Since this is just a test fix, there won't be a new release. You would just use the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look good! I have made some minor optimizations to the PR to keep it in-sync with the alpha branch, see commit log. Thanks for your contribution!
|
You did well - we got it merged in the end and that's what counts 😉 |
🎉 This change has been released in version 4.10.5 |
The label |
New Pull Request Checklist
Issue Description
The CI workflows stalled due to broken tests.
Related issue: #7659
Note: this has been ported to
alpha
via #7667Approach
A spec reporter was added helper.js to track completed/failed tests and failed test were repaired.
TODOs before merging