Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix failing tests on 4.x LTS branch #7661

Merged
merged 7 commits into from
Oct 30, 2021

Conversation

FransGH
Copy link
Contributor

@FransGH FransGH commented Oct 28, 2021

New Pull Request Checklist

Issue Description

The CI workflows stalled due to broken tests.
Related issue: #7659
Note: this has been ported to alpha via #7667

Approach

A spec reporter was added helper.js to track completed/failed tests and failed test were repaired.

TODOs before merging

  • A changelog entry is created automatically using the pull request title (do not manually add a changelog entry)

@parse-github-assistant
Copy link

parse-github-assistant bot commented Oct 28, 2021

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

package.json Outdated Show resolved Hide resolved
@mtrezza mtrezza changed the title fix: repaired CI (#7659) and added spec reporter ci: fix failing CI Oct 28, 2021
@codecov
Copy link

codecov bot commented Oct 28, 2021

Codecov Report

❗ No coverage uploaded for pull request base (release-4.x.x@4ac4b7f). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff                @@
##             release-4.x.x    #7661   +/-   ##
================================================
  Coverage                 ?   93.84%           
================================================
  Files                    ?      169           
  Lines                    ?    12442           
  Branches                 ?        0           
================================================
  Hits                     ?    11676           
  Misses                   ?      766           
  Partials                 ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ac4b7f...703dbd4. Read the comment docs.

@mtrezza
Copy link
Member

mtrezza commented Oct 29, 2021

We may also have to port some of the changes in this fix to alpha, if they are not already there - could you check? We want to branches to divert as little as necessary.

@FransGH
Copy link
Contributor Author

FransGH commented Oct 29, 2021

Wouldn't it make make more sense for alpha to upgrade to jasmine-spec-reporter 7.0.0?
Happy to create a PR for that, including checking if the other changes in this PR are in the latest master branch.
I'll look into that next week. For now, it would be great if these two PR's could be merged into 4.x.x and released.

@dblythy
Copy link
Member

dblythy commented Oct 29, 2021

Thanks for picking this up @FransGH!!

@mtrezza
Copy link
Member

mtrezza commented Oct 29, 2021

Wouldn't it make make more sense for alpha to upgrade to jasmine-spec-reporter 7.0.0?

Sure, if you want to open another PR, please go ahead. We'll merge this PR together with the one for alpha to keep the branches in sync. In the meantime we'll look into how to release a 4.x version, which is on a LTS branch that still has to be set-up for auto-release.

@FransGH
Copy link
Contributor Author

FransGH commented Oct 29, 2021

Is there an open issue/pr for 4.x release automation? What are the remaining todo's to get that done?

@mtrezza
Copy link
Member

mtrezza commented Oct 29, 2021

@FransGH There is no open GitHub issue for this, but you also don't have to worry about it. I am taking care of this in the background, since it's a more complex undertaking.

To summarize, 4.x is a LTS branch. We can merge this PR if we make sure that it contains only changes that are also in the alpha branch, except for changes that are specifically needed for the 4.x branch. So if the jasmine reporter is in the alpha branch with different settings or code, we'd need to make sure they are both identical. We'll merge this PR once both PRs are read for merge.

@mtrezza mtrezza changed the title ci: fix failing CI ci: fix failing CI on 4.x LTS branch Oct 29, 2021
FransGH added a commit to FransGH/parse-server that referenced this pull request Oct 29, 2021
@mtrezza mtrezza changed the title ci: fix failing CI on 4.x LTS branch test:: fix failing tests on 4.x LTS branch Oct 30, 2021
@mtrezza mtrezza changed the title test:: fix failing tests on 4.x LTS branch test: fix failing tests on 4.x LTS branch Oct 30, 2021
@mtrezza
Copy link
Member

mtrezza commented Oct 30, 2021

In the meantime we'll look into how to release a 4.x version, which is on a LTS branch that still has to be set-up for auto-release.

Since this is just a test fix, there won't be a new release. You would just use the release-4.x.x branch for development.

Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good! I have made some minor optimizations to the PR to keep it in-sync with the alpha branch, see commit log. Thanks for your contribution!

@mtrezza mtrezza merged commit 065facd into parse-community:release-4.x.x Oct 30, 2021
@FransGH
Copy link
Contributor Author

FransGH commented Oct 30, 2021

Look good! I have made some minor optimizations to the PR to keep it in-sync with the alpha branch, see commit log. Thanks for your contribution!
Happy to be of help. Sorry for my previous holding back for making this simple change, it's just not very compelling making late night changes and not being able to test them as I can't start the ci. But seems that the workflows now run when I make a PR so that's solved too, thanks!

@mtrezza
Copy link
Member

mtrezza commented Oct 30, 2021

You did well - we got it merged in the end and that's what counts 😉

@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 4.10.5

@parseplatformorg parseplatformorg added the state:released-4.x.x Released as LTS version label Feb 12, 2022
@parse-github-assistant
Copy link

The label state:released-4.x.x cannot be used here.

@parse-github-assistant parse-github-assistant bot removed the state:released-4.x.x Released as LTS version label Feb 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants