-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: Improve release build & process instructions #540
Conversation
Co-authored-by: Tarik Gul <47201679+TarikGul@users.noreply.github.com>
Co-authored-by: Tarik Gul <47201679+TarikGul@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Per my comment above i added a bunch of the suggestion's from that previous PR that were put after we merged.
There is one more suggestion to change the version's to vMM-mm-pp
. I think it is a good addition but then could also be confusing.
closes: #534
Co-authored-by: Tarik Gul <47201679+TarikGul@users.noreply.github.com>
Can you expand on that? We already follow semver, so is the suggestion to used |
Yea ofcourse, the suggestion was to replace the use of Sorry the was confusing. Basically just replacing our numbers in all the examples above, and replace them with the semver letters. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I think it was an excellent battle test of the README, letting me doing the previous release.
Maybe increased bundle size was the reason that the 2FA complained (timeout) ^^
Changes:
"files"
key inpackage.json
with just thebuild
folder. There was some regression in bundling where the distribution went from ~9mb => ~90mb. This brings it back down to ~9mb.yarn deploy
to reflect that we do not automate changelong generation and prevent the footgun of forgetting to build right before publishing.