Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

companion for validator self-vote in bags #5088

Merged
merged 5 commits into from
Mar 23, 2022
Merged

companion for validator self-vote in bags #5088

merged 5 commits into from
Mar 23, 2022

Conversation

kianenigma
Copy link
Contributor

@kianenigma kianenigma added A0-please_review Pull request needs code review. B7-runtimenoteworthy B0-silent Changes should not be mentioned in any release notes E0-runtime_migration PR introduces code that might require downstream chains to run a runtime upgrade. labels Mar 11, 2022
@kianenigma kianenigma mentioned this pull request Mar 11, 2022
Merged
@kianenigma kianenigma requested review from ggwpez and emostov March 23, 2022 09:15
@kianenigma
Copy link
Contributor Author

Running migration code:

Polkadot:

2022-03-23 11:13:19.429  INFO main runtime::staking: [9553618] 💸 injected a total of 1056 new voters, prev count: 22194 next count: 23250, updating to version 9

Kusama:

2022-03-23 11:17:54.476  INFO main runtime::staking: [11929693] 💸 injected a total of 2085 new voters, prev count: 7315 next count: 9400, updating to version 9

Westend:

2022-03-23 11:19:38.131  INFO main runtime::staking: [10091318] 💸 injected a total of 1064 new voters, prev count: 63709 next count: 64773, updating to version 9

@kianenigma kianenigma added the D9-needsaudit 👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited. label Mar 23, 2022
@paritytech-processbot
Copy link

Merge cancelled due to error. Error: Checks failed for bc93fa5

@kianenigma kianenigma added C1-low PR touches the given topic and has a low impact on builders. and removed B0-silent Changes should not be mentioned in any release notes labels Mar 23, 2022
@kianenigma
Copy link
Contributor Author

bot merge

@kianenigma kianenigma merged commit b3497fb into master Mar 23, 2022
@kianenigma kianenigma deleted the kiz-comp-validator-in-bags branch March 23, 2022 15:31
@paritytech-processbot
Copy link

Error: Github API says #5088 is not mergeable

ordian added a commit that referenced this pull request Mar 24, 2022
@ordian
Merge branch 'master' into ao-remove-old-migrations
b323434 
* master:
  Try to fix out of view statements (#5177)
  Companion for Substrate#11107 (#5197)
  paras: `include_pvf_check_statement` rt bench (#4938)
  [ci] Run short benchmarks only in PR pipelines (#5200)
  Companion for paritytech/substrate#10242 (#4862)
  [ci] Add short benchmarks to the pipeline (#5188)
  upgrade coarsetime to 0.1.22 to fix a potential panic (#5193)
  Update docs and enable DOT-over-XCM (#4809)
  enable disputes on all chains (#5182)
  companion for validator self-vote in bags (#5088)
  Extract MAX_FINALITY_LAG constant from relay_chain_selection (#5159)
@github-actions github-actions bot mentioned this pull request Apr 20, 2022
Closed
@jakoblell jakoblell added D1-audited 👍 PR contains changes to critical logic that has been properly reviewed and externally audited. and removed D9-needsaudit 👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited. labels Jun 9, 2022
@Dengjianping Dengjianping mentioned this pull request Jul 7, 2022
Merged
10 tasks
@github-actions github-actions bot mentioned this pull request Jul 18, 2022
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@emostov emostov emostov approved these changes

@ggwpez ggwpez ggwpez approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders. D1-audited 👍 PR contains changes to critical logic that has been properly reviewed and externally audited. E0-runtime_migration PR introduces code that might require downstream chains to run a runtime upgrade.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kianenigma @ggwpez @emostov @jakoblell