This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Update docs and enable DOT-over-XCM #4809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KiChjang
reviewed
Jan 31, 2022
| type ExecuteXcmOrigin = xcm_builder::EnsureXcmOrigin<Origin, LocalOriginToLocation>; | ||
| // ...but they must match our filter, which rejects all. | ||
| type XcmExecuteFilter = Nothing; | ||
| type XcmExecuteFilter = Everything; |
There was a problem hiding this comment.
Setting this to Everything means that anyone can call execute on the XCM pallet and provide an arbitrary XCM as an extrinsic to be executed. If we're 100% confident that XCM is good to go at its current form, then there shouldn't be any issues setting it to Everything, but just making sure we're on the same page.
There was a problem hiding this comment.
Ah, I see, this is for Kusama, definitely not a huge problem then.
KiChjang
approved these changes
Jan 31, 2022
rdovgan
approved these changes
Feb 2, 2022
|
This should also activate the polkadot/runtime/polkadot/src/lib.rs Line 1213 in 467544f |
shawntabrizi
approved these changes
Mar 3, 2022
Merged
joepetrowski
approved these changes
Mar 23, 2022
ordian
added a commit
that referenced
this pull request
Mar 24, 2022
* master: Try to fix out of view statements (#5177) Companion for Substrate#11107 (#5197) paras: `include_pvf_check_statement` rt bench (#4938) [ci] Run short benchmarks only in PR pipelines (#5200) Companion for paritytech/substrate#10242 (#4862) [ci] Add short benchmarks to the pipeline (#5188) upgrade coarsetime to 0.1.22 to fix a potential panic (#5193) Update docs and enable DOT-over-XCM (#4809) enable disputes on all chains (#5182) companion for validator self-vote in bags (#5088) Extract MAX_FINALITY_LAG constant from relay_chain_selection (#5159)
16 tasks
10 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few docs were outdated - they have been brought up to date.
This basically just enables the four transactions for doing a reserve asset transfer or teleportation of DOT to a parachain.
It disables sending XCM for now since it's useless without the destination chain supporting
DescendOrigin. Expect for it to be re-enabled along with XCM v3 which will enable support for receiving messages beginning withDescendOrigin.