Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Update parity-multiaddr. #1700

Merged
3 commits merged into from
Sep 14, 2020
Merged

Update parity-multiaddr. #1700

3 commits merged into from
Sep 14, 2020

Conversation

romanb
Copy link
Contributor

@romanb romanb commented Sep 10, 2020 •
edited
Loading

Companion PR for paritytech/substrate#7077.

@romanb romanb added A3-in_progress Pull request is in progress. No review needed at this stage. A1-needsburnin B0-silent Changes should not be mentioned in any release notes labels Sep 10, 2020
@romanb romanb mentioned this pull request Sep 11, 2020
Merged
@romanb romanb requested a review from tomaka September 11, 2020 11:35
@romanb romanb marked this pull request as ready for review September 11, 2020 11:35
@github-actions github-actions bot added A0-please_review Pull request needs code review. and removed A3-in_progress Pull request is in progress. No review needed at this stage. labels Sep 11, 2020
@romanb romanb changed the title [burn-in] Test libp2p upgrade. Bump parity-multiaddr. Sep 11, 2020
@romanb romanb changed the title Bump parity-multiaddr. Update parity-multiaddr. Sep 11, 2020
@romanb romanb added C3-medium PR touches the given topic and has a medium impact on builders. and removed D2-breaksapi labels Sep 11, 2020
@tomaka
Copy link
Contributor

tomaka commented Sep 11, 2020

I don't think the CI of this PR needs to pass, but I'm not sure of that.

@romanb romanb added C1-low PR touches the given topic and has a low impact on builders. and removed C3-medium PR touches the given topic and has a medium impact on builders. labels Sep 11, 2020
@tomaka
Copy link
Contributor

tomaka commented Sep 14, 2020

This PR is quite harmless. The only difference between the two versions of parity-multiaddr is this.
As such, I'm going to merge this PR as an attempt to unblock the corresponding Substrate PR.

@tomaka
Copy link
Contributor

tomaka commented Sep 14, 2020

bot merge

@ghost
Copy link

ghost commented Sep 14, 2020

Trying merge.

@ghost ghost merged commit e9275d5 into master Sep 14, 2020
@ghost ghost deleted the libp2p-0.28 branch September 14, 2020 10:10
ordian added a commit that referenced this pull request Sep 14, 2020
@ordian
Merge branch 'master' into ao-validator-discovery-api
dbbfe23 
* master:
  Companion PR for #6984 (#1661)
  Update some dependencies. (#1718)
  Add a specific memory requirements (#1716)
  Companion PR for #7039: grandpa-rpc dont share subscription manager, only executor (#1687)
  Update bytes. (#1715)
  Add a note about memory requirements (#1714)
  Update parity-multiaddr. (#1700)
  typo in proxy tests (#1713)
  Companion PR for ` Add a `build-sync-spec` subcommand and remove the CHT roots from the light sync state.` (#1670)
  Forwardport: Validation: don't detect STDIN closing when running in process (#1695) (#1703)
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tomaka tomaka tomaka approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@romanb @tomaka @paritytech-ci