This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Companion PR for Add a build-sync-spec subcommand and remove the CHT roots from the light sync state.
#1670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cecton do you think you could quickly review this please? Thanks! |
seunlanlege
reviewed
Sep 11, 2020
| )?; | ||
| let client = Arc::new(client); | ||
|
|
||
| Ok((cmd.run(chain_spec, network_config, client, network_status_sinks), task_manager)) |
There was a problem hiding this comment.
why not just pass the Configuration struct? chain_spec and network_config live on the Configuration object
There was a problem hiding this comment.
The Configuration gets consumed by new_full_nongeneric, so it can't be used.
There was a problem hiding this comment.
I would argue that it should be clone, but that's for another time. This looks solid to me
|
bot merge |
|
Waiting for commit status. |
|
Checks failed; merge aborted. |
|
bot merge |
|
Waiting for commit status. |
|
Checks failed; merge aborted. |
|
bot merge |
|
Waiting for commit status. |
ordian
added a commit
that referenced
this pull request
Sep 14, 2020
* master: Companion PR for #6984 (#1661) Update some dependencies. (#1718) Add a specific memory requirements (#1716) Companion PR for #7039: grandpa-rpc dont share subscription manager, only executor (#1687) Update bytes. (#1715) Add a note about memory requirements (#1714) Update parity-multiaddr. (#1700) typo in proxy tests (#1713) Companion PR for ` Add a `build-sync-spec` subcommand and remove the CHT roots from the light sync state.` (#1670) Forwardport: Validation: don't detect STDIN closing when running in process (#1695) (#1703)
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See paritytech/substrate#6999. Not strictly a companion PR, as the substrate PR doesn't break anything. It would still be nice to get them merged at the same time though.