This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Rewrite client handling #1531
Merged
Rewrite client handling #1531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are supporting muliple polkadot-like chains and all have different client types. This pr reworks the client handling by having all of them in one enum combined. Besides that, there is added a special trait `ExecuteWithClient` to use the internal client.
rphmeier
reviewed
Aug 4, 2020
rphmeier
reviewed
Aug 4, 2020
rphmeier
reviewed
Aug 4, 2020
| pub enum Client { | ||
| Polkadot(Arc<crate::FullClient<polkadot_runtime::RuntimeApi, crate::PolkadotExecutor>>), | ||
| Westend(Arc<crate::FullClient<westend_runtime::RuntimeApi, crate::WestendExecutor>>), | ||
| Kusama(Arc<crate::FullClient<kusama_runtime::RuntimeApi, crate::KusamaExecutor>>), |
There was a problem hiding this comment.
Will you add a Rococo variant here?
There was a problem hiding this comment.
Yeah, the pr was not yet merged :)
rphmeier
reviewed
Aug 4, 2020
| @@ -52,7 +52,7 @@ pub use polkadot_runtime; | |||
| pub use kusama_runtime; | |||
| pub use westend_runtime; | |||
| use prometheus_endpoint::Registry; | |||
| pub use self::client::PolkadotClient; | |||
| pub use self::client::*; | |||
There was a problem hiding this comment.
it would be better to explicitly export. glob re-exports scare me :)
rphmeier
approved these changes
Aug 4, 2020
Co-authored-by: Robert Habermeier <rphmeier@gmail.com>
ordian
added a commit
that referenced
this pull request
Aug 5, 2020
* master: Unalias Substrate Imports (#1530) Rewrite client handling (#1531) Integrate ChainApi with all messages (#1533) Add Rococo test network (#1363) Fix a typo parathreads -> parachains (#1529) Cleanup upcoming paras (#1527) Sudo wrapper for paras (#1517) Implementer's guide: notes on contextual execution (#1525) Companion for substrate/6782 (#1523) Sort out validation errors (#1516)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are supporting muliple polkadot-like chains and all have different
client types. This pr reworks the client handling by having all of them
in one enum combined. Besides that, there is added a special trait
ExecuteWithClientto use the internal client.