Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Unalias Substrate Imports #1530

Merged
25 commits merged into from
Aug 4, 2020
Merged

Unalias Substrate Imports #1530

25 commits merged into from
Aug 4, 2020

Conversation

shawntabrizi
Copy link
Member

This PR updates a bunch of substrate crates to use their original crate name rather than aliases.

For example instead of balances, we now use pallet_balances, just like in Substrate.

@github-actions github-actions bot added the A0-please_review Pull request needs code review. label Aug 3, 2020
@shawntabrizi shawntabrizi added B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Aug 3, 2020
pepyakin
pepyakin reviewed Aug 4, 2020
View reviewed changes
Copy link
Contributor

@pepyakin pepyakin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I am up for this change.

However, I am not completely sure that this renaming is 100% safe: I suspect that there may be a small chance that it alters some name or something. With macros you never know. Therefore I would defer to people who knows better

coriolinus
coriolinus reviewed Aug 4, 2020
View reviewed changes
Copy link
Contributor

@coriolinus coriolinus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same. I very much like this idea in principle but I do not know for sure that it doesn't accidentally change something important.

bkchr
bkchr approved these changes Aug 4, 2020
View reviewed changes
validation/Cargo.toml Outdated Show resolved Hide resolved
@shawntabrizi shawntabrizi removed the A0-please_review Pull request needs code review. label Aug 4, 2020
@shawntabrizi
Copy link
Member Author

bot merge

@ghost
Copy link

ghost commented Aug 4, 2020

Missing process info; check that the PR belongs to a project column.

@shawntabrizi
Copy link
Member Author

bot merge

@ghost
Copy link

ghost commented Aug 4, 2020

Missing approval from the project owner or a minimum of core developers.

@shawntabrizi
Copy link
Member Author

bot merge

@ghost
Copy link

ghost commented Aug 4, 2020

Trying merge.

@ghost ghost merged commit 19b88ff into master Aug 4, 2020
@ghost ghost deleted the shawnabrizi-unalias-crates branch August 4, 2020 13:23
ordian added a commit that referenced this pull request Aug 5, 2020
@ordian
Merge branch 'master' into ao-prometheus-metrics
d0631f7 
* master:
  Unalias Substrate Imports (#1530)
  Rewrite client handling (#1531)
  Integrate ChainApi with all messages (#1533)
  Add Rococo test network (#1363)
  Fix a typo parathreads -> parachains (#1529)
  Cleanup upcoming paras (#1527)
  Sudo wrapper for paras (#1517)
  Implementer's guide: notes on contextual execution (#1525)
  Companion for substrate/6782 (#1523)
  Sort out validation errors (#1516)
This was referenced Aug 5, 2020
Merged
Closed
@JoshOrndorff JoshOrndorff mentioned this pull request Jan 6, 2021
Merged
3 tasks
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@coriolinus coriolinus coriolinus left review comments

@bkchr bkchr bkchr approved these changes

@kianenigma kianenigma kianenigma left review comments

@pepyakin pepyakin pepyakin approved these changes

Assignees
No one assigned
Labels
B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@shawntabrizi @pepyakin @kianenigma @bkchr @coriolinus @paritytech-ci