Add disabling of autoinstall globally via environment variable #2130

cacheflow · 2018-10-14T13:14:29Z

↪️ Pull Request

-Allow disabling of autoinstall via a environment variable named PARCEL_NO_AUTOINSTALL.

✔️ PR Todo

[x ] Added/updated unit tests for this change
Filled out test instructions (In case there aren't any unit tests)
[ x] Included links to related issues/PRs

Feature Request: #2081

Reduces amount of warnings during tests.

* handle empty config && asset files * remove bad empty asset solution

Don’t use “last 2 versions”. See https://jamie.build/last-2-versions

# ↪️ Pull Request  Changed the logic to determine which package manager to use during auto-installation. The only situation Parcel should use yarn is when it satisfies - There is `yarn` command available AND - There is `yarn.lock` file AND - There is NOT `package-lock.json` Otherwise, it uses npm. Fixes #2117 ## 🚨 Test instructions  Setup a testing directory with different setups (package-lock existence, yarn.lock existence, yarn command existence). The only situation Parcel should use yarn is when - There is `yarn` command available AND - There is `yarn.lock` file AND - There is NOT `package-lock.json` ## ✔️ PR Todo ~~- [ ] Added/updated unit tests for this change~~ - [x] Filled out test instructions (In case there aren't any unit tests) - [x] Included links to related issues/PRs  ## Side note There is a situation where there are both package-lock.json and yarn.lock. Having npm as default package manager means that it should use npm in this situation. That's why there is only one situation where Parcel should use yarn.

Very small change, but I noticed how these were calling `this.dest` directly over using the Packager's methods.

mischnic · 2018-10-14T13:44:28Z

Maybe this is a better place for disabling autoinstall:

parcel/src/Bundler.js

Lines 137 to 140 in e86ddf4

    
           autoinstall: 
        
             typeof options.autoinstall === 'boolean' 
        
               ? options.autoinstall 
        
               : !isProduction,

cacheflow · 2018-10-14T18:28:26Z

Agreed @mischnic. Let me do the checking there.

-Allows disabling autoinstall via a environment variable named PARCEL_NO_AUTOINSTALL. -Closes 2081.

devongovett · 2018-10-15T11:46:32Z

Hmm why do we need an environment variable and not just use the cli flag that already exists?

mischnic · 2018-10-15T11:47:59Z

I don't want to add the --no-autoinstall flag to every project of mine and having this flag set implicitly (so not specified in the package.json) doesn't change the build output.

cacheflow · 2018-10-15T16:51:10Z

I'd like the same in my projects @devongovett. 😄

devongovett · 2018-10-15T19:35:25Z

src/Bundler.js

@@ -135,7 +135,8 @@ class Bundler extends EventEmitter {
      detailedReport: options.detailedReport || false,
      global: options.global,
      autoinstall:
-        typeof options.autoinstall === 'boolean'
+        typeof options.autoinstall === 'boolean' &&
+        process.env.PARCEL_NO_AUTOINSTALL !== 'true'


I think it would be better if the options were positive instead of negative, so PARCEL_AUTOINSTALL=false should disable it

That was my original thought. Brb updating.

devongovett · 2018-10-16T03:55:05Z

Due to move to monorepo which rewrote the git history, this PR was automatically closed. Please open a new PR against master with your changes. You can do a diff against the 1.x branch to see them. Sorry about that!

…ent variable -Closes parcel-bundler#2130.

…ment variable -Closes parcel-bundler#2130.

…ent variable -Closes parcel-bundler#2130.

…ment variable -Closes parcel-bundler#2130.

…ent variable -Closes parcel-bundler#2130.

…ment variable -Closes parcel-bundler#2130.

jlfwong and others added 30 commits March 27, 2018 21:10

Fix methods of LazyPromise (#1059)

74438d4

Ignore require if it is defined (#975)

12b649b

Check browserslist prop in package.json for environments (#1053)

39e4f7a

add support for data attr of object element (#1069)

6e8ae0d

Add useBuiltIns babel-preset-env option (fix #843) (#878)

e26d443

Fix builtin loaders with --target=node (#981)

9d6061c

Update changelog

27e1d02

Wait for the next event loop iteration when loading WASM (#1086)

fb47244

Fix test not using the projectBasePath (#1081)

279f043

1.7.0

0140dce

Add support for scoped plugin packages (#1112) (#1117)

9792f48

Fix writing files in subfolders inside dist directory (#1097)

0e1863b

Add “private: true” to package.json files in tests. (#1142)

9038991

Reduces amount of warnings during tests.

Update addBundleLoader to accept multiple targets (#1085)

9f3f30a

Fix sourcemap reference in JS output (#1148)

28b87cf

Sourcemap sourceRoot (#1141)

3b1a585

Fix serving files with query params (#1169)

3435c4c

Give priority to styl files in StylusAsset resolver (#1090)

89952d7

Bump dependencies (#1089) (#1184)

4189563

Fix asset size always be zero when building vue project (#1151)

25a054f

Custom workerfarm, BI-Directional IPC (#1105)

69625e0

1.7.1

1bfba6e

Update changelog

bfc1d3c

Change appveyor badge to master branch (#1197)

bb7f4aa

[Fix] Prevent build from breaking when .scss file is empty (#1193)

7a2ba16

Handle empty config files (#1203)

11a7882

* handle empty config && asset files * remove bad empty asset solution

Update dependency with security vuln (#1246)

06999a0

Minor change to mkHandle in workerfarm (#1233)

0d984a5

Update default engines to > 0.25% (#1238)

e9b249c

Don’t use “last 2 versions”. See https://jamie.build/last-2-versions

use resolver for imports (#1256)

31190cf

3846masa and others added 8 commits October 6, 2018 16:53

Add loaders when bundling workers (#2092)

3b4e37e

Changelog for v1.10.2

66d9d61

1.10.2

c734423

Don't dedupe assets that are depended on in more than one bundle (#2122)

75f4164

Update changelog

1b808ec

1.10.3

a0df886

Use this.write and super.end for JSPackager (#2126)

e86ddf4

Very small change, but I noticed how these were calling `this.dest` directly over using the Packager's methods.

cacheflow mentioned this pull request Oct 14, 2018

Disabling autoinstall globally #2081

Open

Add disabling of autoinstall globally via environment variable

e07473c

-Allows disabling autoinstall via a environment variable named PARCEL_NO_AUTOINSTALL. -Closes 2081.

DeMoorJasper previously approved these changes Oct 15, 2018

View reviewed changes

devongovett requested changes Oct 15, 2018

View reviewed changes

Set autoinstall options via env var to positive instead of negative.

79dbed1

cacheflow dismissed DeMoorJasper’s stale review via 79dbed1 October 15, 2018 19:49

devongovett closed this Oct 16, 2018

devongovett force-pushed the master branch from d2dc7c9 to 75310e1 Compare October 16, 2018 03:52

cacheflow added a commit to cacheflow/parcel that referenced this pull request Oct 16, 2018

feat(autoinstall): Add disabling of autoinstall globally via environm…

b3daf7f

…ent variable -Closes parcel-bundler#2130.

cacheflow added a commit to cacheflow/parcel that referenced this pull request Oct 16, 2018

feat(autoinstall): Add disabling of autoinstall globally via environ…

644170a

…ment variable -Closes parcel-bundler#2130.

cacheflow added a commit to cacheflow/parcel that referenced this pull request Oct 18, 2018

feat(autoinstall): Add disabling of autoinstall globally via environm…

caa6a36

…ent variable -Closes parcel-bundler#2130.

cacheflow added a commit to cacheflow/parcel that referenced this pull request Oct 18, 2018

feat(autoinstall): Add disabling of autoinstall globally via environ…

10cfca9

…ment variable -Closes parcel-bundler#2130.

cacheflow added a commit to cacheflow/parcel that referenced this pull request Oct 23, 2018

feat(autoinstall): Add disabling of autoinstall globally via environm…

4025729

…ent variable -Closes parcel-bundler#2130.

cacheflow added a commit to cacheflow/parcel that referenced this pull request Oct 23, 2018

feat(autoinstall): Add disabling of autoinstall globally via environm…

856764c

…ent variable -Closes parcel-bundler#2130.

cacheflow added a commit to cacheflow/parcel that referenced this pull request Oct 30, 2018

feat(autoinstall): Add disabling of autoinstall globally via environ…

47b998f

…ment variable -Closes parcel-bundler#2130.

devongovett pushed a commit to cacheflow/parcel that referenced this pull request Mar 6, 2019

feat(autoinstall): Add disabling of autoinstall globally via environ…

ddb8234

…ment variable -Closes parcel-bundler#2130.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add disabling of autoinstall globally via environment variable #2130

Add disabling of autoinstall globally via environment variable #2130

cacheflow commented Oct 14, 2018 •

edited

Loading

mischnic commented Oct 14, 2018

cacheflow commented Oct 14, 2018 •

edited

Loading

devongovett commented Oct 15, 2018

mischnic commented Oct 15, 2018

cacheflow commented Oct 15, 2018 •

edited

Loading

devongovett Oct 15, 2018

cacheflow Oct 15, 2018

devongovett commented Oct 16, 2018

Add disabling of autoinstall globally via environment variable #2130

Add disabling of autoinstall globally via environment variable #2130

Conversation

cacheflow commented Oct 14, 2018 • edited Loading

↪️ Pull Request

✔️ PR Todo

mischnic commented Oct 14, 2018

cacheflow commented Oct 14, 2018 • edited Loading

devongovett commented Oct 15, 2018

mischnic commented Oct 15, 2018

cacheflow commented Oct 15, 2018 • edited Loading

devongovett Oct 15, 2018

Choose a reason for hiding this comment

cacheflow Oct 15, 2018

Choose a reason for hiding this comment

devongovett commented Oct 16, 2018

cacheflow commented Oct 14, 2018 •

edited

Loading

cacheflow commented Oct 14, 2018 •

edited

Loading

cacheflow commented Oct 15, 2018 •

edited

Loading