Fix writing files in subfolders inside dist directory #1097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added tests for pug - Added config files support (.pugrc, .pugrc.js, pug.config.js) - Added custom filters support (must be declared in config file in section 'filters')
|
Sorry for trash commits, merging upstream gives me conflicts 😖 |
DeMoorJasper
approved these changes
Mar 29, 2018
fathyb
reviewed
Mar 29, 2018
src/packagers/RawPackager.js
Outdated
| @@ -12,6 +13,12 @@ class RawPackager extends Packager { | |||
| contents = await fs.readFile(contents ? contents.path : asset.name); | |||
| } | |||
|
|
|||
| // Create output path if not exist | |||
| const dir = path.dirname(this.bundle.name); | |||
| if (!await fs.exists(dir)) { | |||
There was a problem hiding this comment.
I think you can directly do fs.mkdirp, mkdirp will internally check if the directory exists. It will save a few I/O calls
There was a problem hiding this comment.
Thanks, I'll fix that ASAP
fathyb
approved these changes
Mar 29, 2018
devongovett
reviewed
Mar 29, 2018
yarn.lock
Outdated
| @@ -6628,6 +6628,8 @@ void-elements@^2.0.1: | |||
| version "2.0.1" | |||
| resolved "https://registry.yarnpkg.com/void-elements/-/void-elements-2.0.1.tgz#c066afb582bb1cb4128d60ea92392e94d5e9dbec" | |||
|
|
|||
| <<<<<<< HEAD | |||
There was a problem hiding this comment.
@devongovett my bad :(
devongovett
approved these changes
Apr 4, 2018
|
Updated slightly to ignore the |
devongovett
pushed a commit
that referenced
this pull request
Oct 15, 2018
devongovett
pushed a commit
that referenced
this pull request
Oct 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1096. If static files placed in subfolders, parcel throws error in
fs.writeFilebecause those subfolders doesn't created inside dist.