feat: add SealedBlock in reth-primitives-traits #13735
Merged
+3,231
−2,866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ck-in-reth-primitives-traits
mattsse
commented
Jan 11, 2025
Comment on lines
+804
to
806
| pub block: Arc<SealedBlock<N::Block>>, | ||
| /// Block's senders. | ||
| pub senders: Arc<Vec<Address>>, |
There was a problem hiding this comment.
this can be simplified in a next step
216ac40 to
2fe6d51
Compare
This was referenced Jan 11, 2025
klkvr
approved these changes
Jan 13, 2025
| hash: BlockHash, | ||
| /// Block hash | ||
| #[cfg_attr(feature = "serde", serde(skip))] | ||
| hash: OnceLock<BlockHash>, |
There was a problem hiding this comment.
could this type completely replace Header usage eventually? given that we now have OnceLock here
There was a problem hiding this comment.
yeah I think so
I'm hesitant to integrate this into the actual header object because for this type we want all fields pub but I don't want to expose this lock as pub.
imo this helper type isn't too bad
There was a problem hiding this comment.
yeah I don't think we should add it to actual alloy header, just using SealedHeader as NodePrimitives::Header and avoiding additional conversions where possible
This was referenced Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #13626
closes #13747
This unifies
BlockWithSendersandSealedBlockWithSendersintoRecoveredBlockadds various constructors and conversion between
SealedBlock <-> RecoveredBlockChanges overview
BlockWithSendersandSealedBlockWithSendersintoRecoveredBlockSealedBlockgeneric overB: Block, but keep the header,body fieldsSealedHeaderI've kept the aliases but these are now marked as deprecated