Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace senders and block with Recovered block #13796

Closed
mattsse opened this issue Jan 14, 2025 · 5 comments · Fixed by #13804
Closed

Replace senders and block with Recovered block #13796

mattsse opened this issue Jan 14, 2025 · 5 comments · Fixed by #13804
Labels
A-sdk Related to reth's use as a library C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started

Comments

@mattsse
Copy link
Collaborator

mattsse commented Jan 14, 2025

Describe the feature

blocked by #13735

after #13735 we can simplify this with the RecoveredBlock type.

reth/crates/chain-state/src/in_memory.rs

Lines 805 to 808 in df00877

/// Sealed block the rest of fields refer to.
pub block: Arc<SealedBlockFor<N::Block>>,
/// Block's senders.
pub senders: Arc<Vec<Address>>,

TODO

  • combine both fields into RecoveredBlock

Additional context

No response
@mattsse mattsse added A-sdk Related to reth's use as a library C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started labels Jan 14, 2025
@programskillforverification
Copy link
Contributor

I'd like to work on this.

@mattsse
Copy link
Collaborator Author

mattsse commented Jan 15, 2025

hi @programskillforverification

that'd be great, this has somewhat high priority because this will unblock more things.
lmk if you want to work on this right away

@voidash
Copy link
Contributor

voidash commented Jan 15, 2025

Hey i can work on this right away

@voidash voidash mentioned this issue Jan 15, 2025
Merged
Closed
@programskillforverification
Copy link
Contributor

Hey i can work on this right away

Sorry, guys. I just concentrate on working this right away and didn't find your comment. Now we do the same work.

@zachwood222
Copy link

Is this issue still available?

@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-sdk Related to reth's use as a library C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started
Projects
Reth Tracker
Archived in project
Milestone
No milestone
4 participants
@mattsse @voidash @zachwood222 @programskillforverification