Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin the nightly version to latest #10905

Closed
wants to merge 7 commits into from
Closed

Pin the nightly version to latest #10905

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a3bb9e3
Fix: Allow missing docs for test modules
Abhishekkochar Sep 13, 2024
8fb0278
Pin the Nighlty version to 2024-09-10
Abhishekkochar Sep 14, 2024
3c17ac3
Refractor to suggested comments
Abhishekkochar Sep 14, 2024
e9f2665
Merge branch 'main' into ak/clippy-ci
mattsse Sep 14, 2024
4e9fb26
expect missing docs
mattsse Sep 14, 2024
b68da1f
Added #[allow(missing_docs)] to remaining test modules to bypass docu…
Abhishekkochar Sep 15, 2024
d4e6744
Added documents exceptions to remaining test_utils files
Abhishekkochar Sep 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/lint.yml
View file
Open in desktop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you revert everything but this file to main? then we can merge this. other conflicts have been fixed in smaller prs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be easier to open a new PR given several commits and conflicts.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ye, probably right, this lint issue was a big pain for everyone, so had to push it through asap in many prs with smaller scope (easier to review/merge conflicts don't accumulate), thanks nonetheless

Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ jobs:
- uses: actions/checkout@v4
- uses: dtolnay/rust-toolchain@nightly
with:
toolchain: nightly-2024-09-09
toolchain: nightly
components: clippy
- uses: Swatinem/rust-cache@v2
with:
Expand Down
2 changes: 1 addition & 1 deletion crates/metrics/metrics-derive/tests/metrics.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#![allow(missing_docs)]
#![expect(missing_docs)]
use metrics::{
Counter, Gauge, Histogram, Key, KeyName, Label, Metadata, Recorder, SharedString, Unit,
};
Expand Down
Loading