Pin the nightly version to latest #10905
Conversation
| @@ -1,3 +1,4 @@ | |||
| #![allow(missing_docs)] | |||
There was a problem hiding this comment.
can we change this to #![expect(missing_docs)] so we get a failure when we need to remove these? (ie its fixed upstream)
There was a problem hiding this comment.
We can. Although, this will trigger a warning.
There was a problem hiding this comment.
This behaviour is on by default.
|
we still have a ton of clippy things to fix |
…mentation warnings Signed-off-by: Abhishekkochar <abhishekkochar2@gmail.com>
Running this locally doesn't reproduce these errors. I have added these all needed tests expect test_utils. If clippy action fails because of this. I will add to them accordingly. |
Signed-off-by: Abhishekkochar <abhishekkochar2@gmail.com>
|
@mattsse, there are around 300 instance of |
There was a problem hiding this comment.
could you revert everything but this file to main? then we can merge this. other conflicts have been fixed in smaller prs.
There was a problem hiding this comment.
It might be easier to open a new PR given several commits and conflicts.
There was a problem hiding this comment.
ye, probably right, this lint issue was a big pain for everyone, so had to push it through asap in many prs with smaller scope (easier to review/merge conflicts don't accumulate), thanks nonetheless
|
closing in favour of #11062 |
Follow up on PR #10893