Extend deprecation of [export].py_hermetic_scripts to 2.26 #21415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This
py_hermetic_scriptsoption was deprecated in #21181 in favour of the newpy_non_hermetic_scripts_in_resolveoption. This was merged for 2.23.0.dev6 and thus will come in 2.23.0 soon-ish...It seems to be very little code to support
py_hermetic_scripts(just a single extra clause in anifstatement, plus the option definition itself), so it seems unnecessarily aggressive to deprecate in one cycle. This extends it a few releases to make it easier for users to test pre-releases.For instance, someone using 2.22.0 (current stable) with
py_hermetic_scriptscan currently test 2.23.0a0 with just a warning (e.g. adjustpants_versionand run it through their CI), but would be blocked from doing any testing of 2.24.0.dev0 (#21412) until they fix this option. That is, by removing the option quickly, it's harder for them to validate any part of the 2.24 or 2.25 release series and provide us feedback while on older versions.(We're being more permissive than what we were previosuly communicating, so I don't think we need release notes or to otherwise highlight it.)