deprecate --export-py-hermetic-scripts in favor of new --export-py-non-hermetic-scripts-in-resolve option
#21181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cognifloyd
approved these changes
Jul 18, 2024
|
Should this be |
Ah didn't know that category existed when I selected. Will switch it. |
--export-py-hermetic-scripts to --export-py-non-hermetic-scripts-in-resolve--export-py-hermetic-scripts in favor of new --export-py-non-hermetic-scripts-in-resolve option
huonw
added a commit
that referenced
this pull request
Sep 16, 2024
This `py_hermetic_scripts` option was deprecated in #21181 in favour of the new `py_non_hermetic_scripts_in_resolve` option. This was merged for 2.23.0.dev6 and thus will come in 2.23.0 soon-ish... It seems to be very little code to support `py_hermetic_scripts` (just a single extra clause in an `if` statement, plus the option definition itself), so it seems unnecessarily aggressive to deprecate in one cycle. This extends it a few releases to make it easier for users to test pre-releases. For instance, someone using 2.22.0 (current stable) with `py_hermetic_scripts` can currently test 2.23.0a0 with just a warning (e.g. adjust `pants_version` and run it through their CI), but would be blocked from doing _any_ testing of 2.24.0.dev0 (#21412) until they fix this option. That is, by removing the option quickly, it's harder for them to validate any part of the 2.24 or 2.25 release series and provide us feedback while on older versions. (We're being more permissive than what we were previosuly communicating, so I don't think we need release notes or to otherwise highlight it.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecate the
--export-py-hermetic-scriptsoption in favor of the new--export-py-non-hermetic-scripts-in-resolveoption so that the hermetic script logic can be configured on a per-resolve basis. The behavior for the new option is inverted in a sense from the old option since if we named the option--export-py-hermetic-scripts-in-resolvethen the default option value of an empty list would mean that resolve did not use hermetic scripts by default. Thus, the new option acts instead as an opt-in to use non-hermetic scripts.