Increase test timeouts (Cherry pick of #18627, #18712, #18847, #18857) #18859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This bumps up the timeouts of several tests that are regularly causing spurious failures: 1. `src/python/pants/init/load_backends_integration_test.py` 2. `src/python/pants/base/specs_integration_test.py` 3. `src/python/pants/backend/python/goals/coverage_py_integration_test.py` The most common of these is 1, especially for cherry-picks to 2.16. For instance, pantsbuild#18832 required 8 re-attempts, pantsbuild#18839 required 5 and pantsbuild#18850 got to 13. Given these seem to affect 2.16 cherry-picks so much, I'm thinking it makes sense to cherry pick this back to that branch too, along with the increase in pantsbuild#18847, and part of pantsbuild#18627 (the increase to `src/python/pants/engine/streaming_workunit_handler_integration_test.py`).
benjyw
approved these changes
Apr 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cherry-picks a bunch of test timeout increases from main to 2.16.x, to reduce the number of spurious re-attempts required for other cherry-picks.
Fully cherry-picked: #18847, #18857
Partially cherry-picked (just the timeout increases): #18627, #18712.
Motivation: when cherry-picking, #18832 required 8 re-attempts, #18839 required 5 and #18850 got to 13, almost all due to tests timing out. Various other cherry-picks likely required many re-attempts too.