Switch many tests to use PythonRuleRunner. #18712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a step towards getting rid of the IC-setting hack introduced in pantsbuild#18627.
9359526 to
d30b6a4
Compare
kaos
approved these changes
Apr 11, 2023
|
By turning off the hack and seeing which tests fail. |
huonw
added a commit
to huonw/pants
that referenced
this pull request
Apr 30, 2023
huonw
added a commit
that referenced
this pull request
Apr 30, 2023
#18859) This cherry-picks a bunch of test timeout increases from main to 2.16.x, to reduce the number of spurious re-attempts required for other cherry-picks. Fully cherry-picked: #18847, #18857 Partially cherry-picked (just the timeout increases): #18627, #18712. Motivation: when cherry-picking, #18832 required 8 re-attempts, #18839 required 5 and #18850 got to 13, almost all due to tests timing out. Various other cherry-picks likely required many re-attempts too. --------- Co-authored-by: Asher Foa <asher@toolchain.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a step towards getting rid of the IC-setting hack introduced in #18627.
This is a very mechanical change that replaced uses of RuleRunner with
PythonRuleRunner. There is also one change to a test timeout.
This is not exhaustive - there are other tests that will need similar treatment
before we can rid of the hack.