Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More attempts to get CI to be less flaky #18652

Closed
wants to merge 6 commits into from
Closed

More attempts to get CI to be less flaky #18652

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
cc6b134
Try to make the pantsd integration test more likely to pass in CI.
benjyw Apr 1, 2023
3b90a21
Fix race condition in tailor test
benjyw Apr 2, 2023
414bb9a
Bump shutdown timeout
benjyw Apr 2, 2023
898c216
Merge branch 'main' into bump_a_test_timing
benjyw Apr 2, 2023
f12c805
Add temporary logging to see if that's useful
benjyw Apr 2, 2023
cc071d3
SSH into container to debug
benjyw Apr 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/python/pants/backend/go/util_rules/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,6 @@ python_tests(
timeout=120,
overrides={
"embed_integration_test.py": {"timeout": 240},
"cgo_test.py": {"timeout": 240},
},
)
4 changes: 2 additions & 2 deletions tests/python/pants_test/pantsd/pantsd_integration_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,7 +355,7 @@ def test_pantsd_invalidation_file_tracking(self):
ctx.checker.assert_started()

# See comment in `test_pantsd_invalidation_pants_toml_file`.
time.sleep(15)
time.sleep(30)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a recent attempt at bumping these, without luck.

It might be a good idea to assign me a ticket to more deeply investigate these, and then skip them for now.

ctx.checker.assert_running()

def full_pants_log():
Expand Down Expand Up @@ -384,7 +384,7 @@ def test_pantsd_invalidation_pants_toml_file(self):
# This accounts for the amount of time it takes for the SchedulerService to begin watching
# these files. That happens asynchronously after `pantsd` startup, and may take a long
# time in a heavily loaded test environment.
time.sleep(15)
time.sleep(30)

# Delete tmp_pants_toml
os.unlink(tmp_pants_toml)
Expand Down