More attempts to get CI to be less flaky #18652
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Harrumph, this test failure is not at all clear to me: https://github.com/pantsbuild/pants/actions/runs/4585391355/jobs/8097532089?pr=18652 @stuhood could this be a byproduct of #18632? Or something it should have fixed but didn't? |
Eric-Arellano
approved these changes
Apr 1, 2023
kaos
approved these changes
Apr 2, 2023
Eric-Arellano
approved these changes
Apr 2, 2023
5b4b5f8 to
3b90a21
Compare
f8d6c7b to
b3774de
Compare
b3774de to
f12c805
Compare
kaos
approved these changes
Apr 3, 2023
stuhood
reviewed
Apr 3, 2023
Comment on lines
+431
to
437
| # Ensure the test invocation of Pants doesn't restart itself after it writes the tailored files, | ||
| # and then chokes on the invalid BUILD symbol. | ||
| result = rule_runner.run_goal_rule( | ||
| TailorGoal, args=["--alias-mapping={'fortran_library': 'my_fortran_lib'}", "::"] | ||
| TailorGoal, | ||
| global_args=["--no-watch-filesystem", "--no-pantsd"], | ||
| args=["--tailor-alias-mapping={'fortran_library': 'my_fortran_lib'}", "::"], | ||
| ) |
There was a problem hiding this comment.
This is not an integration test, so no external processes or pantsd are spawned: everything runs in process, and file invalidation happens synchronously during the write_files call. So these arguments have no effect.
| @@ -355,7 +355,7 @@ def test_pantsd_invalidation_file_tracking(self): | |||
| ctx.checker.assert_started() | |||
|
|
|||
| # See comment in `test_pantsd_invalidation_pants_toml_file`. | |||
| time.sleep(15) | |||
| time.sleep(30) | |||
There was a problem hiding this comment.
I made a recent attempt at bumping these, without luck.
It might be a good idea to assign me a ticket to more deeply investigate these, and then skip them for now.
cf0b9dc to
cc071d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on tests that still fail in a loaded CI environment, even after #18556