[internal] note dependency to scie-pants on "testing" env vars.
#18170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsirois
approved these changes
Feb 4, 2023
Merged
illicitonion
added a commit
that referenced
this pull request
Feb 17, 2023
Internal changes: * go: fix go vet test flakiness ([#18296](#18296) * Add default gha 1000:1000 user to GHA images. ([#18281](#18281)) * Don't specify interpreter_constraints when building the release pex. ([#18280](#18280)) * go: update pass-through `go test` options for Go v1.20 ([#18229](#18229)) * Fix release for /tmp on a seperate filesystem. ([#18272](#18272)) * upgrade to Rust v1.67.1 ([#18269](#18269)) * Prepare the 2.15.0rc6 release. ([#18263](#18263)) * Allow lambdas for `Field` and `Target` help ([#18248](#18248)) * Revert "Avoid bind-mounts for docker environments on macOS (#18225)" ([#18247](#18247)) * Refactors `experimental_shell_command`-related files to better separate concerns ([#18223](#18223)) * Prepare the 2.15.0rc5 release. ([#18224](#18224)) * Give dedicated threads names ([#18214](#18214)) * Prepare 2.15.0rc4. ([#18196](#18196)) * Remove the `boot_script` from `experimental_shell_command`/`experimental_run_in_sandbox` ([#18168](#18168)) * Adjusts `BinaryShims` to use native digest operations and `immutable_input_digests` ([#18184](#18184)) * go: update build tags check from latest go sources ([#18176](#18176)) * [internal] note dependency to `scie-pants` on "testing" env vars. ([#18170](#18170)) * go: allow coverage for standard library packages ([#18171](#18171)) * Support using `scie-pants` for Pants dev work. ([#18158](#18158)) * Prepare the 2.15.0rc3 release ([#18156](#18156)) * Splits up `shell_command.py` ([#18147](#18147))
seve-martinez
pushed a commit
to seve-martinez/pants
that referenced
this pull request
Feb 20, 2023
Internal changes: * go: fix go vet test flakiness ([pantsbuild#18296](pantsbuild#18296) * Add default gha 1000:1000 user to GHA images. ([pantsbuild#18281](pantsbuild#18281)) * Don't specify interpreter_constraints when building the release pex. ([pantsbuild#18280](pantsbuild#18280)) * go: update pass-through `go test` options for Go v1.20 ([pantsbuild#18229](pantsbuild#18229)) * Fix release for /tmp on a seperate filesystem. ([pantsbuild#18272](pantsbuild#18272)) * upgrade to Rust v1.67.1 ([pantsbuild#18269](pantsbuild#18269)) * Prepare the 2.15.0rc6 release. ([pantsbuild#18263](pantsbuild#18263)) * Allow lambdas for `Field` and `Target` help ([pantsbuild#18248](pantsbuild#18248)) * Revert "Avoid bind-mounts for docker environments on macOS (pantsbuild#18225)" ([pantsbuild#18247](pantsbuild#18247)) * Refactors `experimental_shell_command`-related files to better separate concerns ([pantsbuild#18223](pantsbuild#18223)) * Prepare the 2.15.0rc5 release. ([pantsbuild#18224](pantsbuild#18224)) * Give dedicated threads names ([pantsbuild#18214](pantsbuild#18214)) * Prepare 2.15.0rc4. ([pantsbuild#18196](pantsbuild#18196)) * Remove the `boot_script` from `experimental_shell_command`/`experimental_run_in_sandbox` ([pantsbuild#18168](pantsbuild#18168)) * Adjusts `BinaryShims` to use native digest operations and `immutable_input_digests` ([pantsbuild#18184](pantsbuild#18184)) * go: update build tags check from latest go sources ([pantsbuild#18176](pantsbuild#18176)) * [internal] note dependency to `scie-pants` on "testing" env vars. ([pantsbuild#18170](pantsbuild#18170)) * go: allow coverage for standard library packages ([pantsbuild#18171](pantsbuild#18171)) * Support using `scie-pants` for Pants dev work. ([pantsbuild#18158](pantsbuild#18158)) * Prepare the 2.15.0rc3 release ([pantsbuild#18156](pantsbuild#18156)) * Splits up `shell_command.py` ([pantsbuild#18147](pantsbuild#18147))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a note to a couple env vars that is relied upon by
scie-pantsfor bootstrapping purposes, as they must now be preserved in order to not break this functionality.