Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set _PANTS_OVERRIDE_VERSION when delegate_bootstrap has been overridden. #100

Merged
merged 2 commits into from
Feb 4, 2023

Conversation

kaos
Copy link
Member

@kaos kaos commented Feb 3, 2023

Special case when running in the Pants source repo and delegate_bootstrap is enabled--when a specific version of Pants is requested (either via pants_version in the pants.toml file or using env vars PANTS_VERSION or PANTS_SHA) bootstrap using that version of Pants rather than delegating to ./pants.

Closes #98

@kaos kaos requested a review from jsirois February 3, 2023 22:42
Copy link
Contributor

@jsirois jsirois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thank you.

src/main.rs Show resolved Hide resolved
@jsirois
Copy link
Contributor

jsirois commented Feb 3, 2023

@kaos if you want to try your hand at a release prep / release I'll let you do so; otherwise I'm happy to pick that up presently.

@kaos
Copy link
Member Author

kaos commented Feb 3, 2023

@kaos if you want to try your hand at a release prep / release I'll let you do so; otherwise I'm happy to pick that up presently.

Would be happy to; guessing it is rather straight forward. Today however I'll let you run with it, as it's our anniversary and planning on going out for dinner (16 years married to my wife today 🎉 time flies)

@kaos
Copy link
Member Author

kaos commented Feb 3, 2023

hmm... is it a flaky test to look for the scheduler init string? 😬

package/src/main.rs Outdated Show resolved Hide resolved
@jsirois
Copy link
Contributor

jsirois commented Feb 3, 2023

Aha, congratulations! Yeah, I'll hold off on release since there are issues anyhow.

@kaos
Copy link
Member Author

kaos commented Feb 4, 2023

I've put the test lines in a block for readability on a few of the tests to try it out. If you agree with it, I can go over and apply that to all the integration tests. For me, it made it more readable where the different tests started/ended. (also hoping to reduce local variable pollution between tests, although some of the tests rely on it, so those would likely be left outside such a block in that case)

@kaos kaos requested a review from jsirois February 4, 2023 13:24
package/src/main.rs Show resolved Hide resolved
@kaos kaos merged commit 3b124df into pantsbuild:main Feb 4, 2023
@kaos kaos deleted the pants_override_version branch February 4, 2023 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set _PANTS_OVERRIDE_VERSION when punting the delegate_bootstrap
2 participants