-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set _PANTS_OVERRIDE_VERSION
when delegate_bootstrap has been overridden.
#100
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent, thank you.
@kaos if you want to try your hand at a release prep / release I'll let you do so; otherwise I'm happy to pick that up presently. |
Would be happy to; guessing it is rather straight forward. Today however I'll let you run with it, as it's our anniversary and planning on going out for dinner (16 years married to my wife today 🎉 time flies) |
hmm... is it a flaky test to look for the scheduler init string? 😬 |
Aha, congratulations! Yeah, I'll hold off on release since there are issues anyhow. |
I've put the test lines in a block for readability on a few of the tests to try it out. If you agree with it, I can go over and apply that to all the integration tests. For me, it made it more readable where the different tests started/ended. (also hoping to reduce local variable pollution between tests, although some of the tests rely on it, so those would likely be left outside such a block in that case) |
Special case when running in the Pants source repo and
delegate_bootstrap
is enabled--when a specific version of Pants is requested (either viapants_version
in thepants.toml
file or using env varsPANTS_VERSION
orPANTS_SHA
) bootstrap using that version of Pants rather than delegating to./pants
.Closes #98