Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch deps to Conda #45641

Merged
merged 2 commits into from
Feb 6, 2022
Merged

Switch deps to Conda #45641

merged 2 commits into from
Feb 6, 2022

Conversation

jonashaag
Copy link
Contributor

  • closes #xxxx
  • tests added / passed
  • Ensure all linting tests pass, see here for how to run them
  • whatsnew entry

@attack68
Copy link
Contributor

is there any discussion on this proposal and wider implications?

@jonashaag
Copy link
Contributor Author

It’s a follow up to #44817

@jonashaag jonashaag marked this pull request as ready for review January 27, 2022 20:00
@mroeschke mroeschke added Code Style Code style, linting, code_checks Dependencies Required and optional dependencies labels Jan 30, 2022
mroeschke
mroeschke reviewed Jan 30, 2022
View reviewed changes
Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Could you merge main one more time?

@jonashaag jonashaag mentioned this pull request Feb 1, 2022
Merged
@mroeschke mroeschke added this to the 1.4.1 milestone Feb 6, 2022
@mroeschke mroeschke merged commit a63db3d into pandas-dev:main Feb 6, 2022
@mroeschke
Copy link
Member

Thanks @jonashaag

@mroeschke
Copy link
Member

@meeseeksdev backport 1.4.x

meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Feb 6, 2022
@jonashaag @meeseeksmachine
Backport PR pandas-dev#45641: Switch deps to Conda
a4f0ca1
@meeseeksmachine meeseeksmachine mentioned this pull request Feb 6, 2022
Merged
@lumberbot-app
Copy link

lumberbot-app bot commented Feb 6, 2022

Something went wrong ... Please have a look at my logs.

simonjayhawkins pushed a commit that referenced this pull request Feb 7, 2022
@meeseeksmachine @jonashaag
Backport PR #45641: Switch deps to Conda (#45851)
14b96ff 
Co-authored-by: Jonas Haag <jonas@lophus.org>
phofl pushed a commit to phofl/pandas that referenced this pull request Feb 14, 2022
@jonashaag @phofl
Remove dependencies to Conda (pandas-dev#45641)
154bad0
yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
@jonashaag @yehoshuadimarsky
Remove dependencies to Conda (pandas-dev#45641)
fa89997
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke left review comments

@lithomas1 lithomas1 lithomas1 approved these changes

Assignees
No one assigned
Labels
Code Style Code style, linting, code_checks Dependencies Required and optional dependencies
Projects
None yet
Milestone
1.4.1
Development

Successfully merging this pull request may close these issues.
4 participants
@jonashaag @attack68 @mroeschke @lithomas1