Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Install more packages from conda-forge #44817

Merged
merged 2 commits into from
Dec 22, 2021
Merged

CI: Install more packages from conda-forge #44817

merged 2 commits into from
Dec 22, 2021
+21 −33

Conversation

jonashaag
Copy link
Contributor

  • closes #xxxx
  • tests added / passed
  • Ensure all linting tests pass, see here for how to run them
  • whatsnew entry

Let's see how this goes. Not sure if any of those pip installs are there on purpose or just because at the time of writing no conda-forge package was available.

@jonashaag
Copy link
Contributor Author

Test failures seem to be unrelated?

jreback
jreback requested changes Dec 8, 2021
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since CI is currently red will need a clean run

@jreback jreback added CI Continuous Integration Testing pandas testing functions or related to the test suite labels Dec 8, 2021
jonashaag
jonashaag commented Dec 8, 2021
View reviewed changes
jreback
jreback requested changes Dec 19, 2021
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jonashaag can you make these changes and merge master

@jonashaag
Copy link
Contributor Author

Oops I undid my Zstandard removal with the rebase. Will rebase and fix

@jonashaag jonashaag force-pushed the unpip branch 4 times, most recently from bf560fa to f073510 Compare December 21, 2021 18:01
@jreback jreback added this to the 1.4 milestone Dec 22, 2021
@jreback jreback merged commit dd018ac into pandas-dev:master Dec 22, 2021
@jreback
Copy link
Contributor

jreback commented Dec 22, 2021

thanks @jonashaag

@jonashaag jonashaag mentioned this pull request Jan 27, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

@lithomas1 lithomas1 lithomas1 approved these changes

Assignees
No one assigned
Labels
CI Continuous Integration Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.
3 participants
@jonashaag @jreback @lithomas1