Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STYLE: Inconsistent namespace - scalar #39992 #40218

Merged
merged 2 commits into from
Mar 4, 2021
Merged

STYLE: Inconsistent namespace - scalar #39992 #40218

merged 2 commits into from
Mar 4, 2021

Conversation

thomasyu888
Copy link
Contributor

  • closes #xxxx
  • tests added / passed
  • Ensure all linting tests pass, see here for how to run them
  • whatsnew entry

@thomasyu888
Copy link
Contributor Author

Linking: #39992

@thomasyu888 thomasyu888 changed the title STYLE: Inconsistent namespace - scalar (pandas-dev#39992) STYLE: Inconsistent namespace - scalar #39992 Mar 4, 2021
@gfyoung gfyoung added the Code Style Code style, linting, code_checks label Mar 4, 2021
@MarcoGorelli
Copy link
Member

Thanks @thomasyu888 for doing these - let's leave the rest for other new contributors, but there's plenty of other issues to work on

@MarcoGorelli MarcoGorelli merged commit 74a6898 into pandas-dev:master Mar 4, 2021
@MarcoGorelli MarcoGorelli added this to the 1.3 milestone Mar 4, 2021
@thomasyu888
Copy link
Contributor Author

Thanks @MarcoGorelli! Excited to contribute more as I use this package quite often - sorry if I did too many!

@thomasyu888 thomasyu888 deleted the scalar-style branch March 4, 2021 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Code Style Code style, linting, code_checks
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.
3 participants
@thomasyu888 @MarcoGorelli @gfyoung