Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: Adding test to concat where copy=False for ExtensionArrays #30625

Merged
merged 3 commits into from
Jan 4, 2020
Merged

TST: Adding test to concat where copy=False for ExtensionArrays #30625

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7d0fac9
TST: Adding test to concat where copy=False for ExtensionArrays
dwhu Jan 2, 2020
89311ab
TST: Moving test from test_concat.py to reshaping.py
dwhu Jan 2, 2020
95bfa50
TST: Moving test concat on copy=False for EA to own test.
dwhu Jan 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions pandas/tests/extension/base/reshaping.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,19 @@ def test_concat_columns(self, data, na_value):
result = pd.concat([df1["A"], df2["B"]], axis=1)
self.assert_frame_equal(result, expected)

def test_concat_extension_arrays_copy_false(self, data, na_value):
# GH 20756
df1 = pd.DataFrame({"A": data[:3]})
df2 = pd.DataFrame({"B": data[3:7]})
expected = pd.DataFrame(
{
"A": data._from_sequence(list(data[:3]) + [na_value], dtype=data.dtype),
"B": data[3:7],
}
)
result = pd.concat([df1, df2], axis=1, copy=False)
self.assert_frame_equal(result, expected)

def test_align(self, data, na_value):
a = data[:3]
b = data[2:5]
Expand Down
4 changes: 4 additions & 0 deletions pandas/tests/extension/test_sparse.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,10 @@ def test_concat_columns(self, data, na_value):
self._check_unsupported(data)
super().test_concat_columns(data, na_value)

def test_concat_extension_arrays_copy_false(self, data, na_value):
self._check_unsupported(data)
super().test_concat_extension_arrays_copy_false(data, na_value)

def test_align(self, data, na_value):
self._check_unsupported(data)
super().test_align(data, na_value)
Expand Down