TST: Adding test to concat where copy=False for ExtensionArrays #30625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test ensures that ExtensionArrays are correctly constructed when concat(copy=False) is used.
pandas/tests/reshape/test_concat.py
Outdated
| @@ -2730,3 +2730,25 @@ def test_concat_datetimeindex_freq(): | |||
| expected = pd.DataFrame(data[50:] + data[:50], index=dr[50:].append(dr[:50])) | |||
| expected.index._data.freq = None | |||
| tm.assert_frame_equal(result, expected) | |||
|
|
|||
|
|
|||
| def test_concat_copy_false_extension_array(): | |||
There was a problem hiding this comment.
I think this should be add to the class at pandas.tests.extension.base.reshaping.BaseReshapingTests.
It'll need to be restructured a bit to not refer to decimal specifically. It needs to work with the data provided by the fixture. See the other concat there for examples.
There was a problem hiding this comment.
SGTM. Moved the test to pandas.tests.extension.base.reshaping.BaseReshapingTests and updated the test to use the data provided by the fixture. I also simplified the test to make it more clear.
Also simplifying the test case to make it more understandable.
TomAugspurger
approved these changes
Jan 2, 2020
jreback
requested changes
Jan 3, 2020
| @@ -94,6 +94,19 @@ def test_concat_columns(self, data, na_value): | |||
| result = pd.concat([df1["A"], df2["B"]], axis=1) | |||
| self.assert_frame_equal(result, expected) | |||
|
|
|||
| # non-aligned | |||
There was a problem hiding this comment.
can you make this into a new test.
Per the feedback from PR pandas-dev#30625
jreback
approved these changes
Jan 4, 2020
|
thanks @dwhu |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test ensures that ExtensionArrays are correctly constructed when
concat(copy=False) is used.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff