Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLN: Drop the buffer_lines parameter in read_csv #18835

Merged
merged 1 commit into from
Dec 19, 2017

Conversation

gfyoung
Copy link
Member

@gfyoung gfyoung commented Dec 19, 2017

Deprecated back in 0.19.0

xref #13360.

@gfyoung gfyoung added Clean Deprecate Functionality to remove in pandas labels Dec 19, 2017
@gfyoung gfyoung added this to the 0.22.0 milestone Dec 19, 2017
@codecov
Copy link

codecov bot commented Dec 19, 2017

Codecov Report

Merging #18835 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18835      +/-   ##
==========================================
- Coverage   91.64%   91.62%   -0.02%     
==========================================
  Files         154      154              
  Lines       51408    51408              
==========================================
- Hits        47113    47103      -10     
- Misses       4295     4305      +10
Flag Coverage Δ
#multiple 89.49% <ø> (-0.01%) ⬇️
#single 40.83% <ø> (-0.12%) ⬇️
Impacted Files Coverage Δ
pandas/io/parsers.py 95.49% <ø> (ø) ⬆️
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/frame.py 97.68% <0%> (-0.11%) ⬇️
pandas/core/indexes/datetimes.py 95.62% <0%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6a7cc9...1fa4bbf. Read the comment docs.

@jreback jreback merged commit 199e525 into pandas-dev:master Dec 19, 2017
@jreback
Copy link
Contributor

jreback commented Dec 19, 2017

thanks!

@gfyoung gfyoung deleted the buffer-lines-csv-remove branch December 19, 2017 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clean Deprecate Functionality to remove in pandas
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants