DEPR, DOC: Deprecate buffer_lines in read_csv #13360
Conversation
40010c2 to
87eff55
Compare
Current coverage is 84.23%@@ master #13360 diff @@
==========================================
Files 138 138
Lines 50724 50725 +1
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 42726 42727 +1
Misses 7998 7998
Partials 0 0
|
| @@ -227,14 +227,19 @@ | |||
| Note that the entire file is read into a single DataFrame regardless, | |||
| use the `chunksize` or `iterator` parameter to return the data in chunks. | |||
| (Only valid with C parser) | |||
| buffer_lines : int, default None | |||
There was a problem hiding this comment.
is this even used at all now?
There was a problem hiding this comment.
it seems its not respected at all now. so we should just remove this argument (or raise if its not None)
There was a problem hiding this comment.
Based on my PR description, nowhere. How significant of an API change would either option be?
There was a problem hiding this comment.
well it doesn't do anything now. I guess deprecation is fine. Why don't you re-word to say it currently has no-effect.
The 'buffer_lines' parameter is not even respected in the implementation, as it is determined internally to the C parser. [ci skip]
87eff55 to
a72ecbe
Compare
|
@jreback : Made the requested doc change, and Travis is giving the green light. Ready to merge if there is nothing else. |
|
ty |
| value is not respected by the parser | ||
|
|
||
| If ``low_memory`` is ``True``, specify the number of rows to be read for | ||
| each chunk. (Only valid with C parser) |
There was a problem hiding this comment.
Can't we leave out the actual explanation? As this is not only deprecated, but also does not work (IIUC), so it does not serve much purpose IMO (apart from explaining what feature exactly has never worked, and will never work ..)
BTW, @gfyoung, for the rest strong +1 on your cleaning up of the keywords!
There was a problem hiding this comment.
@jorisvandenbossche : Will do. Thanks, for the +1 - I use this function a great deal in my own code, so I'm certainly more than happy to improve it given how much it has done for me, even in such a "broken" state. 😄
Deprecated back in 0.19.0 xref pandas-devgh-13360.
Deprecated back in 0.19.0 xref gh-13360.
buffer_linesis not respected, as it is determined internally via a heuristic involvingtable_width(see here for how it is computed).