remove unused args etal from np_datetime.c #18567
Conversation
Codecov Report
@@ Coverage Diff @@
## master #18567 +/- ##
==========================================
+ Coverage 91.44% 91.45% +<.01%
==========================================
Files 157 157
Lines 51449 51449
==========================================
+ Hits 47048 47051 +3
+ Misses 4401 4398 -3
Continue to review full report at Codecov.
|
| return result; | ||
| } | ||
|
|
||
| void pandas_datetime_to_datetimestruct(npy_datetime val, PANDAS_DATETIMEUNIT fr, | ||
| pandas_datetimestruct *result) { | ||
| pandas_datetime_metadata meta; |
There was a problem hiding this comment.
could remove these functions entirely (and just call the convert_*) ones?
There was a problem hiding this comment.
Eventually. There are still some calls from np_datetime_strings.c and ujson/python/objToJSON.c so it isn't entirely trivial.
|
ping. would like to close (most) existing before doing anything new. |
|
@jbrockmendel yep that is fine. just rebase & ping on anything you'd like me to review. (so rebase here). |
d2c6936 to
c9c643d
Compare
|
just rebased+pushed; no new edits. |
|
should be good to go. #18565 may need rebasing after this; if not then it should be good to go too. |
|
thanks! |
What #18565 does for np_datetime_strings.c, this does for np_datetime.c
Getting rid of
metaalso gets rid of a potential problem noted in a comment thatmeta->numcould potentially cause an overflow. Sincemeta->numis 1 in all pandas usages, that pitfall doesn't apply.