Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused arguments from np_datetime_strings #18565

Merged
merged 4 commits into from
Dec 6, 2017

Conversation

jbrockmendel
Copy link
Member

Same deal as #18546. This completes the pure-cleaning phase for np_datetime_strings.

@codecov
Copy link

codecov bot commented Nov 29, 2017

Codecov Report

Merging #18565 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18565      +/-   ##
==========================================
- Coverage   91.35%   91.33%   -0.02%     
==========================================
  Files         164      164              
  Lines       49802    49802              
==========================================
- Hits        45496    45487       -9     
- Misses       4306     4315       +9
Flag Coverage Δ
#multiple 89.13% <ø> (ø) ⬆️
#single 40.81% <ø> (-0.07%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/frame.py 97.81% <0%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7627cca...419e02c. Read the comment docs.

@codecov
Copy link

codecov bot commented Nov 29, 2017

Codecov Report

Merging #18565 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18565      +/-   ##
==========================================
- Coverage   91.59%   91.58%   -0.02%     
==========================================
  Files         155      153       -2     
  Lines       51255    51253       -2     
==========================================
- Hits        46948    46941       -7     
- Misses       4307     4312       +5
Flag Coverage Δ
#multiple 89.45% <ø> (ø) ⬆️
#single 40.67% <ø> (-0.11%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/frame.py 97.81% <0%> (-0.1%) ⬇️
pandas/io/data.py
pandas/io/wb.py
pandas/util/testing.py 82.01% <0%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a764663...6af5366. Read the comment docs.

@jreback jreback added the Clean label Dec 1, 2017
@jbrockmendel
Copy link
Member Author

After this and #18567 there are two more PRs on deck to simplify src/datetime.

@jreback
Copy link
Contributor

jreback commented Dec 4, 2017

yep rebase

@jbrockmendel
Copy link
Member Author

Travis error is a timeout, looks unrelated. Will re-push this evening.

@jreback jreback added this to the 0.22.0 milestone Dec 5, 2017
@jreback
Copy link
Contributor

jreback commented Dec 5, 2017

lgtm. ping on green.

@jbrockmendel
Copy link
Member Author

ping

@jbrockmendel
Copy link
Member Author

Once this is closed we can kill off datetime.pxd

@jreback jreback merged commit 13f6267 into pandas-dev:master Dec 6, 2017
@jreback
Copy link
Contributor

jreback commented Dec 6, 2017

kill it!

@jbrockmendel jbrockmendel deleted the npcruft2 branch December 8, 2017 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants