-
-
Notifications
You must be signed in to change notification settings - Fork 18.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused arguments from np_datetime_strings #18565
Conversation
Codecov Report
@@ Coverage Diff @@
## master #18565 +/- ##
==========================================
- Coverage 91.35% 91.33% -0.02%
==========================================
Files 164 164
Lines 49802 49802
==========================================
- Hits 45496 45487 -9
- Misses 4306 4315 +9
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #18565 +/- ##
==========================================
- Coverage 91.59% 91.58% -0.02%
==========================================
Files 155 153 -2
Lines 51255 51253 -2
==========================================
- Hits 46948 46941 -7
- Misses 4307 4312 +5
Continue to review full report at Codecov.
|
After this and #18567 there are two more PRs on deck to simplify src/datetime. |
419e02c
to
f698945
Compare
yep rebase |
Travis error is a timeout, looks unrelated. Will re-push this evening. |
lgtm. ping on green. |
ping |
Once this is closed we can kill off datetime.pxd |
kill it! |
Same deal as #18546. This completes the pure-cleaning phase for np_datetime_strings.