Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Remove assert_equal from testing.py #16017

Merged
merged 1 commit into from
Apr 16, 2017

Conversation

gfyoung
Copy link
Member

@gfyoung gfyoung commented Apr 16, 2017

Title is self-explanatory.

Partially addresses #15990.

@codecov
Copy link

codecov bot commented Apr 16, 2017

Codecov Report

Merging #16017 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16017      +/-   ##
==========================================
+ Coverage   90.99%      91%   +<.01%     
==========================================
  Files         154      154              
  Lines       50484    50482       -2     
==========================================
- Hits        45940    45939       -1     
+ Misses       4544     4543       -1
Flag Coverage Δ
#multiple 88.76% <ø> (ø) ⬆️
#single 40.44% <ø> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/util/testing.py 80.97% <ø> (-0.04%) ⬇️
pandas/core/common.py 91.03% <0%> (+0.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8daf9a7...e808a91. Read the comment docs.

@jorisvandenbossche jorisvandenbossche added Clean Testing pandas testing functions or related to the test suite labels Apr 16, 2017
@jreback
Copy link
Contributor

jreback commented Apr 16, 2017

@gfyoung can you rebase, I had merged the .formats move

@gfyoung gfyoung force-pushed the tm-assert-equal-remove branch from b7fc8bb to e808a91 Compare April 16, 2017 16:26
@gfyoung
Copy link
Member Author

gfyoung commented Apr 16, 2017

@jreback , @jorisvandenbossche : Rebased, all green, and ready to merge.

@jreback jreback added this to the 0.20.0 milestone Apr 16, 2017
@jreback jreback merged commit c364e1d into pandas-dev:master Apr 16, 2017
@jreback
Copy link
Contributor

jreback commented Apr 16, 2017

thanks!

@gfyoung gfyoung deleted the tm-assert-equal-remove branch April 16, 2017 18:29
tswast added a commit to tswast/python-bigquery-pandas that referenced this pull request May 19, 2017
This method was removed in
pandas-dev/pandas#16017 in favor of
pytest.raises.
tswast added a commit to tswast/python-bigquery-pandas that referenced this pull request May 19, 2017
This method was removed in
pandas-dev/pandas#16017 in favor of
pytest.raises.
parthea pushed a commit to parthea/pandas-gbq that referenced this pull request Jun 11, 2017
This method was removed in
pandas-dev/pandas#16017 in favor of
pytest.raises.
parthea added a commit to googleapis/python-bigquery-pandas that referenced this pull request Jun 11, 2017
* TST: Fix broken tests failing with 'NoneType' object is not iterable

* MAINT: pandas.util.testing.assertRaises removed

This method was removed in
pandas-dev/pandas#16089 in favor of
pytest.raises.

* MAINT: pandas.util.testing.assert_equals removed

This method was removed in
pandas-dev/pandas#16017 in favor of
pytest.raises.
tswast added a commit to tswast/python-bigquery-pandas that referenced this pull request Jun 12, 2017
This method was removed in
pandas-dev/pandas#16017 in favor of
pytest.raises.
parthea pushed a commit to parthea/pandas-gbq that referenced this pull request Jun 16, 2017
This method was removed in
pandas-dev/pandas#16017 in favor of
pytest.raises.
parthea pushed a commit to tswast/python-bigquery-pandas that referenced this pull request Jun 16, 2017
This method was removed in
pandas-dev/pandas#16017 in favor of
pytest.raises.
parthea pushed a commit to googleapis/python-bigquery-pandas that referenced this pull request Jun 16, 2017
* BUG: oauth2client deprecated, use google-auth instead.

Remove the use of oauth2client and use google-auth library, instead.
See GH#37.

Rather than check for multiple versions of the libraries, use the
setup.py to specify compatible versions. I believe this is safe since
Pandas checks for the pandas_gbq package.

Since google-auth does not use the argparse module to override user
authentication flow settings, add a parameter to choose between the web
and console flow.

Addresses some eventual consistency issues in table/dataset listing in
the integration tests.

* MAINT: pandas.util.testing.assertRaises removed

This method was removed in
pandas-dev/pandas#16089 in favor of
pytest.raises.

* MAINT: pandas.util.testing.assert_equals removed

This method was removed in
pandas-dev/pandas#16017 in favor of
pytest.raises.

* DOC: add version tags for new auth_local_webserver params.

* CLN: share _test_imports between main module and tests

* TST: pin versions on 3.5 rather than 2.7.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clean Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants