Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: Fix broken tests failing with 'NoneType' object is not iterable / module 'pandas.util.testing' has no attribute 'assertRaises' #58

Merged
merged 3 commits into from
Jun 11, 2017

Conversation

parthea
Copy link
Contributor

@parthea parthea commented Jun 11, 2017

Fixes #57. This 2 line fix was originally part of @tswast's PR #39 but I'm going to transfer it here so that it's easier to capture the specific fix. PR #39 also has other reliability improvements to the integration testing which resolve intermittent failures. The changes in this PR fix the consistent failure TypeError: 'NoneType' object is not iterable.

@codecov-io
Copy link

codecov-io commented Jun 11, 2017

Codecov Report

Merging #58 into master will decrease coverage by 27.76%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #58       +/-   ##
===========================================
- Coverage   57.04%   29.27%   -27.77%     
===========================================
  Files           4        4               
  Lines        1511     1513        +2     
===========================================
- Hits          862      443      -419     
- Misses        649     1070      +421
Impacted Files Coverage Δ
pandas_gbq/gbq.py 16.02% <0%> (-40.4%) ⬇️
pandas_gbq/tests/test_gbq.py 31.88% <0%> (-29.99%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17e9812...4e9002d. Read the comment docs.

tswast added 2 commits June 10, 2017 22:53
This method was removed in
pandas-dev/pandas#16089 in favor of
pytest.raises.
This method was removed in
pandas-dev/pandas#16017 in favor of
pytest.raises.
@parthea parthea changed the title TST: Fix broken tests failing with 'NoneType' object is not iterable TST: Fix broken tests failing with 'NoneType' object is not iterable / module 'pandas.util.testing' has no attribute 'assertRaises' Jun 11, 2017
@parthea
Copy link
Contributor Author

parthea commented Jun 11, 2017

All tests are passing now with the changes in this PR. The majority of the fixes are based on commits from @tswast .
https://travis-ci.org/parthea/pandas-gbq/builds/241645611

@parthea parthea merged commit 47bcc66 into googleapis:master Jun 11, 2017
@parthea
Copy link
Contributor Author

parthea commented Jun 11, 2017

Thanks @tswast !

@parthea parthea deleted the fix-broken-tests branch June 11, 2017 03:15
@jreback
Copy link
Contributor

jreback commented Jun 11, 2017

can u add a release note as well

@parthea
Copy link
Contributor Author

parthea commented Jun 11, 2017

My initial thought is that a release note entry isn't needed because the affected function _Dataset(<project_id>).datasets() at https://github.com/pydata/pandas-gbq/blob/master/pandas_gbq/gbq.py#L1030 is not called in gbq.py. It is only called in integration testing. A release entry is needed if we think someone may be using this specific undocumented function.

@jreback
Copy link
Contributor

jreback commented Jun 11, 2017

@parthea ahh I c. that is all fine. glad tests are passing. thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TST: failing tests
4 participants