Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update upgrade scripts #2607

Merged
merged 4 commits into from
Jun 20, 2018
Merged

update upgrade scripts #2607

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8aeb278
update upgrade scripts
Jun 12, 2018
49298c1
add SVGPopover/Tooltip entries
Jun 18, 2018
355f03a
regex syntax
Jun 19, 2018
3aa6c4d
add entry for core Table => HTMLTable
Jun 20, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 28 additions & 4 deletions packages/core/scripts/upgrade-blueprint-3.0.0-rename.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,31 @@ echo "

Renames for @blueprintjs/core"
renameProp visual icon
renameString "Classes\.CALLOUT_TITLE" "Classes.HEADING"
renameString "Classes\.DIALOG_TITLE" "Classes.HEADING"
renameString "Classes\.HOTKEY_GROUP" "Classes.HEADING"
renameString "Classes\.NON_IDEAL_STATE_TITLE" "Classes.HEADING"
renameProp didClose onClosed
renameProp didOpen onOpened
renameProp popoverDidClose onClosed
renameProp popoverDidOpen onOpened
renameProp popoverWillClose onClosing
renameProp popoverWillOpen onOpening
renameString 'requiredLabel={true}' 'labelInfo="(required)"'
renameProp requiredLabel labelInfo

# Classes constants
renameString "Classes\.CALLOUT_TITLE" "Classes.HEADING"
renameString "Classes\.DIALOG_TITLE" "Classes.HEADING"
renameString "Classes\.HOTKEY_GROUP" "Classes.HEADING"
renameString "Classes\.NON_IDEAL_STATE_TITLE" "Classes.HEADING"
renameString "Classes\.UI_TEXT_LARGE" "Classes.UI_TEXT, Classes.TEXT_LARGE"
renameString "Classes\.RUNNING_TEXT" "Classes.RUNNING_TEXT, Classes.TEXT_LARGE"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why should running text now be large?

Copy link
Contributor Author

@giladgray giladgray Jun 19, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the default used to be large and it had a small variant. i standardized it in #2366

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we used to have RUNNING_TEXT and RUNNING_TEXT_SMALL where the regular one was actually large font size, but in #2366 i added a new TEXT_LARGE modifier, so RUNNING_TEXT in 3.0 uses default normal font size.

this means that folks who were using RUNNING_TEXT in 1.x should now also apply TEXT_LARGE in 3.0.

renameString "Classes\.RUNNING_TEXT_SMALL" "Classes.RUNNING_TEXT"

# Deleted things
renameString "Classes\.TAG_REMOVABLE,?" ""
renameString "Classes\.NON_IDEAL_STATE_(ACTION|DESCRIPTION|ICON),?" ""
renameString "Classes\.SPINNER_SVG_CONTAINER,?" ""
renameString "Classes\.SVG_SPINNER,?" ""
warn SVGSpinner "DELETED. Spinner now supports usage in an SVG."
warn SVGPopover "DELETED. Set *TagName props to SVG elements."
warn SVGTooltip "DELETED. Set *TagName props to SVG elements."
warn Spinner "`small/large` replaced with single `size` prop"
warn "\\bTable\\b" "@blueprintjs/core Table component renamed to HTMLTable (@blueprintjs/table package unchanged)."