update upgrade scripts #2607
Merged
update upgrade scripts #2607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update upgrade scriptsPreview: documentation | landing | table |
add SVGPopover/Tooltip entriesPreview: documentation | landing | table |
regex syntaxPreview: documentation | landing | table |
invliD
reviewed
Jun 19, 2018
| renameString "Classes\.HOTKEY_GROUP" "Classes.HEADING" | ||
| renameString "Classes\.NON_IDEAL_STATE_TITLE" "Classes.HEADING" | ||
| renameString "Classes\.UI_TEXT_LARGE" "Classes.UI_TEXT, Classes.TEXT_LARGE" | ||
| renameString "Classes\.RUNNING_TEXT" "Classes.RUNNING_TEXT, Classes.TEXT_LARGE" |
There was a problem hiding this comment.
Why should running text now be large?
There was a problem hiding this comment.
the default used to be large and it had a small variant. i standardized it in #2366
There was a problem hiding this comment.
we used to have RUNNING_TEXT and RUNNING_TEXT_SMALL where the regular one was actually large font size, but in #2366 i added a new TEXT_LARGE modifier, so RUNNING_TEXT in 3.0 uses default normal font size.
this means that folks who were using RUNNING_TEXT in 1.x should now also apply TEXT_LARGE in 3.0.
|
|
themadcreator
approved these changes
Jun 20, 2018
add entry for core Table => HTMLTablePreview: documentation | landing | table |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2587
Changes proposed in this pull request:
add fixes for latest changes to 3.0.0 upgrade script.