[Forms] Add <Label> and <FormGroup> examples #2433
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,62 @@ | ||
| /* | ||
| * Copyright 2016 Palantir Technologies, Inc. All rights reserved. | ||
|
|
||
| * | ||
| * Licensed under the terms of the LICENSE file distributed with this project. | ||
| */ | ||
|
|
||
| import * as React from "react"; | ||
|
|
||
| import { FormGroup, InputGroup, Switch } from "@blueprintjs/core"; | ||
| import { BaseExample, handleBooleanChange } from "@blueprintjs/docs-theme"; | ||
|
|
||
| export interface IFormGroupExampleState { | ||
| disabled: boolean; | ||
| helperText: boolean; | ||
| inline: boolean; | ||
| } | ||
|
|
||
| export class FormGroupExample extends BaseExample<IFormGroupExampleState> { | ||
|
There was a problem hiding this comment. rewrite for new example syntax |
||
| public state: IFormGroupExampleState = { | ||
| disabled: false, | ||
| helperText: false, | ||
| inline: false, | ||
| }; | ||
|
|
||
| protected className = "docs-label-example"; | ||
|
|
||
| private handleDisabledChange = handleBooleanChange(disabled => this.setState({ disabled })); | ||
| private handleHelperTextChange = handleBooleanChange(helperText => this.setState({ helperText })); | ||
| private handleInlineChange = handleBooleanChange(inline => this.setState({ inline })); | ||
|
|
||
| protected renderExample() { | ||
| const { disabled, helperText, inline } = this.state; | ||
| return ( | ||
| <FormGroup | ||
| disabled={disabled} | ||
| helperText={helperText ? "Helper text with details..." : undefined} | ||
| inline={inline} | ||
| label="Label" | ||
| requiredLabel={true} | ||
| labelFor="text-input" | ||
| > | ||
| <InputGroup id="text-input" placeholder="Placeholder text" disabled={disabled} /> | ||
| </FormGroup> | ||
| ); | ||
| } | ||
|
|
||
| protected renderOptions() { | ||
| const { disabled, helperText, inline } = this.state; | ||
| return [ | ||
| [ | ||
|
|
||
| <Switch key="inline" label="Inline" checked={inline} onChange={this.handleInlineChange} />, | ||
| <Switch | ||
| key="helperText" | ||
| label="Show helper text" | ||
| checked={helperText} | ||
| onChange={this.handleHelperTextChange} | ||
| />, | ||
| <Switch key="disabled" label="Disabled" checked={disabled} onChange={this.handleDisabledChange} />, | ||
|
There was a problem hiding this comment. put this switch first please (alph) |
||
| ], | ||
| ]; | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,61 @@ | ||
| /* | ||
| * Copyright 2016 Palantir Technologies, Inc. All rights reserved. | ||
|
|
||
| * | ||
| * Licensed under the terms of the LICENSE file distributed with this project. | ||
| */ | ||
|
|
||
| import * as React from "react"; | ||
|
|
||
| import { InputGroup, Label, Switch } from "@blueprintjs/core"; | ||
| import { BaseExample, handleBooleanChange } from "@blueprintjs/docs-theme"; | ||
|
|
||
| export interface ILabelExampleState { | ||
| disabled: boolean; | ||
| helperText: boolean; | ||
| inline: boolean; | ||
| } | ||
|
|
||
| export class LabelExample extends BaseExample<ILabelExampleState> { | ||
|
There was a problem hiding this comment. given #2460, do we really want to add a There was a problem hiding this comment. I'd say it doesn't hurt to have one for now, helps with testing and comparing with There was a problem hiding this comment. rewrite to use new |
||
| public state: ILabelExampleState = { | ||
| disabled: false, | ||
| helperText: false, | ||
| inline: false, | ||
| }; | ||
|
|
||
| protected className = "docs-label-example"; | ||
|
There was a problem hiding this comment. these are not necessary. let's only add them when required for custom styles |
||
|
|
||
| private handleDisabledChange = handleBooleanChange(disabled => this.setState({ disabled })); | ||
| private handleHelperTextChange = handleBooleanChange(helperText => this.setState({ helperText })); | ||
| private handleInlineChange = handleBooleanChange(inline => this.setState({ inline })); | ||
|
|
||
| protected renderExample() { | ||
| const { disabled, helperText, inline, ...labelProps } = this.state; | ||
| return ( | ||
| <Label | ||
| disabled={disabled} | ||
| helperText={helperText ? "(required)" : undefined} | ||
| inline={inline} | ||
| text="Label" | ||
| {...labelProps} | ||
| > | ||
| <InputGroup type="text" placeholder="Input with icon" leftIcon="text-highlight" disabled={disabled} /> | ||
| </Label> | ||
| ); | ||
| } | ||
|
|
||
| protected renderOptions() { | ||
| const { disabled, helperText, inline } = this.state; | ||
| return [ | ||
| [ | ||
|
|
||
| <Switch key="inline" label="Inline" checked={inline} onChange={this.handleInlineChange} />, | ||
| <Switch | ||
| key="helperText" | ||
| label="Show helper text" | ||
| checked={helperText} | ||
| onChange={this.handleHelperTextChange} | ||
| />, | ||
| <Switch key="disabled" label="Disabled" checked={disabled} onChange={this.handleDisabledChange} />, | ||
| ], | ||
| ]; | ||
| } | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not just use
<strong>tags if all you want is bold? it's both semantic and requires no additional styles or classes.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cause if we change this in the future, we'll also have to change the tag. poor maintanability
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but that tag isn't going anywhere! it's the semantic browser way of saying "make this text stronger," which is exactly what you're trying to do here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please try it. i'm quite confident it'll work beautifully and we won't have to add another
-textclass for one style rule.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what I meant is that I don't like tying a visual to a specific tag. if in the future I want to get rid of bold and do another visual style, I'll have to change the tag because
<strong>will no longer make sense.did it anyway, kind of a bummer tho cause I still need to override the
font-weightof the<strong>(default is 700, we want 600)