Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deconflict Label and FormGroup #2460

Closed
llorca opened this issue May 4, 2018 · 2 comments · Fixed by #2570
Closed

Deconflict Label and FormGroup #2460

llorca opened this issue May 4, 2018 · 2 comments · Fixed by #2570
Assignees
@llorca
Labels
Package: core Type: breaking change Type: refactor
Milestone
3.0.0

Comments

@llorca
Copy link
Contributor

llorca commented May 4, 2018 •
edited
Loading

They both do similar things, with a very inconsistent API.

Proposal 1: since FormGroup can do everything a Label does and more, we can potentially get rid of Label

Other proposal 2: Label and FormGroup both implement a common secondaryLabel prop (just like Trees) to display a muted text near the main bold label
@llorca llorca added this to the 3.0.0 milestone May 4, 2018
@giladgray
Copy link
Contributor

given that FormGroup is better than Label in like every way, we could just kill Label entirely and only offer FormGroup

@giladgray giladgray mentioned this issue May 15, 2018
Closed
@llorca llorca self-assigned this May 21, 2018
@llorca
Copy link
Contributor Author

llorca commented May 21, 2018

Label becomes a simple HTML wrapper, composed in FormGroup

This was referenced Jun 5, 2018
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@llorca llorca

Labels
Package: core Type: breaking change Type: refactor
Projects
None yet
Milestone
3.0.0
Development

Successfully merging a pull request may close this issue.

[core] better FormGroup palantir/blueprint
2 participants
@llorca @giladgray