VL-60 Make x-amz-sdk-checksum-algorithm optional #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gunzip
reviewed
Sep 1, 2022
| @@ -10,7 +11,7 @@ export type UploadToS3Record = { | |||
| type: 'UploadToS3Record'; | |||
| input: { | |||
| key: AmzDocumentKey; | |||
| checksumAlg: AmzSdkChecksumAlg; | |||
| checksumAlg: Option<AmzSdkChecksumAlg>; | |||
There was a problem hiding this comment.
Try not to make structure embedding monads, just use types instead.
If you want a structured types with optionals use io-ts instead.
| @@ -10,7 +11,7 @@ import { AmzDocumentKey } from '../generated/definitions/AmzDocumentKey'; | |||
| export const UploadToS3UseCase = | |||
| (uploadToS3Repository: UploadToS3RecordRepository) => | |||
| (key: AmzDocumentKey) => | |||
| (checksumAlg: AmzSdkChecksumAlg) => | |||
| (checksumAlg: O.Option<AmzSdkChecksumAlg>) => | |||
There was a problem hiding this comment.
try to do not take monads as input (it's caller duty to do the checks before passing it to the method)
dennycarusonttdata
added a commit
that referenced
this pull request
Sep 29, 2023
* applied configuration * UploadToS3Record completely tested * Problem partially tested * types fully tested * Commit di Denny * update jest and package.json * added again data.ts content * added some tests for router * added another test for router. 70% lines now * test PreLoad router * Linted code for push * Linted code, again * update describe 200 to 400 + uploadToS3 test * test sendNotification router * minor change to uploadToS3 test * test for getStream By Id * test ListEventStream router * added checkListResult test * added checklist result tests * Cleaned code --------- Co-authored-by: CCTuduran <140727607+CCTuduran@users.noreply.github.com> Co-authored-by: Alexandru Daniel Iova <alexandrudaniel.iova@emeal.nttdata.com> Co-authored-by: Alexandru Daniel Iova <AlexandruDaniel.Iova@nttdata.com>
dennycarusonttdata
added a commit
that referenced
this pull request
Feb 1, 2024
* generated yaml from version 2.1 * commented 'F24Metadata' schema inside yaml, due error generating models * updated 'hot-to-generate-the...md' * completed VL-295 * eslint fix * eslint fix * changed NewNotificationRequest to NewNotificationRequestV21. Now there are errors before running * changed NewNotificationRequest to NewNotificationRequestV21. Now there are errors before running * fix file with errors after using NewNotificationRequestV21 * fix file with errors after using NewNotificationRequestV21 * eslint fix * completed again VL-295 * completed again VL-295 * completed again VL-295 * still fix to do * added todo denny * first todo denny fix completed * eslint fix * fix for VL-295 due to issue in other files * eslint suggested fixes * eslint suggested fixes * fix for VL-295 w/ Cosmin * eslint fix * eslint fix * eslint fix * changing old type to the new ones * eslint fix * eslint fix * eslint fix * removed unused enum * fix accepted issue * fix tslint issues * fix tslint issue * Features/2.1/main (#12) * partial permit upload of json during uploadS3 * partial permit upload of json during uploadS3 * partial permit upload of json during uploadS3 * handled attachmentName 'F24' * completed VL-294 + fix critical severity vulnerability in package-lock.json raised by npm install command * added semicolon due to husky error * eslint fix * fix reference to delivery-push url * fix * fix imports * fix req 7 handling * fix req 7 handling * update package-lock * completed VL-296 * completed VL-296 * VL-298 completed * VL-299 completed * added collection json + 2.1 version --------- Co-authored-by: Cosmin15 <Tuduran.cosmin@gmail.com> Co-authored-by: Tuduran, Cosmin Constantin <cosminconstantin.tuduran@nttdata.com> * Features/2.1/main (#13) * partial permit upload of json during uploadS3 * partial permit upload of json during uploadS3 * partial permit upload of json during uploadS3 * handled attachmentName 'F24' * completed VL-294 + fix critical severity vulnerability in package-lock.json raised by npm install command * added semicolon due to husky error * eslint fix * fix reference to delivery-push url * fix * fix imports * fix req 7 handling * fix req 7 handling * update package-lock * completed VL-296 * completed VL-296 * VL-298 completed * VL-299 completed * added collection json + 2.1 version * update tests * fix tests * fix tests --------- Co-authored-by: Cosmin15 <Tuduran.cosmin@gmail.com> Co-authored-by: Tuduran, Cosmin Constantin <cosminconstantin.tuduran@nttdata.com> * fix tests * first basic code handling for notification delete * update package.json * eslint fix * added .use in application.ts * merge main from features/2.0/main (#14) * generated yaml from version 2.1 * commented 'F24Metadata' schema inside yaml, due error generating models * updated 'hot-to-generate-the...md' * completed VL-295 * eslint fix * eslint fix * changed NewNotificationRequest to NewNotificationRequestV21. Now there are errors before running * changed NewNotificationRequest to NewNotificationRequestV21. Now there are errors before running * fix file with errors after using NewNotificationRequestV21 * fix file with errors after using NewNotificationRequestV21 * eslint fix * completed again VL-295 * completed again VL-295 * completed again VL-295 * still fix to do * added todo denny * first todo denny fix completed * eslint fix * fix for VL-295 due to issue in other files * eslint suggested fixes * eslint suggested fixes * fix for VL-295 w/ Cosmin * eslint fix * eslint fix * eslint fix * changing old type to the new ones * eslint fix * eslint fix * eslint fix * removed unused enum * fix accepted issue * fix tslint issues * fix tslint issue * Features/2.1/main (#12) * partial permit upload of json during uploadS3 * partial permit upload of json during uploadS3 * partial permit upload of json during uploadS3 * handled attachmentName 'F24' * completed VL-294 + fix critical severity vulnerability in package-lock.json raised by npm install command * added semicolon due to husky error * eslint fix * fix reference to delivery-push url * fix * fix imports * fix req 7 handling * fix req 7 handling * update package-lock * completed VL-296 * completed VL-296 * VL-298 completed * VL-299 completed * added collection json + 2.1 version --------- Co-authored-by: Cosmin15 <Tuduran.cosmin@gmail.com> Co-authored-by: Tuduran, Cosmin Constantin <cosminconstantin.tuduran@nttdata.com> * Features/2.1/main (#13) * partial permit upload of json during uploadS3 * partial permit upload of json during uploadS3 * partial permit upload of json during uploadS3 * handled attachmentName 'F24' * completed VL-294 + fix critical severity vulnerability in package-lock.json raised by npm install command * added semicolon due to husky error * eslint fix * fix reference to delivery-push url * fix * fix imports * fix req 7 handling * fix req 7 handling * update package-lock * completed VL-296 * completed VL-296 * VL-298 completed * VL-299 completed * added collection json + 2.1 version * update tests * fix tests * fix tests --------- Co-authored-by: Cosmin15 <Tuduran.cosmin@gmail.com> Co-authored-by: Tuduran, Cosmin Constantin <cosminconstantin.tuduran@nttdata.com> * fix tests --------- Co-authored-by: Cosmin Constantin Tuduran <cosminconstantin.tuduran@nttdata.com> Co-authored-by: Cosmin15 <Tuduran.cosmin@gmail.com> * merge main from features/2.0/main (#14) (#15) * generated yaml from version 2.1 * commented 'F24Metadata' schema inside yaml, due error generating models * updated 'hot-to-generate-the...md' * completed VL-295 * eslint fix * eslint fix * changed NewNotificationRequest to NewNotificationRequestV21. Now there are errors before running * changed NewNotificationRequest to NewNotificationRequestV21. Now there are errors before running * fix file with errors after using NewNotificationRequestV21 * fix file with errors after using NewNotificationRequestV21 * eslint fix * completed again VL-295 * completed again VL-295 * completed again VL-295 * still fix to do * added todo denny * first todo denny fix completed * eslint fix * fix for VL-295 due to issue in other files * eslint suggested fixes * eslint suggested fixes * fix for VL-295 w/ Cosmin * eslint fix * eslint fix * eslint fix * changing old type to the new ones * eslint fix * eslint fix * eslint fix * removed unused enum * fix accepted issue * fix tslint issues * fix tslint issue * Features/2.1/main (#12) * partial permit upload of json during uploadS3 * partial permit upload of json during uploadS3 * partial permit upload of json during uploadS3 * handled attachmentName 'F24' * completed VL-294 + fix critical severity vulnerability in package-lock.json raised by npm install command * added semicolon due to husky error * eslint fix * fix reference to delivery-push url * fix * fix imports * fix req 7 handling * fix req 7 handling * update package-lock * completed VL-296 * completed VL-296 * VL-298 completed * VL-299 completed * added collection json + 2.1 version --------- * Features/2.1/main (#13) * partial permit upload of json during uploadS3 * partial permit upload of json during uploadS3 * partial permit upload of json during uploadS3 * handled attachmentName 'F24' * completed VL-294 + fix critical severity vulnerability in package-lock.json raised by npm install command * added semicolon due to husky error * eslint fix * fix reference to delivery-push url * fix * fix imports * fix req 7 handling * fix req 7 handling * update package-lock * completed VL-296 * completed VL-296 * VL-298 completed * VL-299 completed * added collection json + 2.1 version * update tests * fix tests * fix tests --------- * fix tests --------- Co-authored-by: Cosmin Constantin Tuduran <cosminconstantin.tuduran@nttdata.com> Co-authored-by: Cosmin15 <Tuduran.cosmin@gmail.com> * removed fluffy comments * removed fluffy comments * Features/2.0/main (#16) * merge main from features/2.0/main (#14) * generated yaml from version 2.1 * commented 'F24Metadata' schema inside yaml, due error generating models * updated 'hot-to-generate-the...md' * completed VL-295 * eslint fix * eslint fix * changed NewNotificationRequest to NewNotificationRequestV21. Now there are errors before running * changed NewNotificationRequest to NewNotificationRequestV21. Now there are errors before running * fix file with errors after using NewNotificationRequestV21 * fix file with errors after using NewNotificationRequestV21 * eslint fix * completed again VL-295 * completed again VL-295 * completed again VL-295 * still fix to do * added todo denny * first todo denny fix completed * eslint fix * fix for VL-295 due to issue in other files * eslint suggested fixes * eslint suggested fixes * fix for VL-295 w/ Cosmin * eslint fix * eslint fix * eslint fix * changing old type to the new ones * eslint fix * eslint fix * eslint fix * removed unused enum * fix accepted issue * fix tslint issues * fix tslint issue * Features/2.1/main (#12) * partial permit upload of json during uploadS3 * partial permit upload of json during uploadS3 * partial permit upload of json during uploadS3 * handled attachmentName 'F24' * completed VL-294 + fix critical severity vulnerability in package-lock.json raised by npm install command * added semicolon due to husky error * eslint fix * fix reference to delivery-push url * fix * fix imports * fix req 7 handling * fix req 7 handling * update package-lock * completed VL-296 * completed VL-296 * VL-298 completed * VL-299 completed * added collection json + 2.1 version --------- Co-authored-by: Cosmin15 <Tuduran.cosmin@gmail.com> Co-authored-by: Tuduran, Cosmin Constantin <cosminconstantin.tuduran@nttdata.com> * Features/2.1/main (#13) * partial permit upload of json during uploadS3 * partial permit upload of json during uploadS3 * partial permit upload of json during uploadS3 * handled attachmentName 'F24' * completed VL-294 + fix critical severity vulnerability in package-lock.json raised by npm install command * added semicolon due to husky error * eslint fix * fix reference to delivery-push url * fix * fix imports * fix req 7 handling * fix req 7 handling * update package-lock * completed VL-296 * completed VL-296 * VL-298 completed * VL-299 completed * added collection json + 2.1 version * update tests * fix tests * fix tests --------- Co-authored-by: Cosmin15 <Tuduran.cosmin@gmail.com> Co-authored-by: Tuduran, Cosmin Constantin <cosminconstantin.tuduran@nttdata.com> * fix tests --------- Co-authored-by: Cosmin Constantin Tuduran <cosminconstantin.tuduran@nttdata.com> Co-authored-by: Cosmin15 <Tuduran.cosmin@gmail.com> * removed fluffy comments --------- Co-authored-by: Cosmin Constantin Tuduran <cosminconstantin.tuduran@nttdata.com> Co-authored-by: Cosmin15 <Tuduran.cosmin@gmail.com> * pr update 291 (#17) * generated yaml from version 2.1 * commented 'F24Metadata' schema inside yaml, due error generating models * updated 'hot-to-generate-the...md' * completed VL-295 * eslint fix * eslint fix * changed NewNotificationRequest to NewNotificationRequestV21. Now there are errors before running * changed NewNotificationRequest to NewNotificationRequestV21. Now there are errors before running * fix file with errors after using NewNotificationRequestV21 * fix file with errors after using NewNotificationRequestV21 * eslint fix * completed again VL-295 * completed again VL-295 * completed again VL-295 * still fix to do * added todo denny * first todo denny fix completed * eslint fix * fix for VL-295 due to issue in other files * eslint suggested fixes * eslint suggested fixes * fix for VL-295 w/ Cosmin * eslint fix * eslint fix * eslint fix * changing old type to the new ones * eslint fix * eslint fix * eslint fix * removed unused enum * fix accepted issue * fix tslint issues * fix tslint issue * Features/2.1/main (#12) * partial permit upload of json during uploadS3 * partial permit upload of json during uploadS3 * partial permit upload of json during uploadS3 * handled attachmentName 'F24' * completed VL-294 + fix critical severity vulnerability in package-lock.json raised by npm install command * added semicolon due to husky error * eslint fix * fix reference to delivery-push url * fix * fix imports * fix req 7 handling * fix req 7 handling * update package-lock * completed VL-296 * completed VL-296 * VL-298 completed * VL-299 completed * added collection json + 2.1 version --------- Co-authored-by: Cosmin15 <Tuduran.cosmin@gmail.com> Co-authored-by: Tuduran, Cosmin Constantin <cosminconstantin.tuduran@nttdata.com> * Features/2.1/main (#13) * partial permit upload of json during uploadS3 * partial permit upload of json during uploadS3 * partial permit upload of json during uploadS3 * handled attachmentName 'F24' * completed VL-294 + fix critical severity vulnerability in package-lock.json raised by npm install command * added semicolon due to husky error * eslint fix * fix reference to delivery-push url * fix * fix imports * fix req 7 handling * fix req 7 handling * update package-lock * completed VL-296 * completed VL-296 * VL-298 completed * VL-299 completed * added collection json + 2.1 version * update tests * fix tests * fix tests --------- Co-authored-by: Cosmin15 <Tuduran.cosmin@gmail.com> Co-authored-by: Tuduran, Cosmin Constantin <cosminconstantin.tuduran@nttdata.com> * fix tests --------- Co-authored-by: Cosmin Constantin Tuduran <cosminconstantin.tuduran@nttdata.com> Co-authored-by: Cosmin15 <Tuduran.cosmin@gmail.com> * removed fluffy comments * completede basic behavior of 291 and 292 * eslint fix * eslint fix * update from del to put endpoint * basic working version of 291+292 * eslint fix * update import statements + remove pnstram generate * eslint fix * update v2.0 endpoint url to v2.1 * adding basic code * adding basic code * eslint fix * changed from manual retrieving to automatic one within map * eslint fix * Feature/VL-300 (#19) * VL-300 - removed legalFactType path param from api * solved error unmatching types * eslint fix * eslint fix * completed VL-287 * eslint fix * eslint fix * Adding VL-300 on the branch VL-287 (#21) * merge main from features/2.0/main (#14) * generated yaml from version 2.1 * commented 'F24Metadata' schema inside yaml, due error generating models * updated 'hot-to-generate-the...md' * completed VL-295 * eslint fix * eslint fix * changed NewNotificationRequest to NewNotificationRequestV21. Now there are errors before running * changed NewNotificationRequest to NewNotificationRequestV21. Now there are errors before running * fix file with errors after using NewNotificationRequestV21 * fix file with errors after using NewNotificationRequestV21 * eslint fix * completed again VL-295 * completed again VL-295 * completed again VL-295 * still fix to do * added todo denny * first todo denny fix completed * eslint fix * fix for VL-295 due to issue in other files * eslint suggested fixes * eslint suggested fixes * fix for VL-295 w/ Cosmin * eslint fix * eslint fix * eslint fix * changing old type to the new ones * eslint fix * eslint fix * eslint fix * removed unused enum * fix accepted issue * fix tslint issues * fix tslint issue * Features/2.1/main (#12) * partial permit upload of json during uploadS3 * partial permit upload of json during uploadS3 * partial permit upload of json during uploadS3 * handled attachmentName 'F24' * completed VL-294 + fix critical severity vulnerability in package-lock.json raised by npm install command * added semicolon due to husky error * eslint fix * fix reference to delivery-push url * fix * fix imports * fix req 7 handling * fix req 7 handling * update package-lock * completed VL-296 * completed VL-296 * VL-298 completed * VL-299 completed * added collection json + 2.1 version --------- Co-authored-by: Cosmin15 <Tuduran.cosmin@gmail.com> Co-authored-by: Tuduran, Cosmin Constantin <cosminconstantin.tuduran@nttdata.com> * Features/2.1/main (#13) * partial permit upload of json during uploadS3 * partial permit upload of json during uploadS3 * partial permit upload of json during uploadS3 * handled attachmentName 'F24' * completed VL-294 + fix critical severity vulnerability in package-lock.json raised by npm install command * added semicolon due to husky error * eslint fix * fix reference to delivery-push url * fix * fix imports * fix req 7 handling * fix req 7 handling * update package-lock * completed VL-296 * completed VL-296 * VL-298 completed * VL-299 completed * added collection json + 2.1 version * update tests * fix tests * fix tests --------- Co-authored-by: Cosmin15 <Tuduran.cosmin@gmail.com> Co-authored-by: Tuduran, Cosmin Constantin <cosminconstantin.tuduran@nttdata.com> * fix tests --------- Co-authored-by: Cosmin Constantin Tuduran <cosminconstantin.tuduran@nttdata.com> Co-authored-by: Cosmin15 <Tuduran.cosmin@gmail.com> * removed fluffy comments --------- Co-authored-by: Cosmin Constantin Tuduran <cosminconstantin.tuduran@nttdata.com> Co-authored-by: Cosmin15 <Tuduran.cosmin@gmail.com> * updated yaml to version 2.0 (#23) Co-authored-by: Cosmin Constantin Tuduran <cosminconstantin.tuduran@nttdata.com> * merge features/2.0/vl 291 to features/2.0/main (#28) * Adding VL-300 to VL-291 branch (#22) * first basic code handling for notification delete * update package.json * eslint fix * added .use in application.ts * merge main from features/2.0/main (#14) * generated yaml from version 2.1 * commented 'F24Metadata' schema inside yaml, due error generating models * updated 'hot-to-generate-the...md' * completed VL-295 * eslint fix * eslint fix * changed NewNotificationRequest to NewNotificationRequestV21. Now there are errors before running * changed NewNotificationRequest to NewNotificationRequestV21. Now there are errors before running * fix file with errors after using NewNotificationRequestV21 * fix file with errors after using NewNotificationRequestV21 * eslint fix * completed again VL-295 * completed again VL-295 * completed again VL-295 * still fix to do * added todo denny * first todo denny fix completed * eslint fix * fix for VL-295 due to issue in other files * eslint suggested fixes * eslint suggested fixes * fix for VL-295 w/ Cosmin * eslint fix * eslint fix * eslint fix * changing old type to the new ones * eslint fix * eslint fix * eslint fix * removed unused enum * fix accepted issue * fix tslint issues * fix tslint issue * Features/2.1/main (#12) * partial permit upload of json during uploadS3 * partial permit upload of json during uploadS3 * partial permit upload of json during uploadS3 * handled attachmentName 'F24' * completed VL-294 + fix critical severity vulnerability in package-lock.json raised by npm install command * added semicolon due to husky error * eslint fix * fix reference to delivery-push url * fix * fix imports * fix req 7 handling * fix req 7 handling * update package-lock * completed VL-296 * completed VL-296 * VL-298 completed * VL-299 completed * added collection json + 2.1 version --------- Co-authored-by: Cosmin15 <Tuduran.cosmin@gmail.com> Co-authored-by: Tuduran, Cosmin Constantin <cosminconstantin.tuduran@nttdata.com> * Features/2.1/main (#13) * partial permit upload of json during uploadS3 * partial permit upload of json during uploadS3 * partial permit upload of json during uploadS3 * handled attachmentName 'F24' * completed VL-294 + fix critical severity vulnerability in package-lock.json raised by npm install command * added semicolon due to husky error * eslint fix * fix reference to delivery-push url * fix * fix imports * fix req 7 handling * fix req 7 handling * update package-lock * completed VL-296 * completed VL-296 * VL-298 completed * VL-299 completed * added collection json + 2.1 version * update tests * fix tests * fix tests --------- Co-authored-by: Cosmin15 <Tuduran.cosmin@gmail.com> Co-authored-by: Tuduran, Cosmin Constantin <cosminconstantin.tuduran@nttdata.com> * fix tests --------- Co-authored-by: Cosmin Constantin Tuduran <cosminconstantin.tuduran@nttdata.com> Co-authored-by: Cosmin15 <Tuduran.cosmin@gmail.com> * merge main from features/2.0/main (#14) (#15) * generated yaml from version 2.1 * commented 'F24Metadata' schema inside yaml, due error generating models * updated 'hot-to-generate-the...md' * completed VL-295 * eslint fix * eslint fix * changed NewNotificationRequest to NewNotificationRequestV21. Now there are errors before running * changed NewNotificationRequest to NewNotificationRequestV21. Now there are errors before running * fix file with errors after using NewNotificationRequestV21 * fix file with errors after using NewNotificationRequestV21 * eslint fix * completed again VL-295 * completed again VL-295 * completed again VL-295 * still fix to do * added todo denny * first todo denny fix completed * eslint fix * fix for VL-295 due to issue in other files * eslint suggested fixes * eslint suggested fixes * fix for VL-295 w/ Cosmin * eslint fix * eslint fix * eslint fix * changing old type to the new ones * eslint fix * eslint fix * eslint fix * removed unused enum * fix accepted issue * fix tslint issues * fix tslint issue * Features/2.1/main (#12) * partial permit upload of json during uploadS3 * partial permit upload of json during uploadS3 * partial permit upload of json during uploadS3 * handled attachmentName 'F24' * completed VL-294 + fix critical severity vulnerability in package-lock.json raised by npm install command * added semicolon due to husky error * eslint fix * fix reference to delivery-push url * fix * fix imports * fix req 7 handling * fix req 7 handling * update package-lock * completed VL-296 * completed VL-296 * VL-298 completed * VL-299 completed * added collection json + 2.1 version --------- * Features/2.1/main (#13) * partial permit upload of json during uploadS3 * partial permit upload of json during uploadS3 * partial permit upload of json during uploadS3 * handled attachmentName 'F24' * completed VL-294 + fix critical severity vulnerability in package-lock.json raised by npm install command * added semicolon due to husky error * eslint fix * fix reference to delivery-push url * fix * fix imports * fix req 7 handling * fix req 7 handling * update package-lock * completed VL-296 * completed VL-296 * VL-298 completed * VL-299 completed * added collection json + 2.1 version * update tests * fix tests * fix tests --------- * fix tests --------- Co-authored-by: Cosmin Constantin Tuduran <cosminconstantin.tuduran@nttdata.com> Co-authored-by: Cosmin15 <Tuduran.cosmin@gmail.com> * removed fluffy comments * removed fluffy comments --------- Co-authored-by: Cosmin Constantin Tuduran <cosminconstantin.tuduran@nttdata.com> Co-authored-by: Cosmin15 <Tuduran.cosmin@gmail.com> * eslint fix * eslint fix --------- Co-authored-by: Cosmin Constantin Tuduran <cosminconstantin.tuduran@nttdata.com> Co-authored-by: Cosmin15 <Tuduran.cosmin@gmail.com> * merge features/2.0/vl 287 to features/2.0/main (#29) * pull from main 2.0 to VL-287 branch (#24) * merge main from features/2.0/main (#14) * generated yaml from version 2.1 * commented 'F24Metadata' schema inside yaml, due error generating models * updated 'hot-to-generate-the...md' * completed VL-295 * eslint fix * eslint fix * changed NewNotificationRequest to NewNotificationRequestV21. Now there are errors before running * changed NewNotificationRequest to NewNotificationRequestV21. Now there are errors before running * fix file with errors after using NewNotificationRequestV21 * fix file with errors after using NewNotificationRequestV21 * eslint fix * completed again VL-295 * completed again VL-295 * completed again VL-295 * still fix to do * added todo denny * first todo denny fix completed * eslint fix * fix for VL-295 due to issue in other files * eslint suggested fixes * eslint suggested fixes * fix for VL-295 w/ Cosmin * eslint fix * eslint fix * eslint fix * changing old type to the new ones * eslint fix * eslint fix * eslint fix * removed unused enum * fix accepted issue * fix tslint issues * fix tslint issue * Features/2.1/main (#12) * partial permit upload of json during uploadS3 * partial permit upload of json during uploadS3 * partial permit upload of json during uploadS3 * handled attachmentName 'F24' * completed VL-294 + fix critical severity vulnerability in package-lock.json raised by npm install command * added semicolon due to husky error * eslint fix * fix reference to delivery-push url * fix * fix imports * fix req 7 handling * fix req 7 handling * update package-lock * completed VL-296 * completed VL-296 * VL-298 completed * VL-299 completed * added collection json + 2.1 version --------- Co-authored-by: Cosmin15 <Tuduran.cosmin@gmail.com> Co-authored-by: Tuduran, Cosmin Constantin <cosminconstantin.tuduran@nttdata.com> * Features/2.1/main (#13) * partial permit upload of json during uploadS3 * partial permit upload of json during uploadS3 * partial permit upload of json during uploadS3 * handled attachmentName 'F24' * completed VL-294 + fix critical severity vulnerability in package-lock.json raised by npm install command * added semicolon due to husky error * eslint fix * fix reference to delivery-push url * fix * fix imports * fix req 7 handling * fix req 7 handling * update package-lock * completed VL-296 * completed VL-296 * VL-298 completed * VL-299 completed * added collection json + 2.1 version * update tests * fix tests * fix tests --------- Co-authored-by: Cosmin15 <Tuduran.cosmin@gmail.com> Co-authored-by: Tuduran, Cosmin Constantin <cosminconstantin.tuduran@nttdata.com> * fix tests --------- Co-authored-by: Cosmin Constantin Tuduran <cosminconstantin.tuduran@nttdata.com> Co-authored-by: Cosmin15 <Tuduran.cosmin@gmail.com> * removed fluffy comments * pr update 291 (#17) * generated yaml from version 2.1 * commented 'F24Metadata' schema inside yaml, due error generating models * updated 'hot-to-generate-the...md' * completed VL-295 * eslint fix * eslint fix * changed NewNotificationRequest to NewNotificationRequestV21. Now there are errors before running * changed NewNotificationRequest to NewNotificationRequestV21. Now there are errors before running * fix file with errors after using NewNotificationRequestV21 * fix file with errors after using NewNotificationRequestV21 * eslint fix * completed again VL-295 * completed again VL-295 * completed again VL-295 * still fix to do * added todo denny * first todo denny fix completed * eslint fix * fix for VL-295 due to issue in other files * eslint suggested fixes * eslint suggested fixes * fix for VL-295 w/ Cosmin * eslint fix * eslint fix * eslint fix * changing old type to the new ones * eslint fix * eslint fix * eslint fix * removed unused enum * fix accepted issue * fix tslint issues * fix tslint issue * Features/2.1/main (#12) * partial permit upload of json during uploadS3 * partial permit upload of json during uploadS3 * partial permit upload of json during uploadS3 * handled attachmentName 'F24' * completed VL-294 + fix critical severity vulnerability in package-lock.json raised by npm install command * added semicolon due to husky error * eslint fix * fix reference to delivery-push url * fix * fix imports * fix req 7 handling * fix req 7 handling * update package-lock * completed VL-296 * completed VL-296 * VL-298 completed * VL-299 completed * added collection json + 2.1 version --------- Co-authored-by: Cosmin15 <Tuduran.cosmin@gmail.com> Co-authored-by: Tuduran, Cosmin Constantin <cosminconstantin.tuduran@nttdata.com> * Features/2.1/main (#13) * partial permit upload of json during uploadS3 * partial permit upload of json during uploadS3 * partial permit upload of json during uploadS3 * handled attachmentName 'F24' * completed VL-294 + fix critical severity vulnerability in package-lock.json raised by npm install command * added semicolon due to husky error * eslint fix * fix reference to delivery-push url * fix * fix imports * fix req 7 handling * fix req 7 handling * update package-lock * completed VL-296 * completed VL-296 * VL-298 completed * VL-299 completed * added collection json + 2.1 version * update tests * fix tests * fix tests --------- Co-authored-by: Cosmin15 <Tuduran.cosmin@gmail.com> Co-authored-by: Tuduran, Cosmin Constantin <cosminconstantin.tuduran@nttdata.com> * fix tests --------- Co-authored-by: Cosmin Constantin Tuduran <cosminconstantin.tuduran@nttdata.com> Co-authored-by: Cosmin15 <Tuduran.cosmin@gmail.com> * removed fluffy comments * completede basic behavior of 291 and 292 * eslint fix * eslint fix * basic working version of 291+292 * eslint fix * changed from manual retrieving to automatic one within map * eslint fix * updated yaml to version 2.0 (#23) Co-authored-by: Cosmin Constantin Tuduran <cosminconstantin.tuduran@nttdata.com> --------- Co-authored-by: Cosmin Constantin Tuduran <cosminconstantin.tuduran@nttdata.com> Co-authored-by: Cosmin15 <Tuduran.cosmin@gmail.com> * fix after pr with 288 * eslint fix --------- Co-authored-by: Cosmin Constantin Tuduran <cosminconstantin.tuduran@nttdata.com> Co-authored-by: Cosmin15 <Tuduran.cosmin@gmail.com> * merge features/2.0/vl 290 to features/2.0/main (#30) * pull from main 2.0 to VL-287 branch (#24) (#26) * merge main from features/2.0/main (#14) * generated yaml from version 2.1 * commented 'F24Metadata' schema inside yaml, due error generating models * updated 'hot-to-generate-the...md' * completed VL-295 * eslint fix * eslint fix * changed NewNotificationRequest to NewNotificationRequestV21. Now there are errors before running * changed NewNotificationRequest to NewNotificationRequestV21. Now there are errors before running * fix file with errors after using NewNotificationRequestV21 * fix file with errors after using NewNotificationRequestV21 * eslint fix * completed again VL-295 * completed again VL-295 * completed again VL-295 * still fix to do * added todo denny * first todo denny fix completed * eslint fix * fix for VL-295 due to issue in other files * eslint suggested fixes * eslint suggested fixes * fix for VL-295 w/ Cosmin * eslint fix * eslint fix * eslint fix * changing old type to the new ones * eslint fix * eslint fix * eslint fix * removed unused enum * fix accepted issue * fix tslint issues * fix tslint issue * Features/2.1/main (#12) * partial permit upload of json during uploadS3 * partial permit upload of json during uploadS3 * partial permit upload of json during uploadS3 * handled attachmentName 'F24' * completed VL-294 + fix critical severity vulnerability in package-lock.json raised by npm install command * added semicolon due to husky error * eslint fix * fix reference to delivery-push url * fix * fix imports * fix req 7 handling * fix req 7 handling * update package-lock * completed VL-296 * completed VL-296 * VL-298 completed * VL-299 completed * added collection json + 2.1 version --------- * Features/2.1/main (#13) * partial permit upload of json during uploadS3 * partial permit upload of json during uploadS3 * partial permit upload of json during uploadS3 * handled attachmentName 'F24' * completed VL-294 + fix critical severity vulnerability in package-lock.json raised by npm install command * added semicolon due to husky error * eslint fix * fix reference to delivery-push url * fix * fix imports * fix req 7 handling * fix req 7 handling * update package-lock * completed VL-296 * completed VL-296 * VL-298 completed * VL-299 completed * added collection json + 2.1 version * update tests * fix tests * fix tests --------- * fix tests --------- * removed fluffy comments * pr update 291 (#17) * generated yaml from version 2.1 * commented 'F24Metadata' schema inside yaml, due error generating models * updated 'hot-to-generate-the...md' * completed VL-295 * eslint fix * eslint fix * changed NewNotificationRequest to NewNotificationRequestV21. Now there are errors before running * changed NewNotificationRequest to NewNotificationRequestV21. Now there are errors before running * fix file with errors after using NewNotificationRequestV21 * fix file with errors after using NewNotificationRequestV21 * eslint fix * completed again VL-295 * completed again VL-295 * completed again VL-295 * still fix to do * added todo denny * first todo denny fix completed * eslint fix * fix for VL-295 due to issue in other files * eslint suggested fixes * eslint suggested fixes * fix for VL-295 w/ Cosmin * eslint fix * eslint fix * eslint fix * changing old type to the new ones * eslint fix * eslint fix * eslint fix * removed unused enum * fix accepted issue * fix tslint issues * fix tslint issue * Features/2.1/main (#12) * partial permit upload of json during uploadS3 * partial permit upload of json during uploadS3 * partial permit upload of json during uploadS3 * handled attachmentName 'F24' * completed VL-294 + fix critical severity vulnerability in package-lock.json raised by npm install command * added semicolon due to husky error * eslint fix * fix reference to delivery-push url * fix * fix imports * fix req 7 handling * fix req 7 handling * update package-lock * completed VL-296 * completed VL-296 * VL-298 completed * VL-299 completed * added collection json + 2.1 version --------- * Features/2.1/main (#13) * partial permit upload of json during uploadS3 * partial permit upload of json during uploadS3 * partial permit upload of json during uploadS3 * handled attachmentName 'F24' * completed VL-294 + fix critical severity vulnerability in package-lock.json raised by npm install command * added semicolon due to husky error * eslint fix * fix reference to delivery-push url * fix * fix imports * fix req 7 handling * fix req 7 handling * update package-lock * completed VL-296 * completed VL-296 * VL-298 completed * VL-299 completed * added collection json + 2.1 version * update tests * fix tests * fix tests --------- * fix tests --------- * removed fluffy comments * completede basic behavior of 291 and 292 * eslint fix * eslint fix * basic working version of 291+292 * eslint fix * changed from manual retrieving to automatic one within map * eslint fix * updated yaml to version 2.0 (#23) --------- Co-authored-by: Cosmin Constantin Tuduran <cosminconstantin.tuduran@nttdata.com> Co-authored-by: Cosmin15 <Tuduran.cosmin@gmail.com> * Pull from Features/2.0/main to VL-291 #2 (#27) * merge main from features/2.0/main (#14) * generated yaml from version 2.1 * commented 'F24Metadata' schema inside yaml, due error generating models * updated 'hot-to-generate-the...md' * completed VL-295 * eslint fix * eslint fix * changed NewNotificationRequest to NewNotificationRequestV21. Now there are errors before running * changed NewNotificationRequest to NewNotificationRequestV21. Now there are errors before running * fix file with errors after using NewNotificationRequestV21 * fix file with errors after using NewNotificationRequestV21 * eslint fix * completed again VL-295 * completed again VL-295 * completed again VL-295 * still fix to do * added todo denny * first todo denny fix completed * eslint fix * fix for VL-295 due to issue in other files * eslint suggested fixes * eslint suggested fixes * fix for VL-295 w/ Cosmin * eslint fix * eslint fix * eslint fix * changing old type to the new ones * eslint fix * eslint fix * eslint fix * removed unused enum * fix accepted issue * fix tslint issues * fix tslint issue * Features/2.1/main (#12) * partial permit upload of json during uploadS3 * partial permit upload of json during uploadS3 * partial permit upload of json during uploadS3 * handled attachmentName 'F24' * completed VL-294 + fix critical severity vulnerability in package-lock.json raised by npm install command * added semicolon due to husky error * eslint fix * fix reference to delivery-push url * fix * fix imports * fix req 7 handling * fix req 7 handling * update package-lock * completed VL-296 * completed VL-296 * VL-298 completed * VL-299 completed * added collection json + 2.1 version --------- Co-authored-by: Cosmin15 <Tuduran.cosmin@gmail.com> Co-authored-by: Tuduran, Cosmin Constantin <cosminconstantin.tuduran@nttdata.com> * Features/2.1/main (#13) * partial permit upload of json during uploadS3 * partial permit upload of json during uploadS3 * partial permit upload of json during uploadS3 * handled attachmentName 'F24' * completed VL-294 + fix critical severity vulnerability in package-lock.json raised by npm install command * added semicolon due to husky error * eslint fix * fix reference to delivery-push url * fix * fix imports * fix req 7 handling * fix req 7 handling * update package-lock * completed VL-296 * completed VL-296 * VL-298 completed * VL-299 completed * added collection json + 2.1 version * update tests * fix tests * fix tests --------- Co-authored-by: Cosmin15 <Tuduran.cosmin@gmail.com> Co-authored-by: Tuduran, Cosmin Constantin <cosminconstantin.tuduran@nttdata.com> * fix tests --------- Co-authored-by: Cosmin Constantin Tuduran <cosminconstantin.tuduran@nttdata.com> Co-authored-by: Cosmin15 <Tuduran.cosmin@gmail.com> * removed fluffy comments * pr update 291 (#17) * generated yaml from version 2.1 * commented 'F24Metadata' schema inside yaml, due error generating models * updated 'hot-to-generate-the...md' * completed VL-295 * eslint fix * eslint fix * changed NewNotificationRequest to NewNotificationRequestV21. Now there are errors before running * changed NewNotificationRequest to NewNotificationRequestV21. Now there are errors before running * fix file with errors after using NewNotificationRequestV21 * fix file with errors after using NewNotificationRequestV21 * eslint fix * completed again VL-295 * completed again VL-295 * completed again VL-295 * still fix to do * added todo denny * first todo denny fix completed * eslint fix * fix for VL-295 due to issue in other files * eslint suggested fixes * eslint suggested fixes * fix for VL-295 w/ Cosmin * eslint fix * eslint fix * eslint fix * changing old type to the new ones * eslint fix * eslint fix * eslint fix * removed unused enum * fix accepted issue * fix tslint issues * fix tslint issue * Features/2.1/main (#12) * partial permit upload of json during uploadS3 * partial permit upload of json during uploadS3 * partial permit upload of json during uploadS3 * handled attachmentName 'F24' * completed VL-294 + fix critical severity vulnerability in package-lock.json raised by npm install command * added semicolon due to husky error * eslint fix * fix reference to delivery-push url * fix * fix imports * fix req 7 handling * fix req 7 handling * update package-lock * completed VL-296 * completed VL-296 * VL-298 completed * VL-299 completed * added collection json + 2.1 version --------- Co-authored-by: Cosmin15 <Tuduran.cosmin@gmail.com> Co-authored-by: Tuduran, Cosmin Constantin <cosminconstantin.tuduran@nttdata.com> * Features/2.1/main (#13) * partial permit upload of json during uploadS3 * partial permit upload of json during uploadS3 * partial permit upload of json during uploadS3 * handled attachmentName 'F24' * completed VL-294 + fix critical severity vulnerability in package-lock.json raised by npm install command * added semicolon due to husky error * eslint fix * fix reference to delivery-push url * fix * fix imports * fix req 7 handling * fix req 7 handling * update package-lock * completed VL-296 * completed VL-296 * VL-298 completed * VL-299 completed * added collection json + 2.1 version * update tests * fix tests * fix tests --------- Co-authored-by: Cosmin15 <Tuduran.cosmin@gmail.com> Co-authored-by: Tuduran, Cosmin Constantin <cosminconstantin.tuduran@nttdata.com> * fix tests --------- Co-authored-by: Cosmin Constantin Tuduran <cosminconstantin.tuduran@nttdata.com> Co-authored-by: Cosmin15 <Tuduran.cosmin@gmail.com> * removed fluffy comments * completede basic behavior of 291 and 292 * eslint fix * eslint fix * basic working version of 291+292 * eslint fix * changed from manual retrieving to automatic one within map * eslint fix * updated yaml to version 2.0 (#23) Co-authored-by: Cosmin Constantin Tuduran <cosminconstantin.tuduran@nttdata.com> --------- Co-authored-by: Cosmin Constantin Tuduran <cosminconstantin.tuduran@nttdata.com> Co-authored-by: Cosmin15 <Tuduran.cosmin@gmail.com> * fix after VL-288 merge * completed VL-290 * eslint fix * eslint fix * eslint fix --------- Co-authored-by: Cosmin Constantin Tuduran <cosminconstantin.tuduran@nttdata.com> Co-authored-by: Cosmin15 <Tuduran.cosmin@gmail.com> * update index.ts * eslint fix * general fixes for version 2.0 * eslint fix * eslint fix * eslint fix * from main to main/2.0 (#32) (#33) * final fix for main * eslint fix * fix for duplicated timeline event * fix for duplicated timeline event * update postman collection * disabled a test * code duplication fix * fix for code duplication #2 * eslint fix * update to 2.1.1 version * fix for undefined values output obj * eslint fix * completed VL-302 * update package-lock.version --------- Co-authored-by: Cosmin Constantin Tuduran <cosminconstantin.tuduran@nttdata.com> Co-authored-by: Cosmin15 <Tuduran.cosmin@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of Changes
Change the endpoint
Upload S3, thex-amz-sdk-checksum-algorithmheader parameter is no longer required.Motivation and Context
The
x-amz-sdk-checksum-algorithmheader parameter onUpload S3endpoint should not be required.Types of changes
Checklist: