Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VL-59 Return also the key within the base URL #22

Merged
merged 2 commits into from
Sep 1, 2022

Conversation

datalek
Copy link
Contributor

@datalek datalek commented Aug 31, 2022

Motivation and Context

The response of Request an “upload slot“ endpoint should be something like the following:

[
  {
    "preloadIdx":"1",
    "httpMethod":"PUT",
    "secret":"b3dd0b61-e22a-4f79-b808-1bb8ea9dae2c",
    "url":"http://127.0.0.1:8080/uploadS3/key1",
    "key":"key1"
  }
]

but now the url retuned doesn’t contain the key:

[
  {
    "preloadIdx":"1",
    "httpMethod":"PUT",
    "secret":"b3dd0b61-e22a-4f79-b808-1bb8ea9dae2c",
    "url":"http://127.0.0.1:8080/uploadS3",
    "key":"key1"
  }
]

How Has This Been Tested?

Unit test

Types of changes

  • Chore (nothing changes by a user perspective)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@datalek datalek requested a review from kin0992 as a code owner August 31, 2022 15:46
@datalek datalek requested a review from kin0992 September 1, 2022 07:45
@datalek datalek changed the title Return also the key within the base URL VL-59 Return also the key within the base URL Sep 1, 2022
Copy link
Contributor

@kin0992 kin0992 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦺

@datalek datalek merged commit 946399c into main Sep 1, 2022
@datalek datalek deleted the hotfixes/request-upload-slot branch September 1, 2022 08:16
dennycarusonttdata added a commit that referenced this pull request Feb 1, 2024
* generated yaml from version 2.1

* commented 'F24Metadata' schema inside yaml, due error generating models

* updated 'hot-to-generate-the...md'

* completed VL-295

* eslint fix

* eslint fix

* changed NewNotificationRequest to NewNotificationRequestV21. Now there are errors before running

* changed NewNotificationRequest to NewNotificationRequestV21. Now there are errors before running

* fix file with errors after using NewNotificationRequestV21

* fix file with errors after using NewNotificationRequestV21

* eslint fix

* completed again VL-295

* completed again VL-295

* completed again VL-295

* still fix to do

* added todo denny

* first todo denny fix completed

* eslint fix

* fix for VL-295 due to issue in other files

* eslint suggested fixes

* eslint suggested fixes

* fix for VL-295 w/ Cosmin

* eslint fix

* eslint fix

* eslint fix

* changing old type to the new ones

* eslint fix

* eslint fix

* eslint fix

* removed unused enum

* fix accepted issue

* fix tslint issues

* fix tslint issue

* Features/2.1/main (#12)

* partial permit upload of json during uploadS3

* partial permit upload of json during uploadS3

* partial permit upload of json during uploadS3

* handled attachmentName 'F24'

* completed VL-294 + fix critical severity vulnerability in package-lock.json raised by npm install command

* added semicolon due to husky error

* eslint fix

* fix reference to delivery-push url

* fix

* fix imports

* fix req 7 handling

* fix req 7 handling

* update package-lock

* completed VL-296

* completed VL-296

* VL-298 completed

* VL-299 completed

* added collection json + 2.1 version

---------

Co-authored-by: Cosmin15 <Tuduran.cosmin@gmail.com>
Co-authored-by: Tuduran, Cosmin Constantin <cosminconstantin.tuduran@nttdata.com>

* Features/2.1/main (#13)

* partial permit upload of json during uploadS3

* partial permit upload of json during uploadS3

* partial permit upload of json during uploadS3

* handled attachmentName 'F24'

* completed VL-294 + fix critical severity vulnerability in package-lock.json raised by npm install command

* added semicolon due to husky error

* eslint fix

* fix reference to delivery-push url

* fix

* fix imports

* fix req 7 handling

* fix req 7 handling

* update package-lock

* completed VL-296

* completed VL-296

* VL-298 completed

* VL-299 completed

* added collection json + 2.1 version

* update tests

* fix tests

* fix tests

---------

Co-authored-by: Cosmin15 <Tuduran.cosmin@gmail.com>
Co-authored-by: Tuduran, Cosmin Constantin <cosminconstantin.tuduran@nttdata.com>

* fix tests

* first basic code handling for notification delete

* update package.json

* eslint fix

* added .use in application.ts

* merge main from features/2.0/main (#14)

* generated yaml from version 2.1

* commented 'F24Metadata' schema inside yaml, due error generating models

* updated 'hot-to-generate-the...md'

* completed VL-295

* eslint fix

* eslint fix

* changed NewNotificationRequest to NewNotificationRequestV21. Now there are errors before running

* changed NewNotificationRequest to NewNotificationRequestV21. Now there are errors before running

* fix file with errors after using NewNotificationRequestV21

* fix file with errors after using NewNotificationRequestV21

* eslint fix

* completed again VL-295

* completed again VL-295

* completed again VL-295

* still fix to do

* added todo denny

* first todo denny fix completed

* eslint fix

* fix for VL-295 due to issue in other files

* eslint suggested fixes

* eslint suggested fixes

* fix for VL-295 w/ Cosmin

* eslint fix

* eslint fix

* eslint fix

* changing old type to the new ones

* eslint fix

* eslint fix

* eslint fix

* removed unused enum

* fix accepted issue

* fix tslint issues

* fix tslint issue

* Features/2.1/main (#12)

* partial permit upload of json during uploadS3

* partial permit upload of json during uploadS3

* partial permit upload of json during uploadS3

* handled attachmentName 'F24'

* completed VL-294 + fix critical severity vulnerability in package-lock.json raised by npm install command

* added semicolon due to husky error

* eslint fix

* fix reference to delivery-push url

* fix

* fix imports

* fix req 7 handling

* fix req 7 handling

* update package-lock

* completed VL-296

* completed VL-296

* VL-298 completed

* VL-299 completed

* added collection json + 2.1 version

---------

Co-authored-by: Cosmin15 <Tuduran.cosmin@gmail.com>
Co-authored-by: Tuduran, Cosmin Constantin <cosminconstantin.tuduran@nttdata.com>

* Features/2.1/main (#13)

* partial permit upload of json during uploadS3

* partial permit upload of json during uploadS3

* partial permit upload of json during uploadS3

* handled attachmentName 'F24'

* completed VL-294 + fix critical severity vulnerability in package-lock.json raised by npm install command

* added semicolon due to husky error

* eslint fix

* fix reference to delivery-push url

* fix

* fix imports

* fix req 7 handling

* fix req 7 handling

* update package-lock

* completed VL-296

* completed VL-296

* VL-298 completed

* VL-299 completed

* added collection json + 2.1 version

* update tests

* fix tests

* fix tests

---------

Co-authored-by: Cosmin15 <Tuduran.cosmin@gmail.com>
Co-authored-by: Tuduran, Cosmin Constantin <cosminconstantin.tuduran@nttdata.com>

* fix tests

---------

Co-authored-by: Cosmin Constantin Tuduran <cosminconstantin.tuduran@nttdata.com>
Co-authored-by: Cosmin15 <Tuduran.cosmin@gmail.com>

* merge main from features/2.0/main (#14) (#15)

* generated yaml from version 2.1

* commented 'F24Metadata' schema inside yaml, due error generating models

* updated 'hot-to-generate-the...md'

* completed VL-295

* eslint fix

* eslint fix

* changed NewNotificationRequest to NewNotificationRequestV21. Now there are errors before running

* changed NewNotificationRequest to NewNotificationRequestV21. Now there are errors before running

* fix file with errors after using NewNotificationRequestV21

* fix file with errors after using NewNotificationRequestV21

* eslint fix

* completed again VL-295

* completed again VL-295

* completed again VL-295

* still fix to do

* added todo denny

* first todo denny fix completed

* eslint fix

* fix for VL-295 due to issue in other files

* eslint suggested fixes

* eslint suggested fixes

* fix for VL-295 w/ Cosmin

* eslint fix

* eslint fix

* eslint fix

* changing old type to the new ones

* eslint fix

* eslint fix

* eslint fix

* removed unused enum

* fix accepted issue

* fix tslint issues

* fix tslint issue

* Features/2.1/main (#12)

* partial permit upload of json during uploadS3

* partial permit upload of json during uploadS3

* partial permit upload of json during uploadS3

* handled attachmentName 'F24'

* completed VL-294 + fix critical severity vulnerability in package-lock.json raised by npm install command

* added semicolon due to husky error

* eslint fix

* fix reference to delivery-push url

* fix

* fix imports

* fix req 7 handling

* fix req 7 handling

* update package-lock

* completed VL-296

* completed VL-296

* VL-298 completed

* VL-299 completed

* added collection json + 2.1 version

---------




* Features/2.1/main (#13)

* partial permit upload of json during uploadS3

* partial permit upload of json during uploadS3

* partial permit upload of json during uploadS3

* handled attachmentName 'F24'

* completed VL-294 + fix critical severity vulnerability in package-lock.json raised by npm install command

* added semicolon due to husky error

* eslint fix

* fix reference to delivery-push url

* fix

* fix imports

* fix req 7 handling

* fix req 7 handling

* update package-lock

* completed VL-296

* completed VL-296

* VL-298 completed

* VL-299 completed

* added collection json + 2.1 version

* update tests

* fix tests

* fix tests

---------




* fix tests

---------

Co-authored-by: Cosmin Constantin Tuduran <cosminconstantin.tuduran@nttdata.com>
Co-authored-by: Cosmin15 <Tuduran.cosmin@gmail.com>

* removed fluffy comments

* removed fluffy comments

* Features/2.0/main (#16)

* merge main from features/2.0/main (#14)

* generated yaml from version 2.1

* commented 'F24Metadata' schema inside yaml, due error generating models

* updated 'hot-to-generate-the...md'

* completed VL-295

* eslint fix

* eslint fix

* changed NewNotificationRequest to NewNotificationRequestV21. Now there are errors before running

* changed NewNotificationRequest to NewNotificationRequestV21. Now there are errors before running

* fix file with errors after using NewNotificationRequestV21

* fix file with errors after using NewNotificationRequestV21

* eslint fix

* completed again VL-295

* completed again VL-295

* completed again VL-295

* still fix to do

* added todo denny

* first todo denny fix completed

* eslint fix

* fix for VL-295 due to issue in other files

* eslint suggested fixes

* eslint suggested fixes

* fix for VL-295 w/ Cosmin

* eslint fix

* eslint fix

* eslint fix

* changing old type to the new ones

* eslint fix

* eslint fix

* eslint fix

* removed unused enum

* fix accepted issue

* fix tslint issues

* fix tslint issue

* Features/2.1/main (#12)

* partial permit upload of json during uploadS3

* partial permit upload of json during uploadS3

* partial permit upload of json during uploadS3

* handled attachmentName 'F24'

* completed VL-294 + fix critical severity vulnerability in package-lock.json raised by npm install command

* added semicolon due to husky error

* eslint fix

* fix reference to delivery-push url

* fix

* fix imports

* fix req 7 handling

* fix req 7 handling

* update package-lock

* completed VL-296

* completed VL-296

* VL-298 completed

* VL-299 completed

* added collection json + 2.1 version

---------

Co-authored-by: Cosmin15 <Tuduran.cosmin@gmail.com>
Co-authored-by: Tuduran, Cosmin Constantin <cosminconstantin.tuduran@nttdata.com>

* Features/2.1/main (#13)

* partial permit upload of json during uploadS3

* partial permit upload of json during uploadS3

* partial permit upload of json during uploadS3

* handled attachmentName 'F24'

* completed VL-294 + fix critical severity vulnerability in package-lock.json raised by npm install command

* added semicolon due to husky error

* eslint fix

* fix reference to delivery-push url

* fix

* fix imports

* fix req 7 handling

* fix req 7 handling

* update package-lock

* completed VL-296

* completed VL-296

* VL-298 completed

* VL-299 completed

* added collection json + 2.1 version

* update tests

* fix tests

* fix tests

---------

Co-authored-by: Cosmin15 <Tuduran.cosmin@gmail.com>
Co-authored-by: Tuduran, Cosmin Constantin <cosminconstantin.tuduran@nttdata.com>

* fix tests

---------

Co-authored-by: Cosmin Constantin Tuduran <cosminconstantin.tuduran@nttdata.com>
Co-authored-by: Cosmin15 <Tuduran.cosmin@gmail.com>

* removed fluffy comments

---------

Co-authored-by: Cosmin Constantin Tuduran <cosminconstantin.tuduran@nttdata.com>
Co-authored-by: Cosmin15 <Tuduran.cosmin@gmail.com>

* pr update 291 (#17)

* generated yaml from version 2.1

* commented 'F24Metadata' schema inside yaml, due error generating models

* updated 'hot-to-generate-the...md'

* completed VL-295

* eslint fix

* eslint fix

* changed NewNotificationRequest to NewNotificationRequestV21. Now there are errors before running

* changed NewNotificationRequest to NewNotificationRequestV21. Now there are errors before running

* fix file with errors after using NewNotificationRequestV21

* fix file with errors after using NewNotificationRequestV21

* eslint fix

* completed again VL-295

* completed again VL-295

* completed again VL-295

* still fix to do

* added todo denny

* first todo denny fix completed

* eslint fix

* fix for VL-295 due to issue in other files

* eslint suggested fixes

* eslint suggested fixes

* fix for VL-295 w/ Cosmin

* eslint fix

* eslint fix

* eslint fix

* changing old type to the new ones

* eslint fix

* eslint fix

* eslint fix

* removed unused enum

* fix accepted issue

* fix tslint issues

* fix tslint issue

* Features/2.1/main (#12)

* partial permit upload of json during uploadS3

* partial permit upload of json during uploadS3

* partial permit upload of json during uploadS3

* handled attachmentName 'F24'

* completed VL-294 + fix critical severity vulnerability in package-lock.json raised by npm install command

* added semicolon due to husky error

* eslint fix

* fix reference to delivery-push url

* fix

* fix imports

* fix req 7 handling

* fix req 7 handling

* update package-lock

* completed VL-296

* completed VL-296

* VL-298 completed

* VL-299 completed

* added collection json + 2.1 version

---------

Co-authored-by: Cosmin15 <Tuduran.cosmin@gmail.com>
Co-authored-by: Tuduran, Cosmin Constantin <cosminconstantin.tuduran@nttdata.com>

* Features/2.1/main (#13)

* partial permit upload of json during uploadS3

* partial permit upload of json during uploadS3

* partial permit upload of json during uploadS3

* handled attachmentName 'F24'

* completed VL-294 + fix critical severity vulnerability in package-lock.json raised by npm install command

* added semicolon due to husky error

* eslint fix

* fix reference to delivery-push url

* fix

* fix imports

* fix req 7 handling

* fix req 7 handling

* update package-lock

* completed VL-296

* completed VL-296

* VL-298 completed

* VL-299 completed

* added collection json + 2.1 version

* update tests

* fix tests

* fix tests

---------

Co-authored-by: Cosmin15 <Tuduran.cosmin@gmail.com>
Co-authored-by: Tuduran, Cosmin Constantin <cosminconstantin.tuduran@nttdata.com>

* fix tests

---------

Co-authored-by: Cosmin Constantin Tuduran <cosminconstantin.tuduran@nttdata.com>
Co-authored-by: Cosmin15 <Tuduran.cosmin@gmail.com>

* removed fluffy comments

* completede basic behavior of 291 and 292

* eslint fix

* eslint fix

* update from del to put endpoint

* basic working version of 291+292

* eslint fix

* update import statements + remove pnstram generate

* eslint fix

* update v2.0 endpoint url to v2.1

* adding basic code

* adding basic code

* eslint fix

* changed from manual retrieving to automatic one within map

* eslint fix

* Feature/VL-300 (#19)

* VL-300 - removed legalFactType path param from api

* solved error unmatching types

* eslint fix

* eslint fix

* completed VL-287

* eslint fix

* eslint fix

* Adding VL-300 on the branch VL-287 (#21)

* merge main from features/2.0/main (#14)

* generated yaml from version 2.1

* commented 'F24Metadata' schema inside yaml, due error generating models

* updated 'hot-to-generate-the...md'

* completed VL-295

* eslint fix

* eslint fix

* changed NewNotificationRequest to NewNotificationRequestV21. Now there are errors before running

* changed NewNotificationRequest to NewNotificationRequestV21. Now there are errors before running

* fix file with errors after using NewNotificationRequestV21

* fix file with errors after using NewNotificationRequestV21

* eslint fix

* completed again VL-295

* completed again VL-295

* completed again VL-295

* still fix to do

* added todo denny

* first todo denny fix completed

* eslint fix

* fix for VL-295 due to issue in other files

* eslint suggested fixes

* eslint suggested fixes

* fix for VL-295 w/ Cosmin

* eslint fix

* eslint fix

* eslint fix

* changing old type to the new ones

* eslint fix

* eslint fix

* eslint fix

* removed unused enum

* fix accepted issue

* fix tslint issues

* fix tslint issue

* Features/2.1/main (#12)

* partial permit upload of json during uploadS3

* partial permit upload of json during uploadS3

* partial permit upload of json during uploadS3

* handled attachmentName 'F24'

* completed VL-294 + fix critical severity vulnerability in package-lock.json raised by npm install command

* added semicolon due to husky error

* eslint fix

* fix reference to delivery-push url

* fix

* fix imports

* fix req 7 handling

* fix req 7 handling

* update package-lock

* completed VL-296

* completed VL-296

* VL-298 completed

* VL-299 completed

* added collection json + 2.1 version

---------

Co-authored-by: Cosmin15 <Tuduran.cosmin@gmail.com>
Co-authored-by: Tuduran, Cosmin Constantin <cosminconstantin.tuduran@nttdata.com>

* Features/2.1/main (#13)

* partial permit upload of json during uploadS3

* partial permit upload of json during uploadS3

* partial permit upload of json during uploadS3

* handled attachmentName 'F24'

* completed VL-294 + fix critical severity vulnerability in package-lock.json raised by npm install command

* added semicolon due to husky error

* eslint fix

* fix reference to delivery-push url

* fix

* fix imports

* fix req 7 handling

* fix req 7 handling

* update package-lock

* completed VL-296

* completed VL-296

* VL-298 completed

* VL-299 completed

* added collection json + 2.1 version

* update tests

* fix tests

* fix tests

---------

Co-authored-by: Cosmin15 <Tuduran.cosmin@gmail.com>
Co-authored-by: Tuduran, Cosmin Constantin <cosminconstantin.tuduran@nttdata.com>

* fix tests

---------

Co-authored-by: Cosmin Constantin Tuduran <cosminconstantin.tuduran@nttdata.com>
Co-authored-by: Cosmin15 <Tuduran.cosmin@gmail.com>

* removed fluffy comments

---------

Co-authored-by: Cosmin Constantin Tuduran <cosminconstantin.tuduran@nttdata.com>
Co-authored-by: Cosmin15 <Tuduran.cosmin@gmail.com>

* updated yaml to version 2.0 (#23)

Co-authored-by: Cosmin Constantin Tuduran <cosminconstantin.tuduran@nttdata.com>

* merge features/2.0/vl 291 to features/2.0/main (#28)

* Adding VL-300 to VL-291 branch (#22)

* first basic code handling for notification delete

* update package.json

* eslint fix

* added .use in application.ts

* merge main from features/2.0/main (#14)

* generated yaml from version 2.1

* commented 'F24Metadata' schema inside yaml, due error generating models

* updated 'hot-to-generate-the...md'

* completed VL-295

* eslint fix

* eslint fix

* changed NewNotificationRequest to NewNotificationRequestV21. Now there are errors before running

* changed NewNotificationRequest to NewNotificationRequestV21. Now there are errors before running

* fix file with errors after using NewNotificationRequestV21

* fix file with errors after using NewNotificationRequestV21

* eslint fix

* completed again VL-295

* completed again VL-295

* completed again VL-295

* still fix to do

* added todo denny

* first todo denny fix completed

* eslint fix

* fix for VL-295 due to issue in other files

* eslint suggested fixes

* eslint suggested fixes

* fix for VL-295 w/ Cosmin

* eslint fix

* eslint fix

* eslint fix

* changing old type to the new ones

* eslint fix

* eslint fix

* eslint fix

* removed unused enum

* fix accepted issue

* fix tslint issues

* fix tslint issue

* Features/2.1/main (#12)

* partial permit upload of json during uploadS3

* partial permit upload of json during uploadS3

* partial permit upload of json during uploadS3

* handled attachmentName 'F24'

* completed VL-294 + fix critical severity vulnerability in package-lock.json raised by npm install command

* added semicolon due to husky error

* eslint fix

* fix reference to delivery-push url

* fix

* fix imports

* fix req 7 handling

* fix req 7 handling

* update package-lock

* completed VL-296

* completed VL-296

* VL-298 completed

* VL-299 completed

* added collection json + 2.1 version

---------

Co-authored-by: Cosmin15 <Tuduran.cosmin@gmail.com>
Co-authored-by: Tuduran, Cosmin Constantin <cosminconstantin.tuduran@nttdata.com>

* Features/2.1/main (#13)

* partial permit upload of json during uploadS3

* partial permit upload of json during uploadS3

* partial permit upload of json during uploadS3

* handled attachmentName 'F24'

* completed VL-294 + fix critical severity vulnerability in package-lock.json raised by npm install command

* added semicolon due to husky error

* eslint fix

* fix reference to delivery-push url

* fix

* fix imports

* fix req 7 handling

* fix req 7 handling

* update package-lock

* completed VL-296

* completed VL-296

* VL-298 completed

* VL-299 completed

* added collection json + 2.1 version

* update tests

* fix tests

* fix tests

---------

Co-authored-by: Cosmin15 <Tuduran.cosmin@gmail.com>
Co-authored-by: Tuduran, Cosmin Constantin <cosminconstantin.tuduran@nttdata.com>

* fix tests

---------

Co-authored-by: Cosmin Constantin Tuduran <cosminconstantin.tuduran@nttdata.com>
Co-authored-by: Cosmin15 <Tuduran.cosmin@gmail.com>

* merge main from features/2.0/main (#14) (#15)

* generated yaml from version 2.1

* commented 'F24Metadata' schema inside yaml, due error generating models

* updated 'hot-to-generate-the...md'

* completed VL-295

* eslint fix

* eslint fix

* changed NewNotificationRequest to NewNotificationRequestV21. Now there are errors before running

* changed NewNotificationRequest to NewNotificationRequestV21. Now there are errors before running

* fix file with errors after using NewNotificationRequestV21

* fix file with errors after using NewNotificationRequestV21

* eslint fix

* completed again VL-295

* completed again VL-295

* completed again VL-295

* still fix to do

* added todo denny

* first todo denny fix completed

* eslint fix

* fix for VL-295 due to issue in other files

* eslint suggested fixes

* eslint suggested fixes

* fix for VL-295 w/ Cosmin

* eslint fix

* eslint fix

* eslint fix

* changing old type to the new ones

* eslint fix

* eslint fix

* eslint fix

* removed unused enum

* fix accepted issue

* fix tslint issues

* fix tslint issue

* Features/2.1/main (#12)

* partial permit upload of json during uploadS3

* partial permit upload of json during uploadS3

* partial permit upload of json during uploadS3

* handled attachmentName 'F24'

* completed VL-294 + fix critical severity vulnerability in package-lock.json raised by npm install command

* added semicolon due to husky error

* eslint fix

* fix reference to delivery-push url

* fix

* fix imports

* fix req 7 handling

* fix req 7 handling

* update package-lock

* completed VL-296

* completed VL-296

* VL-298 completed

* VL-299 completed

* added collection json + 2.1 version

---------




* Features/2.1/main (#13)

* partial permit upload of json during uploadS3

* partial permit upload of json during uploadS3

* partial permit upload of json during uploadS3

* handled attachmentName 'F24'

* completed VL-294 + fix critical severity vulnerability in package-lock.json raised by npm install command

* added semicolon due to husky error

* eslint fix

* fix reference to delivery-push url

* fix

* fix imports

* fix req 7 handling

* fix req 7 handling

* update package-lock

* completed VL-296

* completed VL-296

* VL-298 completed

* VL-299 completed

* added collection json + 2.1 version

* update tests

* fix tests

* fix tests

---------




* fix tests

---------

Co-authored-by: Cosmin Constantin Tuduran <cosminconstantin.tuduran@nttdata.com>
Co-authored-by: Cosmin15 <Tuduran.cosmin@gmail.com>

* removed fluffy comments

* removed fluffy comments

---------

Co-authored-by: Cosmin Constantin Tuduran <cosminconstantin.tuduran@nttdata.com>
Co-authored-by: Cosmin15 <Tuduran.cosmin@gmail.com>

* eslint fix

* eslint fix

---------

Co-authored-by: Cosmin Constantin Tuduran <cosminconstantin.tuduran@nttdata.com>
Co-authored-by: Cosmin15 <Tuduran.cosmin@gmail.com>

* merge features/2.0/vl 287 to features/2.0/main (#29)

* pull from main 2.0 to VL-287 branch (#24)

* merge main from features/2.0/main (#14)

* generated yaml from version 2.1

* commented 'F24Metadata' schema inside yaml, due error generating models

* updated 'hot-to-generate-the...md'

* completed VL-295

* eslint fix

* eslint fix

* changed NewNotificationRequest to NewNotificationRequestV21. Now there are errors before running

* changed NewNotificationRequest to NewNotificationRequestV21. Now there are errors before running

* fix file with errors after using NewNotificationRequestV21

* fix file with errors after using NewNotificationRequestV21

* eslint fix

* completed again VL-295

* completed again VL-295

* completed again VL-295

* still fix to do

* added todo denny

* first todo denny fix completed

* eslint fix

* fix for VL-295 due to issue in other files

* eslint suggested fixes

* eslint suggested fixes

* fix for VL-295 w/ Cosmin

* eslint fix

* eslint fix

* eslint fix

* changing old type to the new ones

* eslint fix

* eslint fix

* eslint fix

* removed unused enum

* fix accepted issue

* fix tslint issues

* fix tslint issue

* Features/2.1/main (#12)

* partial permit upload of json during uploadS3

* partial permit upload of json during uploadS3

* partial permit upload of json during uploadS3

* handled attachmentName 'F24'

* completed VL-294 + fix critical severity vulnerability in package-lock.json raised by npm install command

* added semicolon due to husky error

* eslint fix

* fix reference to delivery-push url

* fix

* fix imports

* fix req 7 handling

* fix req 7 handling

* update package-lock

* completed VL-296

* completed VL-296

* VL-298 completed

* VL-299 completed

* added collection json + 2.1 version

---------

Co-authored-by: Cosmin15 <Tuduran.cosmin@gmail.com>
Co-authored-by: Tuduran, Cosmin Constantin <cosminconstantin.tuduran@nttdata.com>

* Features/2.1/main (#13)

* partial permit upload of json during uploadS3

* partial permit upload of json during uploadS3

* partial permit upload of json during uploadS3

* handled attachmentName 'F24'

* completed VL-294 + fix critical severity vulnerability in package-lock.json raised by npm install command

* added semicolon due to husky error

* eslint fix

* fix reference to delivery-push url

* fix

* fix imports

* fix req 7 handling

* fix req 7 handling

* update package-lock

* completed VL-296

* completed VL-296

* VL-298 completed

* VL-299 completed

* added collection json + 2.1 version

* update tests

* fix tests

* fix tests

---------

Co-authored-by: Cosmin15 <Tuduran.cosmin@gmail.com>
Co-authored-by: Tuduran, Cosmin Constantin <cosminconstantin.tuduran@nttdata.com>

* fix tests

---------

Co-authored-by: Cosmin Constantin Tuduran <cosminconstantin.tuduran@nttdata.com>
Co-authored-by: Cosmin15 <Tuduran.cosmin@gmail.com>

* removed fluffy comments

* pr update 291 (#17)

* generated yaml from version 2.1

* commented 'F24Metadata' schema inside yaml, due error generating models

* updated 'hot-to-generate-the...md'

* completed VL-295

* eslint fix

* eslint fix

* changed NewNotificationRequest to NewNotificationRequestV21. Now there are errors before running

* changed NewNotificationRequest to NewNotificationRequestV21. Now there are errors before running

* fix file with errors after using NewNotificationRequestV21

* fix file with errors after using NewNotificationRequestV21

* eslint fix

* completed again VL-295

* completed again VL-295

* completed again VL-295

* still fix to do

* added todo denny

* first todo denny fix completed

* eslint fix

* fix for VL-295 due to issue in other files

* eslint suggested fixes

* eslint suggested fixes

* fix for VL-295 w/ Cosmin

* eslint fix

* eslint fix

* eslint fix

* changing old type to the new ones

* eslint fix

* eslint fix

* eslint fix

* removed unused enum

* fix accepted issue

* fix tslint issues

* fix tslint issue

* Features/2.1/main (#12)

* partial permit upload of json during uploadS3

* partial permit upload of json during uploadS3

* partial permit upload of json during uploadS3

* handled attachmentName 'F24'

* completed VL-294 + fix critical severity vulnerability in package-lock.json raised by npm install command

* added semicolon due to husky error

* eslint fix

* fix reference to delivery-push url

* fix

* fix imports

* fix req 7 handling

* fix req 7 handling

* update package-lock

* completed VL-296

* completed VL-296

* VL-298 completed

* VL-299 completed

* added collection json + 2.1 version

---------

Co-authored-by: Cosmin15 <Tuduran.cosmin@gmail.com>
Co-authored-by: Tuduran, Cosmin Constantin <cosminconstantin.tuduran@nttdata.com>

* Features/2.1/main (#13)

* partial permit upload of json during uploadS3

* partial permit upload of json during uploadS3

* partial permit upload of json during uploadS3

* handled attachmentName 'F24'

* completed VL-294 + fix critical severity vulnerability in package-lock.json raised by npm install command

* added semicolon due to husky error

* eslint fix

* fix reference to delivery-push url

* fix

* fix imports

* fix req 7 handling

* fix req 7 handling

* update package-lock

* completed VL-296

* completed VL-296

* VL-298 completed

* VL-299 completed

* added collection json + 2.1 version

* update tests

* fix tests

* fix tests

---------

Co-authored-by: Cosmin15 <Tuduran.cosmin@gmail.com>
Co-authored-by: Tuduran, Cosmin Constantin <cosminconstantin.tuduran@nttdata.com>

* fix tests

---------

Co-authored-by: Cosmin Constantin Tuduran <cosminconstantin.tuduran@nttdata.com>
Co-authored-by: Cosmin15 <Tuduran.cosmin@gmail.com>

* removed fluffy comments

* completede basic behavior of 291 and 292

* eslint fix

* eslint fix

* basic working version of 291+292

* eslint fix

* changed from manual retrieving to automatic one within map

* eslint fix

* updated yaml to version 2.0 (#23)

Co-authored-by: Cosmin Constantin Tuduran <cosminconstantin.tuduran@nttdata.com>

---------

Co-authored-by: Cosmin Constantin Tuduran <cosminconstantin.tuduran@nttdata.com>
Co-authored-by: Cosmin15 <Tuduran.cosmin@gmail.com>

* fix after pr with 288

* eslint fix

---------

Co-authored-by: Cosmin Constantin Tuduran <cosminconstantin.tuduran@nttdata.com>
Co-authored-by: Cosmin15 <Tuduran.cosmin@gmail.com>

* merge features/2.0/vl 290 to features/2.0/main (#30)

* pull from main 2.0 to VL-287 branch (#24) (#26)

* merge main from features/2.0/main (#14)

* generated yaml from version 2.1

* commented 'F24Metadata' schema inside yaml, due error generating models

* updated 'hot-to-generate-the...md'

* completed VL-295

* eslint fix

* eslint fix

* changed NewNotificationRequest to NewNotificationRequestV21. Now there are errors before running

* changed NewNotificationRequest to NewNotificationRequestV21. Now there are errors before running

* fix file with errors after using NewNotificationRequestV21

* fix file with errors after using NewNotificationRequestV21

* eslint fix

* completed again VL-295

* completed again VL-295

* completed again VL-295

* still fix to do

* added todo denny

* first todo denny fix completed

* eslint fix

* fix for VL-295 due to issue in other files

* eslint suggested fixes

* eslint suggested fixes

* fix for VL-295 w/ Cosmin

* eslint fix

* eslint fix

* eslint fix

* changing old type to the new ones

* eslint fix

* eslint fix

* eslint fix

* removed unused enum

* fix accepted issue

* fix tslint issues

* fix tslint issue

* Features/2.1/main (#12)

* partial permit upload of json during uploadS3

* partial permit upload of json during uploadS3

* partial permit upload of json during uploadS3

* handled attachmentName 'F24'

* completed VL-294 + fix critical severity vulnerability in package-lock.json raised by npm install command

* added semicolon due to husky error

* eslint fix

* fix reference to delivery-push url

* fix

* fix imports

* fix req 7 handling

* fix req 7 handling

* update package-lock

* completed VL-296

* completed VL-296

* VL-298 completed

* VL-299 completed

* added collection json + 2.1 version

---------




* Features/2.1/main (#13)

* partial permit upload of json during uploadS3

* partial permit upload of json during uploadS3

* partial permit upload of json during uploadS3

* handled attachmentName 'F24'

* completed VL-294 + fix critical severity vulnerability in package-lock.json raised by npm install command

* added semicolon due to husky error

* eslint fix

* fix reference to delivery-push url

* fix

* fix imports

* fix req 7 handling

* fix req 7 handling

* update package-lock

* completed VL-296

* completed VL-296

* VL-298 completed

* VL-299 completed

* added collection json + 2.1 version

* update tests

* fix tests

* fix tests

---------




* fix tests

---------




* removed fluffy comments

* pr update 291 (#17)

* generated yaml from version 2.1

* commented 'F24Metadata' schema inside yaml, due error generating models

* updated 'hot-to-generate-the...md'

* completed VL-295

* eslint fix

* eslint fix

* changed NewNotificationRequest to NewNotificationRequestV21. Now there are errors before running

* changed NewNotificationRequest to NewNotificationRequestV21. Now there are errors before running

* fix file with errors after using NewNotificationRequestV21

* fix file with errors after using NewNotificationRequestV21

* eslint fix

* completed again VL-295

* completed again VL-295

* completed again VL-295

* still fix to do

* added todo denny

* first todo denny fix completed

* eslint fix

* fix for VL-295 due to issue in other files

* eslint suggested fixes

* eslint suggested fixes

* fix for VL-295 w/ Cosmin

* eslint fix

* eslint fix

* eslint fix

* changing old type to the new ones

* eslint fix

* eslint fix

* eslint fix

* removed unused enum

* fix accepted issue

* fix tslint issues

* fix tslint issue

* Features/2.1/main (#12)

* partial permit upload of json during uploadS3

* partial permit upload of json during uploadS3

* partial permit upload of json during uploadS3

* handled attachmentName 'F24'

* completed VL-294 + fix critical severity vulnerability in package-lock.json raised by npm install command

* added semicolon due to husky error

* eslint fix

* fix reference to delivery-push url

* fix

* fix imports

* fix req 7 handling

* fix req 7 handling

* update package-lock

* completed VL-296

* completed VL-296

* VL-298 completed

* VL-299 completed

* added collection json + 2.1 version

---------




* Features/2.1/main (#13)

* partial permit upload of json during uploadS3

* partial permit upload of json during uploadS3

* partial permit upload of json during uploadS3

* handled attachmentName 'F24'

* completed VL-294 + fix critical severity vulnerability in package-lock.json raised by npm install command

* added semicolon due to husky error

* eslint fix

* fix reference to delivery-push url

* fix

* fix imports

* fix req 7 handling

* fix req 7 handling

* update package-lock

* completed VL-296

* completed VL-296

* VL-298 completed

* VL-299 completed

* added collection json + 2.1 version

* update tests

* fix tests

* fix tests

---------




* fix tests

---------




* removed fluffy comments

* completede basic behavior of 291 and 292

* eslint fix

* eslint fix

* basic working version of 291+292

* eslint fix

* changed from manual retrieving to automatic one within map

* eslint fix

* updated yaml to version 2.0 (#23)



---------

Co-authored-by: Cosmin Constantin Tuduran <cosminconstantin.tuduran@nttdata.com>
Co-authored-by: Cosmin15 <Tuduran.cosmin@gmail.com>

* Pull from Features/2.0/main to VL-291 #2 (#27)

* merge main from features/2.0/main (#14)

* generated yaml from version 2.1

* commented 'F24Metadata' schema inside yaml, due error generating models

* updated 'hot-to-generate-the...md'

* completed VL-295

* eslint fix

* eslint fix

* changed NewNotificationRequest to NewNotificationRequestV21. Now there are errors before running

* changed NewNotificationRequest to NewNotificationRequestV21. Now there are errors before running

* fix file with errors after using NewNotificationRequestV21

* fix file with errors after using NewNotificationRequestV21

* eslint fix

* completed again VL-295

* completed again VL-295

* completed again VL-295

* still fix to do

* added todo denny

* first todo denny fix completed

* eslint fix

* fix for VL-295 due to issue in other files

* eslint suggested fixes

* eslint suggested fixes

* fix for VL-295 w/ Cosmin

* eslint fix

* eslint fix

* eslint fix

* changing old type to the new ones

* eslint fix

* eslint fix

* eslint fix

* removed unused enum

* fix accepted issue

* fix tslint issues

* fix tslint issue

* Features/2.1/main (#12)

* partial permit upload of json during uploadS3

* partial permit upload of json during uploadS3

* partial permit upload of json during uploadS3

* handled attachmentName 'F24'

* completed VL-294 + fix critical severity vulnerability in package-lock.json raised by npm install command

* added semicolon due to husky error

* eslint fix

* fix reference to delivery-push url

* fix

* fix imports

* fix req 7 handling

* fix req 7 handling

* update package-lock

* completed VL-296

* completed VL-296

* VL-298 completed

* VL-299 completed

* added collection json + 2.1 version

---------

Co-authored-by: Cosmin15 <Tuduran.cosmin@gmail.com>
Co-authored-by: Tuduran, Cosmin Constantin <cosminconstantin.tuduran@nttdata.com>

* Features/2.1/main (#13)

* partial permit upload of json during uploadS3

* partial permit upload of json during uploadS3

* partial permit upload of json during uploadS3

* handled attachmentName 'F24'

* completed VL-294 + fix critical severity vulnerability in package-lock.json raised by npm install command

* added semicolon due to husky error

* eslint fix

* fix reference to delivery-push url

* fix

* fix imports

* fix req 7 handling

* fix req 7 handling

* update package-lock

* completed VL-296

* completed VL-296

* VL-298 completed

* VL-299 completed

* added collection json + 2.1 version

* update tests

* fix tests

* fix tests

---------

Co-authored-by: Cosmin15 <Tuduran.cosmin@gmail.com>
Co-authored-by: Tuduran, Cosmin Constantin <cosminconstantin.tuduran@nttdata.com>

* fix tests

---------

Co-authored-by: Cosmin Constantin Tuduran <cosminconstantin.tuduran@nttdata.com>
Co-authored-by: Cosmin15 <Tuduran.cosmin@gmail.com>

* removed fluffy comments

* pr update 291 (#17)

* generated yaml from version 2.1

* commented 'F24Metadata' schema inside yaml, due error generating models

* updated 'hot-to-generate-the...md'

* completed VL-295

* eslint fix

* eslint fix

* changed NewNotificationRequest to NewNotificationRequestV21. Now there are errors before running

* changed NewNotificationRequest to NewNotificationRequestV21. Now there are errors before running

* fix file with errors after using NewNotificationRequestV21

* fix file with errors after using NewNotificationRequestV21

* eslint fix

* completed again VL-295

* completed again VL-295

* completed again VL-295

* still fix to do

* added todo denny

* first todo denny fix completed

* eslint fix

* fix for VL-295 due to issue in other files

* eslint suggested fixes

* eslint suggested fixes

* fix for VL-295 w/ Cosmin

* eslint fix

* eslint fix

* eslint fix

* changing old type to the new ones

* eslint fix

* eslint fix

* eslint fix

* removed unused enum

* fix accepted issue

* fix tslint issues

* fix tslint issue

* Features/2.1/main (#12)

* partial permit upload of json during uploadS3

* partial permit upload of json during uploadS3

* partial permit upload of json during uploadS3

* handled attachmentName 'F24'

* completed VL-294 + fix critical severity vulnerability in package-lock.json raised by npm install command

* added semicolon due to husky error

* eslint fix

* fix reference to delivery-push url

* fix

* fix imports

* fix req 7 handling

* fix req 7 handling

* update package-lock

* completed VL-296

* completed VL-296

* VL-298 completed

* VL-299 completed

* added collection json + 2.1 version

---------

Co-authored-by: Cosmin15 <Tuduran.cosmin@gmail.com>
Co-authored-by: Tuduran, Cosmin Constantin <cosminconstantin.tuduran@nttdata.com>

* Features/2.1/main (#13)

* partial permit upload of json during uploadS3

* partial permit upload of json during uploadS3

* partial permit upload of json during uploadS3

* handled attachmentName 'F24'

* completed VL-294 + fix critical severity vulnerability in package-lock.json raised by npm install command

* added semicolon due to husky error

* eslint fix

* fix reference to delivery-push url

* fix

* fix imports

* fix req 7 handling

* fix req 7 handling

* update package-lock

* completed VL-296

* completed VL-296

* VL-298 completed

* VL-299 completed

* added collection json + 2.1 version

* update tests

* fix tests

* fix tests

---------

Co-authored-by: Cosmin15 <Tuduran.cosmin@gmail.com>
Co-authored-by: Tuduran, Cosmin Constantin <cosminconstantin.tuduran@nttdata.com>

* fix tests

---------

Co-authored-by: Cosmin Constantin Tuduran <cosminconstantin.tuduran@nttdata.com>
Co-authored-by: Cosmin15 <Tuduran.cosmin@gmail.com>

* removed fluffy comments

* completede basic behavior of 291 and 292

* eslint fix

* eslint fix

* basic working version of 291+292

* eslint fix

* changed from manual retrieving to automatic one within map

* eslint fix

* updated yaml to version 2.0 (#23)

Co-authored-by: Cosmin Constantin Tuduran <cosminconstantin.tuduran@nttdata.com>

---------

Co-authored-by: Cosmin Constantin Tuduran <cosminconstantin.tuduran@nttdata.com>
Co-authored-by: Cosmin15 <Tuduran.cosmin@gmail.com>

* fix after VL-288 merge

* completed VL-290

* eslint fix

* eslint fix

* eslint fix

---------

Co-authored-by: Cosmin Constantin Tuduran <cosminconstantin.tuduran@nttdata.com>
Co-authored-by: Cosmin15 <Tuduran.cosmin@gmail.com>

* update index.ts

* eslint fix

* general fixes for version 2.0

* eslint fix

* eslint fix

* eslint fix

* from main to main/2.0 (#32) (#33)

* final fix for main

* eslint fix

* fix for duplicated timeline event

* fix for duplicated timeline event

* update postman collection

* disabled a test

* code duplication fix

* fix for code duplication #2

* eslint fix

* update to 2.1.1 version

* fix for undefined values output obj

* eslint fix

* completed VL-302

* update package-lock.version

---------

Co-authored-by: Cosmin Constantin Tuduran <cosminconstantin.tuduran@nttdata.com>
Co-authored-by: Cosmin15 <Tuduran.cosmin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants