Allow to fully parse spec files with missing local sources #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build failed.
|
|
Build failed.
|
5615235 to
65568e0
Compare
|
Build failed.
|
65568e0 to
9067ece
Compare
|
Build failed.
|
9067ece to
e9c7125
Compare
|
Build failed.
|
e9c7125 to
6f64b66
Compare
|
Build failed.
|
6f64b66 to
88cc224
Compare
|
Build failed.
|
88cc224 to
8b962ff
Compare
|
Build failed.
|
|
As you mentioned earlier, zuul doesn't seem to like having target branch as something else than main/master. The |
It should work after I change the base branch (after PR #20 is merged). |
6c28ab4 to
18e62d9
Compare
|
Build failed.
|
RPM is unable to fully parse a spec file if some sources are missing. Only so called non-build parse is possible in that case, but the result is not the same, it's like the sources weren't even defined. Overcome that by creating a temporary dummy source for every source that is missing locally. Mimic file signatures of compressed sources to make RPM behave exactly the same when processing a dummy source. Signed-off-by: Nikola Forró <nforro@redhat.com>
|
Build failed.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RPM is unable to fully parse a spec file if some sources are missing. Only so called non-build parse is possible in that case, but the result is not the same, it's like the sources weren't even defined.
Overcome that by creating a temporary dummy source for every source that is missing locally. Mimic file signatures of compressed sources to make RPM behave exactly the same when processing a dummy source.
Fixes #19.