Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement high-level manipulation of sources/patches #20

Merged
merged 2 commits into from
Mar 29, 2022
Merged

Implement high-level manipulation of sources/patches #20

merged 2 commits into from
Mar 29, 2022

Conversation

nforro
Copy link
Member

@nforro nforro commented Mar 4, 2022 •
edited
Loading

Known issues:

Fixes #12.

@nforro nforro requested a review from FrNecas March 4, 2022 15:05
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@nforro nforro force-pushed the nforro-sources-patches branch from de7c6ea to 3b28aff Compare March 5, 2022 14:10
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@nforro nforro force-pushed the nforro-sources-patches branch from 3b28aff to a190a44 Compare March 5, 2022 16:31
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

FrNecas
FrNecas reviewed Mar 8, 2022
View reviewed changes
Copy link
Contributor

@FrNecas FrNecas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, the sources are very complicated... A few questions/notes, I'd also like to see some unit tests. Right now it's a bit hard to imagine how everything is going to work. I've tested it on a few simple examples and it seems to work fine, I will try to do a bit more experimenting later with some combinations of tags and lists.

specfile/sourcelist.py Show resolved Hide resolved
specfile/sourcelist.py Outdated Show resolved Hide resolved
specfile/sourcelist.py Outdated Show resolved Hide resolved
specfile/sources.py Outdated Show resolved Hide resolved
specfile/sources.py Outdated Show resolved Hide resolved
specfile/sources.py Outdated Show resolved Hide resolved
specfile/sources.py Show resolved Hide resolved
specfile/sources.py Outdated Show resolved Hide resolved
specfile/sources.py Outdated Show resolved Hide resolved
@nforro nforro force-pushed the nforro-sources-patches branch from a190a44 to 8bacc73 Compare March 8, 2022 12:49
@nforro
Copy link
Member Author

nforro commented Mar 8, 2022

I've made some of the suggested changes and added (some) unit tests.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@nforro nforro force-pushed the nforro-sources-patches branch 2 times, most recently from 82dcbc7 to b980f30 Compare March 8, 2022 16:14
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@nforro nforro force-pushed the nforro-sources-patches branch from b980f30 to d8af88b Compare March 16, 2022 11:46
@nforro nforro marked this pull request as ready for review March 16, 2022 11:47
@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@nforro nforro force-pushed the nforro-sources-patches branch 2 times, most recently from 6d93385 to 5615235 Compare March 16, 2022 16:01
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@nforro nforro force-pushed the nforro-sources-patches branch from 5615235 to 65568e0 Compare March 18, 2022 12:18
@nforro nforro changed the base branch from main to nforro-pre-commit March 18, 2022 12:20
@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@nforro nforro force-pushed the nforro-pre-commit branch from c791cdf to 59ecb33 Compare March 18, 2022 12:25
@nforro nforro force-pushed the nforro-sources-patches branch from 65568e0 to 9067ece Compare March 18, 2022 12:30
@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@nforro nforro force-pushed the nforro-pre-commit branch from 59ecb33 to 98f8d5e Compare March 22, 2022 09:30
@nforro nforro force-pushed the nforro-sources-patches branch from 9067ece to e9c7125 Compare March 22, 2022 09:31
@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@delete-merged-branch delete-merged-branch bot deleted the branch main March 22, 2022 09:45
@nforro nforro changed the base branch from nforro-pre-commit to main March 22, 2022 09:47
@nforro
Copy link
Member Author

nforro commented Mar 22, 2022

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@nforro nforro force-pushed the nforro-sources-patches branch from e9c7125 to 6f64b66 Compare March 22, 2022 12:46
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@nforro nforro force-pushed the nforro-sources-patches branch from 6f64b66 to 88cc224 Compare March 24, 2022 16:48
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@nforro
Copy link
Member Author

nforro commented Mar 24, 2022

/packit build

@nforro nforro force-pushed the nforro-sources-patches branch from 88cc224 to 8b962ff Compare March 25, 2022 11:51
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

FrNecas
FrNecas approved these changes Mar 25, 2022
View reviewed changes
Copy link
Contributor

@FrNecas FrNecas left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after the changes as far as I can tell right now, we can fix some smaller stuff later if we find a bug/oversight. Just one docs nitpick for clarity.

specfile/sourcelist.py Outdated Show resolved Hide resolved
@nforro nforro mentioned this pull request Mar 25, 2022
Merged
@nforro nforro force-pushed the nforro-sources-patches branch from 8b962ff to d74ba7f Compare March 28, 2022 12:23
@nforro
Copy link
Member Author

nforro commented Mar 28, 2022 •
edited
Loading

@FrNecas Could you have one final look before I merge this? I've made the attributes of TagSource, ListSource and Sources private.

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@nforro nforro force-pushed the nforro-sources-patches branch 2 times, most recently from facd4a5 to 6c28ab4 Compare March 28, 2022 12:32
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

nforro added 2 commits March 28, 2022 14:50
@nforro
Implement high-level manipulation of sources/patches
be12dd0 
Signed-off-by: Nikola Forró <nforro@redhat.com>
@nforro
Add integration tests for sources/patches
18e62d9 
Signed-off-by: Nikola Forró <nforro@redhat.com>
@nforro nforro force-pushed the nforro-sources-patches branch from 6c28ab4 to 18e62d9 Compare March 28, 2022 12:50
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@nforro nforro added the mergeit Zuul, merge it! label Mar 29, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build failed (gate pipeline).

@nforro nforro merged commit ad161e6 into main Mar 29, 2022
@delete-merged-branch delete-merged-branch bot deleted the nforro-sources-patches branch March 29, 2022 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FrNecas FrNecas FrNecas approved these changes

Assignees
No one assigned
Labels
mergeit Zuul, merge it!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement high-level manipulation of sources and patches
2 participants
@nforro @FrNecas