Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't include parent selector in fetch by ID #2394

Merged
merged 1 commit into from
Aug 22, 2024
Merged

Don't include parent selector in fetch by ID #2394

merged 1 commit into from
Aug 22, 2024

Conversation

david-crespo
Copy link
Collaborator

Followup to #2393

@vercel Vercel
Copy link

vercel bot commented Aug 22, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
console ✅ Ready (Inspect) Visit Preview Aug 22, 2024 11:49pm

@david-crespo david-crespo enabled auto-merge (squash) August 22, 2024 23:49
@david-crespo david-crespo changed the title Fix bug due to including parent selector in router fetch Fix bug due to including parent selector in fetch by ID Aug 22, 2024
@david-crespo david-crespo changed the title Fix bug due to including parent selector in fetch by ID Don't include parent selector in fetch by ID Aug 22, 2024
@david-crespo david-crespo merged commit 9ff6ac6 into main Aug 22, 2024
8 checks passed
@david-crespo david-crespo deleted the no-parent-selector branch August 22, 2024 23:57
david-crespo added a commit to oxidecomputer/omicron that referenced this pull request Aug 22, 2024
@david-crespo
Bump web console (custom routers on subnets)
4e7001e 
oxidecomputer/console@8dcddce...9ff6ac6

* [9ff6ac6c](oxidecomputer/console@9ff6ac6c) oxidecomputer/console#2394
* [8028f9a5](oxidecomputer/console@8028f9a5) oxidecomputer/console#2393
* [1bb92706](oxidecomputer/console@1bb92706) oxidecomputer/console#2339
@david-crespo david-crespo mentioned this pull request Aug 22, 2024
Merged
david-crespo added a commit to oxidecomputer/omicron that referenced this pull request Aug 23, 2024
@david-crespo
Bump web console (custom routers on subnets) (#6418)
7b9fee2 
oxidecomputer/console@8dcddce...9ff6ac6

* [9ff6ac6c](oxidecomputer/console@9ff6ac6c)
oxidecomputer/console#2394
* [8028f9a5](oxidecomputer/console@8028f9a5)
oxidecomputer/console#2393
* [1bb92706](oxidecomputer/console@1bb92706)
oxidecomputer/console#2339
@david-crespo david-crespo mentioned this pull request Aug 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@david-crespo