Choose custom router on subnet create/edit forms #2393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…will have to be reverted.
96196ea to
b4e9277
Compare
b4e9277 to
5b1dd2a
Compare
| await expect(rows.nth(1).getByText('10.1.1.2/24')).toBeVisible() | ||
| // little hack to catch a bug where we weren't handling empty input here properly | ||
| await dialog.getByRole('textbox', { name: 'IPv6 block' }).fill('abc') | ||
| await dialog.getByRole('textbox', { name: 'IPv6 block' }).clear() |
There was a problem hiding this comment.
Confirmed this bit breaks the test without the fix for the ipv6Block field. This is a bug in v9!
david-crespo
approved these changes
Aug 22, 2024
There was a problem hiding this comment.
I think this is solid. I like the string sentinel value pattern for a clearable listbox. It might make sense to build this logic into the listbox field itself somehow, so we don't have to manually wire up the conversion between form values and JSON values. On the other hand, it seems like the way we're doing it is kinda how you're supposed to do it — RHF doesn't seem to like it when you try to store the processed maybe-not-a-string value in the form state.
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Aug 22, 2024
This was referenced Aug 22, 2024
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a field on the subnet create/edit form, enabling linking a custom router to the subnet.
Fixes #2379